hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7934] Fix RocksDBDAO prefixDelete to delete last entry properly

Open wombatu-kun opened this issue 1 year ago • 1 comments

Change Logs

Done this https://github.com/apache/hudi/issues/11075
+
Fix UT:
Accordinly to commented code, all items must be deleted:

// Delete the last entry
getRocksDB().delete(getUTF8Bytes(lastEntry));

I fixed deletion of last entry and fix assertion in UT.

Impact

RocksDBDAO prefixDelete deletes all items

Risk level (write none, low medium or high below)

none

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

wombatu-kun avatar Jun 27 '24 09:06 wombatu-kun

CI report:

  • c69971789a3d498b8f2480bcd8bc08d833ed7e06 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Jun 27 '24 11:06 hudi-bot

Somebody, please, merge it or close it.

wombatu-kun avatar Jul 16 '24 02:07 wombatu-kun