hudi icon indicating copy to clipboard operation
hudi copied to clipboard

add show create table command

Open houyuting opened this issue 1 year ago • 3 comments

Change Logs

add show create table command feature

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.

Contributor's checklist

  • [x] Read through contributor's guide
  • [x] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

houyuting avatar Jun 18 '24 17:06 houyuting

@houyuting Nice contributtion, there are some compile errors that need to be taken care of.

danny0405 avatar Jun 19 '24 00:06 danny0405

Still, we got some compile errors:

Error:  /home/runner/work/hudi/hudi/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:545: error: wrong number of arguments for pattern org.apache.spark.sql.execution.command.ShowCreateTableCommand(table: org.apache.spark.sql.catalyst.TableIdentifier)
Error:        case ShowCreateTableCommand(tableId, _)
Error:                                   ^
Warning:  /home/runner/work/hudi/hudi/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ExportInstantsProcedure.scala:129: warning: A try without a catch or finally is equivalent to putting its body in a block; no exceptions are handled.
Warning:          try {
Warning:          ^
Warning:  /home/runner/work/hudi/hudi/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ValidateHoodieSyncProcedure.scala:171: warning: A try without a catch or finally is equivalent to putting its body in a block; no exceptions are handled.
Warning:      try {
Warning:      ^
Warning: [WARNING] two warnings found
Error: [ERROR] one error found

danny0405 avatar Jun 20 '24 04:06 danny0405

CI report:

  • bf2d2fc79a4d893639671f8985d7e98db11ec0e1 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Jul 05 '24 14:07 hudi-bot

Nice work, please add some tests to cover the new function.

beyond1920 avatar Jul 08 '24 03:07 beyond1920