hudi icon indicating copy to clipboard operation
hudi copied to clipboard

Published 20 hours ago • verified publisher icon apache

[MINOR] fix the error message for glue sync tool

Open prabodh1194 opened this issue 1 year ago • 5 comments

Change Logs

When I tried using GLUE mode for syncing meta, I kept getting an error about entering an incorrect mode. I realised a but later that my --sync-tool-classes setting was not pointing to org.apache.hudi.aws.sync.AwsGlueCatalogSyncTool. A better error message will go a long way in improve developer experience in this regard.

Impact

Better error message. No public impact.

Risk level (write none, low medium or high below)

none.

Documentation Update

"none"

Contributor's checklist

  • [x] Read through contributor's guide
  • [x] Change Logs and Impact were stated clearly
  • [x] Adequate tests were added if applicable
  • [x] CI passed

prabodh1194 avatar Jun 11 '24 06:06 prabodh1194

@prabodh1194 is this PR still in draft?

yihua avatar Jun 23 '24 19:06 yihua

@prabodh1194 is this PR still in draft?

nope. i just wanted to add a test case for this. couldn't do it yet.

prabodh1194 avatar Jun 25 '24 06:06 prabodh1194

@yihua can you please review this now. i finally figured out how to add the correct test case 😄

prabodh1194 avatar Jun 29 '24 17:06 prabodh1194

@danny0405 can you please review this 🙏🏼

prabodh1194 avatar Jul 01 '24 02:07 prabodh1194

CI report:

  • 74e0b63b7782f61326bef0d2aeada77dc79289b4 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Jul 04 '24 16:07 hudi-bot

since the other PR - https://github.com/apache/hudi/pull/11543 is merged, this PR is not required anymore.

prabodh1194 avatar Jul 05 '24 03:07 prabodh1194