hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7711] Fix MultiTableStreamer can deal with path of properties files

Open hwani3142 opened this issue 1 year ago • 4 comments

Change Logs

  • fix copy logic on MultiTableStreamer
    • copy propsFilePath into child streamer (child can read explicit configFile)
    • copy MultiStreamer's config into child (child can also read passed settings)
  • override trivial functions for HoodieMultiTableStreamer.Config
  • add some test with test properties

Impact

HoodieMultiTableStreamer

Risk level (write none, low medium or high below)

low

Documentation Update

none

Contributor's checklist

  • [x] Read through contributor's guide
  • [x] Change Logs and Impact were stated clearly
  • [x] Adequate tests were added if applicable
  • [x] CI passed

hwani3142 avatar May 04 '24 16:05 hwani3142

Hey, any update on this? This seems to completely break multitablestreamer or is there any workaround for this?

Hans-Raintree avatar Jun 25 '24 15:06 Hans-Raintree

Maybe @lokeshj1703 can take a look on this.

danny0405 avatar Jun 26 '24 03:06 danny0405

Any news on this issue ?

fijemax avatar Aug 14 '24 15:08 fijemax

@yihua I missed reviews Sorry for delaying check comments.

@lokeshj1703 Please review remains again

hwani3142 avatar Sep 12 '24 15:09 hwani3142

@hwani3142 I created a docs update ticket for you: HUDI-8225.

yihua avatar Sep 21 '24 05:09 yihua

@hudi-bot run azure

yihua avatar Sep 21 '24 05:09 yihua

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Sep 21 '24 06:09 hudi-bot