hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7532] Include only compaction instants for lastCompaction in getDeltaCommitsSinceLatestCompaction

Open nsivabalan opened this issue 1 year ago • 2 comments

Change Logs

Fixing schedule compaction bug.
Looks like when polling timeline for last successful compaction commits, we also include replace commits. So, if a user sets clustering freq to 4 and compaction freq to 5, compaction scheduling may never kick in at all.

Impact

Scheduling of compaction will be triggered at the cadence configured.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

nsivabalan avatar Mar 22 '24 22:03 nsivabalan

@nsivabalan could you rebase the PR on the latest master and address the review comments?

yihua avatar May 03 '24 02:05 yihua

CI report:

  • 21fca8151efa9b404eac415e7432606f1bfb9658 Azure: FAILURE
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar May 14 '24 19:05 hudi-bot

image azure is actually passing

jonvex avatar May 15 '24 00:05 jonvex