hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7391] HoodieMetadataMetrics should use Metrics instance for metrics registry

Open lokeshj1703 opened this issue 1 year ago • 2 comments

Change Logs

Currently HoodieMetadataMetrics stores metrics in memory and these metrics are not pushed by the metric reporters. The metric reporters are configured within Metrics instance. List of changes in the PR:

  1. Metrics related classes have been moved from hudi-client-common to hudi-common.
  2. HoodieMetadataMetrics now uses Metrics class so that all the reporters can be supported with it.
  3. Some gaps in configs which are added in HoodieMetadataWriteUtils
  4. Some metrics related apis and functionality has been moved to HoodieMetricsConfig. The HoodieWriteConfig APIs now delegate to HoodieMetricsConfig for the functionality.

Impact

There are constructors and APIs which were using HoodieWriteConfig earlier. Now they are using HoodieMetricsConfig. HoodieMetricsConfig can be obtained by calling getMetricsConfig() from the HoodieWriteConfig object.

Risk level (write none, low medium or high below)

low

Documentation Update

There are constructors and APIs which were using HoodieWriteConfig earlier. Now they are using HoodieMetricsConfig. HoodieMetricsConfig can be obtained by calling getMetricsConfig() from the HoodieWriteConfig object.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

lokeshj1703 avatar Feb 07 '24 07:02 lokeshj1703

hey @prashantwason : can you review this patch please

nsivabalan avatar Feb 10 '24 02:02 nsivabalan

CI report:

  • 87b39716e5db65cd75196fc2150476f674e0baab Azure: PENDING
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Apr 11 '24 05:04 hudi-bot

Azure CI passed: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=23176&view=results Screenshot 2024-04-11 at 1 30 30 PM

codope avatar Apr 11 '24 08:04 codope