hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7237] Hudi Streamer: Handle edge case with null schema, minor cleanups

Open the-other-tim-brown opened this issue 1 year ago • 1 comments
trafficstars

Change Logs

  • Reduces number of calls to schema provider by properly using orElseGet in one case and reusing existing writer config instead of recomputing
  • Reuses existing hadoop configuration instance instead of creating new one when possible
  • Handles case where schema provider returns null and there is an empty batch

Impact

  • Reduces number of calls to schema providers which can reduce load on the provider or cost of accessing file system
  • Fixes edge case where an empty batch could write a commit with a null value as the schema

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

the-other-tim-brown avatar Dec 17 '23 01:12 the-other-tim-brown

@hudi-bot run azure

the-other-tim-brown avatar Jan 22 '24 23:01 the-other-tim-brown

CI report:

  • cb62ad9bed32bf3acc6f8227e5e824cb73e8f0e4 UNKNOWN
  • e83c0ad8df5632271dd53f03dedf5410d307e19e Azure: FAILURE
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Jan 23 '24 00:01 hudi-bot

image

nsivabalan avatar Jan 24 '24 00:01 nsivabalan