hudi
hudi copied to clipboard
[HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in…
…cremental queries
Change Logs
A new auziliary component for analyzng the incremental query context.
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
- The config description must be updated if new configs are added or the default value of the configs are changed
- Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.
Contributor's checklist
- [ ] Read through contributor's guide
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
Overall it looks solid to me. Only concern is that this code is very critical and complex, do we have enough tests to ensure the correctness?
Overall it looks solid to me. Only concern is that this code is very critical and complex, do we have enough tests to ensure the correctness?
We have all the tests for each use case in TestInputFormat
and TestIncrementalInputSplits
, they are currently Flink UTs, somehow we need to refactor the tests into the hudi-common
. (an engine agnostic data set validation).
CI report:
- 3153fe03616237ff7814c53923fec2a2504b6d01 Azure: SUCCESS
Bot commands
@hudi-bot supports the following commands:-
@hudi-bot run azure
re-run the last Azure build