hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in…

Open danny0405 opened this issue 1 year ago • 3 comments

…cremental queries

Change Logs

A new auziliary component for analyzng the incremental query context.

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

danny0405 avatar Dec 06 '23 10:12 danny0405

Overall it looks solid to me. Only concern is that this code is very critical and complex, do we have enough tests to ensure the correctness?

linliu-code avatar Dec 15 '23 20:12 linliu-code

Overall it looks solid to me. Only concern is that this code is very critical and complex, do we have enough tests to ensure the correctness?

We have all the tests for each use case in TestInputFormat and TestIncrementalInputSplits, they are currently Flink UTs, somehow we need to refactor the tests into the hudi-common. (an engine agnostic data set validation).

danny0405 avatar Dec 16 '23 11:12 danny0405

CI report:

  • 3153fe03616237ff7814c53923fec2a2504b6d01 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Feb 12 '24 20:02 hudi-bot