horaedb icon indicating copy to clipboard operation
horaedb copied to clipboard

Ignore backtrace for 4xx error

Open jiacai2050 opened this issue 3 years ago • 0 comments

Describe This Problem

When testing, I found 400 errors are logged with backtrace:

2023-03-21 02:56:11.289 ERRO [server/src/http.rs:608] handle error: Rejection(GRPCWriteError { source: ErrWithCause { code: 403, msg: "Insert is blocked", source: BlockedTable { table: "cse_rpc_duration_seconds_bucket", backtrace: Backtrace(   0: <snafu::backtrace_shim::Backtrace as snafu::GenerateBacktrace>::generate
             at usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/snafu-0.6.10/src/backtrace_shim.rs:15:19
      server::limiter::BlockedTable<__T0>::build
             at ceresdb/server/src/limiter.rs:10:10
      server::limiter::BlockedTable<__T0>::fail
             at ceresdb/server/src/limiter.rs:10:10
      server::limiter::Limiter::try_limit_by_block_list
             at ceresdb/server/src/limiter.rs:126:21
      server::limiter::Limiter::try_limit
             at ceresdb/server/src/limiter.rs:152:9
   1: server::grpc::storage_service::write::execute_plan::{{closure}}
             at ceresdb/server/src/grpc/storage_service/write.rs:157:5
   2: <server::handlers::prom::CeresDBStorage<Q> as prom_remote_api::types::RemoteStorage>::write::{{closure}}
             at ceresdb/server/src/handlers/prom.rs:269:13
   3: <core::pin::Pin<P> as core::future::future::Future>::poll
             at rustc/11d96b59307b1702fffe871bfc2d0145d070881e/library/core/src/future/future.rs:125:9
      prom_remote_api::web::warp::write::{{closure}}
             at usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/prom-remote-api-0.2.1/src/web/warp.rs:30:9
      <F as futures_core::future::TryFuture>::try_poll
             at usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-0.3.25/src/future.rs:82:9
      <warp::filter::and_then::State<T,F> as core::future::future::Future>::poll
             at usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/warp-0.3.3/src/filter/and_then.rs:99:44
   4: <warp::filter::and_then::AndThenFuture<T,F> as core::future::future::Future>::poll
             at usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/warp-0.3.3/src/filter/and_then.rs:74:9
      <F as futures_core::future::TryFuture>::try_poll
             at usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-0.3.25/src/future.rs:82:9

Proposal

  • Those error logged at warn level
  • Remove backtrace when logging

Additional Context

No response

jiacai2050 avatar Mar 21 '23 02:03 jiacai2050