horaedb icon indicating copy to clipboard operation
horaedb copied to clipboard

Tracking issue for fix TODO comments

Open jiacai2050 opened this issue 2 years ago • 3 comments

Describe This Problem

Hi community,

Our codebase contains numerous 200+ TODOs now! This indicates significant technical debt. Ignoring this will inevitably cause severe code rot.

As a community, we must acknowledge this problem affects our collective interests. While specific individuals may own portions of the code, we share responsibility for the overall health of our ecosystem.

The time to act is now. Let's work together to strengthen the foundation of our codebase before decay spreads further. Our future depends on it.

Proposal

I will begin this task by review, list the most easy TODOs first, anyone interested are welcome to help us fixing them.

Additional Context

  1. [x] https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/benchmarks/src/merge_sst_bench.rs#L170
  2. [x] https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/components/future_ext/src/retry.rs#L24
  3. [ ] https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/components/tracing_util/src/logging.rs#L129
  4. [ ] https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/table_engine/src/partition/rule/key.rs#L240
  5. [ ] https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/components/parquet_ext/src/prune/min_max.rs#L91
  6. [ ] https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/analytic_engine/src/instance/wal_replayer.rs#L377
  7. [ ] https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/analytic_engine/src/manifest/details.rs#L379

jiacai2050 avatar Jan 26 '24 03:01 jiacai2050

To avoid conflicts with others, please lease leave an comment below to tell us which TODO you're going to fix.

jiacai2050 avatar Jan 26 '24 03:01 jiacai2050

Working on "TODO: Replay logs of different tables in parallel. "

Lethannn avatar Feb 03 '24 07:02 Lethannn

Working on "TODO: make level configurable " Working on "TODO: add backoff "

zealchen avatar Feb 21 '24 09:02 zealchen

@Lethannn It's has been quiet for a while, I wonder if there are any problems when you implement this task?

jiacai2050 avatar Mar 01 '24 08:03 jiacai2050

@Lethannn It's has been quiet for a while, I wonder if there are any problems when you implement this task?

Apologies for the silence lately. I've been dealing with some health issues over the past few weeks :( . Planning to tackle the task this weekend

Lethannn avatar Mar 01 '24 09:03 Lethannn

I've been dealing with some health issues over the past few weeks

Sorry to hear that, let me know if you need any help.

jiacai2050 avatar Mar 04 '24 03:03 jiacai2050

Working on "TODO: props should be an argument " and "use NonZeroUsize "

zealchen avatar Mar 08 '24 21:03 zealchen

Tasks are all finished, thanks everyone involved.

Will open an new issue to track more TODO.

jiacai2050 avatar Mar 12 '24 09:03 jiacai2050