horaedb icon indicating copy to clipboard operation
horaedb copied to clipboard

Submodule is not supported in CI

Open waynexia opened this issue 3 years ago • 1 comments

Describe this problem Submodule is not supported in CI

Steps to reproduce Trigger CI, and some cases that need submodule will fail.

Expected behavior CI should be able to pull submodule

Additional Information GitHub Action plugin checkout has an option with_submodule which should work for us.

One failing test from CI:

{ "type": "test", "name": "serialized_reader::tests::test_file_reader_with_cache", "event": "failed", "stdout": "thread 'serialized_reader::tests::test_file_reader_with_cache' panicked at 'failed to get parquet data dir: env `PARQUET_TEST_DATA` is undefined or has empty value, and the pre-defined data dir `/__w/ceresdb/ceresdb/components/parquet/../parquet-testing/data` not found\nHINT: try running `git submodule update --init`', components/parquet/src/tests.rs:55:21\nstack backtrace:\n   0: rust_begin_unwind\n             at /rustc/f1ce0e6a00593493a12e0e3662119786c761f375/library/std/src/panicking.rs:498:5\n   1: core::panicking::panic_fmt\n             at /rustc/f1ce0e6a00593493a12e0e3662119786c761f375/library/core/src/panicking.rs:107:14\n   2: parquet::tests::parquet_test_data\n             at ./src/tests.rs:55:21\n   3: parquet::tests::get_test_path\n             at ./src/tests.rs:61:42\n   4: parquet::tests::get_test_file\n             at ./src/tests.rs:68:16\n   5: parquet::serialized_reader::tests::new_filer_reader_with_cache\n             at ./src/serialized_reader.rs:450:25\n   6: parquet::serialized_reader::tests::test_file_reader_with_cache\n             at ./src/serialized_reader.rs:555:22\n   7: parquet::serialized_reader::tests::test_file_reader_with_cache::{{closure}}\n             at ./src/serialized_reader.rs:554:5\n   8: core::ops::function::FnOnce::call_once\n             at /rustc/f1ce0e6a00593493a12e0e3662119786c761f375/library/core/src/ops/function.rs:227:5\n   9: core::ops::function::FnOnce::call_once\n             at /rustc/f1ce0e6a00593493a12e0e3662119786c761f375/library/core/src/ops/function.rs:227:5\nnote: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.\n" }

waynexia avatar Jun 01 '22 03:06 waynexia

I have ignored some test cases in #12. We should restore them once CI is fixed.

waynexia avatar Jun 01 '22 03:06 waynexia