hop icon indicating copy to clipboard operation
hop copied to clipboard

Hop server enhancement #4569

Open nadment opened this issue 1 year ago • 8 comments

  • add command line options for (host, port, shutdownport, proxyhost, proxyport,ssl)
  • support for override properties on the command line
  • add shutdown listener to web server
  • add shutdown servlet
  • add RemoteHopServer class to interact with a Hop server and clean HopServerMeta
  • remove setup hop server syntax by hostname and port
  • add HopServerTerminate extension point after shutdown
  • all HopServerXXX extension points now provide a HopServer object, rather than a HopServer/WebServer mix
  • add command line options --help and --version
  • set abbreviateSynopsis and usageHelpAutoWidth to command line

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

nadment avatar Nov 15 '24 20:11 nadment

we need better option grouping, port appears as sub-option of password, host appears as sub-option of help etc:

  -h, --help              Displays this help message and quits.
      --host=<host>       The server host name or IP address to use.
  -p, --password=<password>
                          The server password. Required for administrative operations only, not for starting the server.
      --port=<port>       The server port to use.

bamaer avatar Nov 24 '24 09:11 bamaer

tested:

  • additional options for host, port, username, password,
  • -v and -h options
  • shutdown/kill only works when correct authentication is provided
  • --ssl options doesn't seem to work

bamaer avatar Nov 24 '24 09:11 bamaer

For option grouping, this is the behavior of Picoli if we do not define a unique letter for an option.

nadment avatar Nov 24 '24 10:11 nadment

is this still stuck in draft for an actual reason? @nadment

hansva avatar Jan 23 '25 16:01 hansva

No for me PR is ok. It's a lot of changes to test. I haven't found a better solution to group Picoli options

nadment avatar Jan 23 '25 16:01 nadment

Alright, then I'll start testing and reviewing this. There are some other minor changes (deprecations) that I will probably include in here.

hansva avatar Jan 23 '25 16:01 hansva

let's try and pick this one up after the release again :)

hansva avatar Oct 26 '25 16:10 hansva

I think it's printed this way because Picocli tries to align short format options and long format ones. In this case it's probably not finding a short hand option for --port.

mattcasters avatar Dec 15 '25 16:12 mattcasters