hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-29305: Migrate from the AWS SDK for Java v1 to v2

Open ryukobayashi opened this issue 4 months ago • 9 comments

What changes were proposed in this pull request?

Migrate from the AWS SDK for Java v1 to v2

Why are the changes needed?

AWS SDK for Java v1.x will reach EOL on December 31, 2025: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-java-v1-x-on-december-31-2025/

Does this PR introduce any user-facing change?

No

How was this patch tested?

I just ran the existing tests.

ryukobayashi avatar Nov 05 '25 07:11 ryukobayashi

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upgrades the Iceberg dependency used by the Presto Iceberg module from 1.8.1 to 1.10.0 and updates test code to use the new Parquet writer factory method required by the upgraded Iceberg version.

Sequence diagram for updated Parquet writer creation in Iceberg tests

sequenceDiagram
    actor Developer
    participant IcebergDistributedTestBase
    participant IcebergParquetWriterFactory
    participant IcebergParquetWriter

    Developer->>IcebergDistributedTestBase: runDistributedIcebergTest()
    IcebergDistributedTestBase->>IcebergParquetWriterFactory: createWriter(schema, outputFile, properties)
    IcebergParquetWriterFactory->>IcebergParquetWriter: newWriter(schema, outputFile, properties)
    IcebergParquetWriter-->>IcebergParquetWriterFactory: writerInstance
    IcebergParquetWriterFactory-->>IcebergDistributedTestBase: writerInstance
    IcebergDistributedTestBase->>IcebergParquetWriter: writeTestData(records)
    IcebergParquetWriter-->>IcebergDistributedTestBase: writeComplete

Class diagram for updated Iceberg Parquet writer factory usage in tests

classDiagram
    class IcebergDistributedTestBase {
        +runDistributedIcebergTest()
        +createTestTable(tableName)
        +writeParquetData(schema, outputFile, properties)
    }

    class IcebergParquetWriterFactory {
        +createWriter(schema, outputFile, properties) : IcebergParquetWriter
    }

    class IcebergParquetWriter {
        +newWriter(schema, outputFile, properties) : IcebergParquetWriter
        +write(records)
        +close()
    }

    IcebergDistributedTestBase --> IcebergParquetWriterFactory : uses
    IcebergParquetWriterFactory --> IcebergParquetWriter : creates

File-Level Changes

Change Details Files
Update Iceberg library version used by the Presto Iceberg module.
  • Change the dep.iceberg.version Maven property from 1.8.1 to 1.10.0 in the presto-iceberg module POM.
  • Keep other dependency versions and build properties unchanged.
presto-iceberg/pom.xml
Align Parquet delete writer creation with the new Iceberg 1.10 Parquet API.
  • Replace GenericParquetWriter::buildWriter with GenericParquetWriter::create when constructing position delete Parquet writers in IcebergDistributedTestBase.
  • Replace GenericParquetWriter::buildWriter with GenericParquetWriter::create when constructing equality delete Parquet writers in IcebergDistributedTestBase.
  • Preserve existing test logic for writing delete files, including schema handling and equality field IDs.
presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar Dec 09 '25 15:12 sourcery-ai[bot]