hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28549: Limit the maximum number of operators merged by SharedWorkOptimizer

Open okumin opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

This PR would limit the maximum number of table scan operators which SWO tries to merge.

https://issues.apache.org/jira/browse/HIVE-28549

Why are the changes needed?

We observed SWO makes a negative impact when it merges too many, e.g. 50, operators. If operators are memory intensive, they might throw OOM or might slow down.

I believe we can resolve OOM with the following patch, but we still want an upper limit so that we can tune concurrency or RAM per operator reasonably. https://github.com/apache/hive/pull/5478

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

No.

How was this patch tested?

I added a qtest

okumin avatar Oct 08 '24 09:10 okumin

Retriggered CI just in case

okumin avatar Nov 18 '24 11:11 okumin

I am checking why partition_explain_ddl always fails. In my impression, this PR is unrelated. P.S. I found it failed on the latest master branch

okumin avatar Nov 20 '24 07:11 okumin

CI passed after merging https://github.com/apache/hive/pull/5555

okumin avatar Nov 30 '24 04:11 okumin

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Jan 30 '25 00:01 github-actions[bot]

hi @okumin, should we rebase?

deniskuzZ avatar Mar 23 '25 14:03 deniskuzZ

@deniskuzZ Hi, I've rebased the branch on the master branch

okumin avatar Mar 24 '25 13:03 okumin

hi @okumin, not sure if you noticed the above comment, do you think it's legit?

deniskuzZ avatar Mar 26 '25 12:03 deniskuzZ

@deniskuzZ Yes, I do. I'm using my machine power to review and test another PR. I will likely update this one tomorrow.

okumin avatar Mar 26 '25 15:03 okumin

Thanks

okumin avatar Apr 01 '25 08:04 okumin