hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28538: Post JDK11-Fix locale-related discrepancies in test cases between local and Jenkins environments

Open shivjha30 opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Passing the locale in the pom.xml as <maven.test.jvm.args> to align both environments of local and jenkins

Why are the changes needed?

Post jdk11: In JDK11, changes were made to the Java locale handling as documented in the following issues:

(https://bugs.openjdk.org/browse/JDK-8145136) https://bugs.openjdk.org/browse/JDK-8211985

These changes result in different locale behaviors. This issue does not occur in Jenkins because the test cases are written according to the en_US locale. However, when run locally, the locale may differ (e.g., en_IN), causing discrepancies. For instance, en_IN would expect am/pm while the tests expect AM/PM, leading to failures.

The changes are needed to address test failures that occur locally but not in Jenkins. This discrepancy arises due to different locale settings between the two environments.

Various tests will start failing in local without alarming in the jenkins for example TestMiniLlapLocalCliDriver.udf_date_format.q as the locale in jenkins is en_US whereas varying from the user locale. ( for example en_IN ), the test will start failing

There may be other test failures not yet captured due to different locales in local environments. Ensure all tests run with the en_US locale to identify and resolve any further issues.

Does this PR introduce any user-facing change?

NO

shivjha30 avatar Sep 30 '24 05:09 shivjha30

@zabetak Thanks for the review, I have addressed the comment Could you review it ?

shivjha30 avatar Oct 07 '24 05:10 shivjha30