hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28532 Map Join Reuse cache allows to share hashtables for different join types

Open ramesh0201 opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

Map join container cache key should be unique for each map join hash table if they are of different join types. This will prevent hash table from getting shared between different join types.

Why are the changes needed?

Sharing same hash table between different join types will not work because they expect different hash table type based on the join type. Otherwise we might run into ClassCastException and also potential wrong results in certain cases.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

cd ql mvn test -Dtest=TestSharedWorkOptimizer#testMapJoinCacheReuse

ramesh0201 avatar Sep 23 '24 20:09 ramesh0201

@kasakrisz, do you know if there is anything left here? could this be merged?

deniskuzZ avatar Dec 17 '24 20:12 deniskuzZ