hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28237: Add a default tez-site.xml to data/conf

Open abstractdog opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

Added a tez-site.xml file to data/conf: copied from data/conf/tez and added a typical test scenario setting as below:

  <property>
    <name>tez.local.mode</name>
    <value>true</value>
  </property>

Why are the changes needed?

As described on jira, users of StartMiniHS2Cluster might find it confusing where to set tez configs, not even defined without this patch.

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

No.

How was this patch tested?

With StartMiniHS2Cluster, tez.local.mode=true was kicking in with the patch, this log line below was found in the log file of StartMiniHS2Cluster, so it created a LocalClient as expected

2024-04-30T02:55:14,168  INFO [DAGAppMaster Thread] client.LocalClient: Using working directory: /tmp/hive/scratch/laszlobodor/_tez_session_dir/7c9b847c-9d48-469a-a1e7-fa4d29b3148f/.tez/application_1714470913855_0001_wd

abstractdog avatar Apr 30 '24 10:04 abstractdog

Is it a copy or a move? As a copy won't be better to reference to the original path? Just for the sake of file duplication.

aturoczy avatar Apr 30 '24 11:04 aturoczy

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 30 '24 16:04 sonarqubecloud[bot]

Is it a copy or a move? As a copy won't be better to reference to the original path? Just for the sake of file duplication.

copy + added an extra opt, I can experiment with adding it to the original file and making a symlink in the mean I have to handle test failures

abstractdog avatar May 01 '24 06:05 abstractdog

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Jul 01 '24 00:07 github-actions[bot]

cannot reopnen, moving to https://github.com/apache/hive/pull/5348

abstractdog avatar Jul 15 '24 07:07 abstractdog