hive icon indicating copy to clipboard operation
hive copied to clipboard

[DRAFT] HIVE-27972: Set 'tez' as default value in hive.execution.engine

Open abstractdog opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

abstractdog avatar Jan 02 '24 10:01 abstractdog

Hi, there are some possibly related stuff that came into my mind:

Do we need to change some configuration files as well? My first guess is data/conf/hive-site.xml. It can overwrite the default values. And also, I'm thinking about the docker stuff as well. And StartMiniHS2Cluster overwrites it as well.

The other thing that I don't know for sure is what is the default engine for qtests?

InvisibleProgrammer avatar Jan 02 '24 14:01 InvisibleProgrammer

Hi, there are some possibly related stuff that came into my mind:

Do we need to change some configuration files as well? My first guess is data/conf/hive-site.xml. It can overwrite the default values. And also, I'm thinking about the docker stuff as well. And StartMiniHS2Cluster overwrites it as well.

The other thing that I don't know for sure is what is the default engine for qtests?

regarding config files: yes I guess, haven't checked though

regarding qtests: default engine for qtests depends on the actual driver, those have to be handled one-by-one: https://github.com/apache/hive/blob/master/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMiniClusters.java

abstractdog avatar Jan 02 '24 14:01 abstractdog

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 29 '24 16:01 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Mar 30 '24 00:03 github-actions[bot]

I have complied hive with this PR, built a docker image using docker compose with postgres and tested out a few queries, everything worked fine.

simhadri-g avatar Jun 21 '24 09:06 simhadri-g

I have complied hive with this PR, built a docker image using docker compose with postgres and tested out a few queries, everything worked fine.

thanks a lot!!

abstractdog avatar Jun 21 '24 14:06 abstractdog

thanks a lot, @SourabhBadhya for the review, good catches, I addressed all your comments in https://github.com/apache/hive/pull/4973/commits/ed236483066

abstractdog avatar Jun 22 '24 08:06 abstractdog

LGTM +1 (pending tests)

thanks @simhadri-g let me wait for @SourabhBadhya if he has any comments, objections

abstractdog avatar Jun 24 '24 14:06 abstractdog