hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-12371: Use DriverManager.getLoginTimeout() as fallback

Open jneira-stratio opened this issue 2 years ago • 2 comments

This way we would honour the previous behaviour if the new specific jdbc option is not set. Users may want to configure the timeout globally as before #1611

I've reused de jira ticket for the original request, please note if i should open a new one

Thanks!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

jneira-stratio avatar Dec 20 '23 13:12 jneira-stratio

Hi @jneira-stratio

Thanks for the PR. Yes, please open a new JIRA ticket and link the previous one. It is cleaner and helps the community when the release notes is generated.

aturoczy avatar Dec 20 '23 14:12 aturoczy

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 20 '23 19:12 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Feb 29 '24 00:02 github-actions[bot]

there are some 180+ test failures & all looks related

They surely might be. However i cant see how the change standalone could cause them as it is restoring a previous behaviour (prev to #1611) and DriverManager.loginTimeout default value is 0 afaics (the previous fixed default value). Sorry i dont have time to take a deeper look, feel free to close it (well it will be closed auto anyway i guess).

jneira-stratio avatar Feb 29 '24 07:02 jneira-stratio

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar May 01 '24 00:05 github-actions[bot]