hive
hive copied to clipboard
apache
HIVE-27775: DirectSQL and JDO results are different when fetching par…
…titions by timestamp in DST shift
What changes were proposed in this pull request?
Why are the changes needed?
On JDO path, we select the matched partitions by the partition name, which is timezone agnostic, however on DirectSQL, we do a cast partition value to timestamp, then select by the local time, for example:
cast("FILTER0"."PART_KEY_VAL" as TIMESTAMP) else null end) as TIMESTAMP) = <'2023-03-26 03:30:00'>
This could lead to different result as described in the Jira.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dtest.output.overwrite=true -Dqfile=partition_timestamp3.q -Dtest.metastore.db=postgres|derby|mssql|mysql|oracle
Can we pay attention to this issue pls? It is a blocker for Hive4 release.
cc: @dengzhhu653 @abstractdog @zabetak @ayushtkn @nrg4878
Quality Gate passed
The SonarCloud Quality Gate passed, but some issues were introduced.
14 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dengzhhu653, any chance of getting this PR ready for merge? looks like that is the only remaining blocker for 4.0 release
@dengzhhu653, any chance of getting this PR ready for merge? looks like that is the only remaining blocker for 4.0 release
I was engaged into other things these days, will back to it in next two days.
Quality Gate passed
Issues
15 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
See analysis details on SonarCloud