apache
HIVE-27944:When HIVE-LLAP reads the ICEBERG table, a deadlock may occur.
What changes were proposed in this pull request?
Modified the modifier of the cache property in the SplitGroup class to make it non-static.
JIRA: https://issues.apache.org/jira/browse/HIVE-27944
Why are the changes needed?
Since the Properties object implement HashTable interface, all the methods of the HashTable interface are synchronised. In a multi-threaded environment, a deadlock will occur when propA.equals(propB) and propB.equals(propA) occur at the same time. The problem can be solved with minimal modification by changing SplitGroup.cache to a non-static property.
Does this PR introduce any user-facing change?
no
Is the change a dependency upgrade?
no
How was this patch tested?
no need. Because this patch doesn't change the execution logic of any code
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
1
---Original--- From: @.> Date: Fri, Mar 15, 2024 08:19 AM To: @.>; Cc: "PLASH @.@.>; Subject: Re: [apache/hive] HIVE-27944:When HIVE-LLAP reads the ICEBERG table,a deadlock may occur. (PR #4935)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the @.*** list if the patch is in need of reviews.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
1
I can't just approve this without the test. I wanted to repro the issue locally and then create a q test, but I didn't have time. Do you have some repro steps that could be tried locally (data setup + selects)?
Sir.I'm having a hard time triggering this bug directly via SQL because as of now, I'm not sure how to consistently reproduce the problem. in our production env, after we added the patch.The problem disappeared, so I never looked at how to reproduce the bug. Can we test this class in code without using SQL?