hive HIVE-26543: Improve TxnHandler, TxnUtils, CompactionTxnHandler logging

HIVE-26543: Improve TxnHandler, TxnUtils, CompactionTxnHandler logging

Open abstractdog opened this issue 2 years ago • 3 comments

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Sep 18 '22 14:09 abstractdog

There are similar improvements that can be done in https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java and https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java . Can we include that in this PR as well. The rest of the files in the txn folder seem to be good.

yeah, that's right, I'm doing the same there too, thanks @achennagiri

Sep 19 '22 09:09 abstractdog

thanks @achennagiri and @zabetak, I addressed your comments in https://github.com/apache/hive/pull/3603/commits/4634139b69b2ee652cc368659242741bef1c6603

Sep 21 '22 15:09 abstractdog

Kudos, SonarCloud Quality Gate passed!