hive
hive copied to clipboard
HIVE-26537: Deprecate older APIs in the HMS thrift interface.
What changes were proposed in this pull request?
Deprecated older APIs in HMS and pointed them to the newer APIs
Why are the changes needed?
Going forward HMS should be using the deprecated APIs.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.
Leave a minor comment, you can fix them as you want.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
Is this ticket still active? Do we want to put this into Hive4? @nrg4878 @saihemanth-cloudera @ayushtkn @deniskuzZ Pretty big change.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
Re-opening the PR
@nrg4878, @saihemanth-cloudera should this be part of 4.0 release?
Quality Gate passed
The SonarCloud Quality Gate passed, but some issues were introduced.
92 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication
As I see there is a Javadoc generation issue and a timeout issue. Cloud you pls check again?
The failed test TestDbNotificationListener.createDatabase
seems to be related to the change, cloud you please check that?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
Hello @saihemanth-cloudera, any chance to continue on the fix? we need to remove these deprecated APIs as early as possible.
The changes in hive_metastore.thrift
looks good to me. Besides this, I leave some comments on the HMSHander
, and the test failure seems related, could you please address that? Thank you for the effort to make the code clean!
Quality Gate passed
Issues
103 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
+1, cc @nrg4878 @deniskuzZ @ayushtkn it would be great if another eye will take here before it gets merged. Thank you in advance!