hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-26537: Deprecate older APIs in the HMS thrift interface.

Open saihemanth-cloudera opened this issue 2 years ago • 18 comments

What changes were proposed in this pull request?

Deprecated older APIs in HMS and pointed them to the newer APIs

Why are the changes needed?

Going forward HMS should be using the deprecated APIs.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit tests.

saihemanth-cloudera avatar Sep 15 '22 23:09 saihemanth-cloudera

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 96 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 22 '22 06:09 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 92 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 01 '22 23:12 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 92 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jan 26 '23 20:01 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 92 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Apr 05 '23 22:04 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 100 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 30 '23 22:05 sonarqubecloud[bot]

Leave a minor comment, you can fix them as you want.

dengzhhu653 avatar Jun 20 '23 09:06 dengzhhu653

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Aug 20 '23 00:08 github-actions[bot]

Is this ticket still active? Do we want to put this into Hive4? @nrg4878 @saihemanth-cloudera @ayushtkn @deniskuzZ Pretty big change.

aturoczy avatar Aug 22 '23 08:08 aturoczy

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Oct 22 '23 00:10 github-actions[bot]

Re-opening the PR

nrg4878 avatar Oct 30 '23 14:10 nrg4878

@nrg4878, @saihemanth-cloudera should this be part of 4.0 release?

deniskuzZ avatar Dec 16 '23 12:12 deniskuzZ

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

92 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 20 '23 22:12 sonarqubecloud[bot]

As I see there is a Javadoc generation issue and a timeout issue. Cloud you pls check again?

aturoczy avatar Dec 26 '23 17:12 aturoczy

The failed test TestDbNotificationListener.createDatabaseseems to be related to the change, cloud you please check that?

dengzhhu653 avatar Jan 02 '24 09:01 dengzhhu653

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Mar 03 '24 00:03 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Jun 08 '24 00:06 github-actions[bot]

Hello @saihemanth-cloudera, any chance to continue on the fix? we need to remove these deprecated APIs as early as possible.

dengzhhu653 avatar Jun 14 '24 06:06 dengzhhu653

The changes in hive_metastore.thrift looks good to me. Besides this, I leave some comments on the HMSHander, and the test failure seems related, could you please address that? Thank you for the effort to make the code clean!

dengzhhu653 avatar Jul 10 '24 13:07 dengzhhu653

+1, cc @nrg4878 @deniskuzZ @ayushtkn it would be great if another eye will take here before it gets merged. Thank you in advance!

dengzhhu653 avatar Jul 15 '24 02:07 dengzhhu653