hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-26332: Upgrade maven-surefire-plugin to 3.0.0-M7

Open zabetak opened this issue 3 years ago • 5 comments

Why are the changes needed?

  1. Better interaction with JUnit 5 dependencies
  2. Multiple bug fixes, and improvements since M4

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

zabetak avatar Jun 15 '22 13:06 zabetak

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Aug 17 '22 00:08 github-actions[bot]

Please bot keep this open!

zabetak avatar Aug 18 '22 08:08 zabetak

I too need this, Was going to create a Jira and bumped into this. Actually when integrating Ozone with Hive, I observed without moving up the surefire plugin version to 3.0.0-M5, for some strange reasons the test weren't running. I didn't figure out the reason for that, but moving to 3.0.0-M5 sorted things for me. @zabetak Do you have any pointers like if there are any challenges moving up here?

ayushtkn avatar Aug 18 '22 10:08 ayushtkn

@ayushtkn The upgrade brought up in the surface various problems as you can see in the failed tests. I tackled some of them in separate JIRAs but there are more that require investigation and fixing.

Some of them have to do with tests not running before or silently failing and others seem to be due to logging or surefire output changes.

I can try to rebase and relaunch to see the current status.

zabetak avatar Aug 18 '22 10:08 zabetak

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 14 '22 15:09 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Nov 14 '22 00:11 github-actions[bot]