hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-26046: MySQL's bit datatype is default to void datatype in hive

Open zhangbutao opened this issue 2 years ago • 5 comments

What changes were proposed in this pull request?

MySQl'bit type should be mapped to a suitable datatype in hive.

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=dataconnector_mysql_bit_datatype.q

zhangbutao avatar May 10 '22 07:05 zhangbutao

This seems like a weird failed test. I can ran it successfully in my local env with command: mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=dataconnector_mysql_bit_datatype.q

But in the pr integration test it failed with error: fname=dataconnector_mysql_bit_datatype.q See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ for specific test cases logs. org.apache.hadoop.hive.ql.parse.SemanticException: Unable to fetch table work_calendar. Error retrieving remote table:java.sql.SQLNonTransientConnectionException: (conn=4) Connection is closed at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.getTable(BaseSemanticAnalyzer.java:1866) at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.getTable(BaseSemanticAnalyzer.java:1851) at org.apache.hadoop.hive.ql.ddl.table.create.show.ShowCreateTableAnalyzer.analyzeInternal(ShowCreateTableAnalyzer.java:53)

I think the integration test env may has something wrong. It may be a database driver compatibility problem or something others.
Do you have any suggestions ? @nrg4878 @zabetak @kgyrtkirk

zhangbutao avatar May 12 '22 06:05 zhangbutao

@zhangbutao Instead of running the test individually try to run the whole split (mvn -Pitests -Pqsplits test -Dtest=org.apache.hadoop.hive.cli.split6.TestMiniLlapLocalCliDriver) locally. I suspect there is some kind of interference with other tests (possibly dataconnector_mysql.q).

From the error message I suppose we are trying to use an "old" connection that is no longer open. Possibly we are closing a connection that I shouldn't or something along these lines.

zabetak avatar May 12 '22 14:05 zabetak

@zabetak thx. I'll run a full test and try to fix this test.

zhangbutao avatar May 13 '22 03:05 zhangbutao

@nrg4878 Could you please take a look? :)

zhangbutao avatar May 16 '22 08:05 zhangbutao

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Aug 11 '22 00:08 github-actions[bot]