hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-26065: fix incorrect metric active_calls_alter_partitions and active_calls_alter_partition

Open DongWei-4 opened this issue 2 years ago • 2 comments

In our production environment, we found that the value of the metric "active_calls_alter_partition" was negative. This is very confusing.

After checking the HMSHandler.class, we found that the method alter_partitions_with_environment_context called()

startTableFunction("alter_partitions", catName, db_name, tbl_name); ... endFunction("alter_partition", oldParts != null, ex, tbl_name);

So the metric "active_calls_alter_partition" will be decremented by one after the "alter_partitions" function execution ends, causing the value become a negative number

DongWei-4 avatar Mar 23 '22 18:03 DongWei-4

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar May 24 '22 00:05 github-actions[bot]

@maheshk114 Can you please help review this patch? Thanks

DongWei-4 avatar May 24 '22 01:05 DongWei-4

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Oct 18 '22 00:10 github-actions[bot]

@Tuan8888 Can you please rebase the patch.

maheshk114 avatar Oct 28 '22 03:10 maheshk114

@maheshk114 thanks. Already Finished

DongWei-4 avatar Oct 28 '22 06:10 DongWei-4

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 28 '22 12:10 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Dec 29 '22 00:12 github-actions[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 29 '22 12:12 sonarqubecloud[bot]