hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-29733 Use ServerName instead of hostname in unloadRegions log message

Open jcongithub opened this issue 1 month ago • 8 comments

UnloadRegions log message uses the hostname to show where regions are unloading from. When a host runs multiple region servers, the hostname in the log message alone is insufficient to identify which specific region server is unloading regions.

This PR has the change to use ServerName in the log, making it easier to distinguish between region servers on the same host similar to loadRegions log message.

This PR also fixes a log statement

jcongithub avatar Nov 27 '25 21:11 jcongithub

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 54s master passed
+1 :green_heart: compile 4m 36s master passed
+1 :green_heart: checkstyle 1m 22s master passed
+1 :green_heart: spotbugs 2m 13s master passed
+1 :green_heart: spotless 1m 8s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 9s the patch passed
+1 :green_heart: compile 4m 12s the patch passed
+1 :green_heart: javac 4m 12s the patch passed
+1 :green_heart: blanks 0m 1s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 22s the patch passed
+1 :green_heart: spotbugs 2m 24s the patch passed
+1 :green_heart: hadoopcheck 14m 25s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 :green_heart: spotless 1m 5s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
53m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7487
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux b13e3d1c7061 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 87641196c58ad4f52f9134224d7a7c5e6e85c1da
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Nov 27 '25 22:11 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 30s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 41s master passed
+1 :green_heart: compile 1m 2s master passed
+1 :green_heart: javadoc 0m 30s master passed
+1 :green_heart: shadedjars 6m 16s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 18s the patch passed
+1 :green_heart: compile 1m 11s the patch passed
+1 :green_heart: javac 1m 11s the patch passed
+1 :green_heart: javadoc 0m 48s the patch passed
+1 :green_heart: shadedjars 7m 19s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 221m 34s /patch-unit-hbase-server.txt hbase-server in the patch failed.
254m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7487
Optional Tests javac javadoc unit compile shadedjars
uname Linux dfe45f04da6d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 87641196c58ad4f52f9134224d7a7c5e6e85c1da
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/1/testReport/
Max. process+thread count 4474 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Nov 28 '25 01:11 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 31s master passed
+1 :green_heart: compile 3m 28s master passed
+1 :green_heart: checkstyle 1m 3s master passed
+1 :green_heart: spotbugs 1m 37s master passed
+1 :green_heart: spotless 0m 54s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 2s the patch passed
+1 :green_heart: compile 3m 19s the patch passed
+1 :green_heart: javac 3m 19s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 1s the patch passed
+1 :green_heart: spotbugs 1m 43s the patch passed
+1 :green_heart: hadoopcheck 13m 15s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 :green_heart: spotless 0m 48s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
43m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7487
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 7bcb97c4f14b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b922d0921d3d1871596538e90f576e89840f8175
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 145 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 06 '25 05:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 52s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 31s master passed
+1 :green_heart: compile 1m 25s master passed
+1 :green_heart: javadoc 0m 44s master passed
+1 :green_heart: shadedjars 7m 9s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 51s the patch passed
+1 :green_heart: compile 1m 19s the patch passed
+1 :green_heart: javac 1m 19s the patch passed
+1 :green_heart: javadoc 0m 33s the patch passed
+1 :green_heart: shadedjars 6m 55s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 254m 50s hbase-server in the patch passed.
286m 56s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7487
Optional Tests javac javadoc unit compile shadedjars
uname Linux cb3456987acc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b922d0921d3d1871596538e90f576e89840f8175
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/2/testReport/
Max. process+thread count 3463 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 06 '25 09:12 Apache-HBase

Hi @jcongithub,

Thanks for your contribution. Can you please add the Jira ticket ID to the commit message - e.g. use the commit message format documented here: https://hbase.apache.org/book.html#hbase.commit.msg.format

Please also update the PR title to start with the Jira ticket ID.

PDavid avatar Dec 10 '25 12:12 PDavid

Thanks @PDavid Updated

jcongithub avatar Dec 11 '25 21:12 jcongithub

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 0s Docker mode activated.
-1 :x: docker 0m 5s Docker failed to build run-specific yetus/hbase:tp-151}.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hbase/pull/7487
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/3/console
versions git=2.17.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 11 '25 22:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 1s master passed
+1 :green_heart: compile 3m 22s master passed
+1 :green_heart: checkstyle 1m 1s master passed
+1 :green_heart: spotbugs 1m 41s master passed
+1 :green_heart: spotless 0m 49s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 57s the patch passed
+1 :green_heart: compile 3m 19s the patch passed
+1 :green_heart: javac 3m 19s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 0s the patch passed
+1 :green_heart: spotbugs 1m 40s the patch passed
+1 :green_heart: hadoopcheck 11m 25s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 :green_heart: spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 11s The patch does not generate ASF License warnings.
40m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7487
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 61b7dade46ee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3b4b0cb8d95efd5672758e74d8ac1f3270e92979
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 11 '25 22:12 Apache-HBase