hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-29433: Resolve exception in AsyncTable for coprocessor services when a region merges/splits

Open krconv opened this issue 6 months ago • 20 comments

This updates how the client reacts to region merges/splits while processing coprocessorService(). Instead of failing the region, it resubmits the affected range of row keys to try to save the call from needing to be aborted.

Added unit tests that test this scenario. I also compared this behavior to the HTable from previous versions; HTable doesn't seem to have this same assertion, nor proper handling for split regions, meaning it will potentially return incorrect results.

The coprocessor service logic in the client goes like this when we need to submit RPCs to multiple regions:

  1. Start a chain of AsyncTableRegionLocator requests, starting with the start key and continuing to locate the next region until we've located the region containing the end key
  2. Via a listener on the locator request for each region, we send the coprocessor RPC to the region that was located as soon as the location is resolved (likely from the meta cache)
  3. The RPC channel is started to the region, at which point we may find out that the region name has changed (and abort the request for that region)
  4. For each region, we continue to send coprocessor RPCs until PartialResultCoprocessorCallback::getNextCallable returns null
  5. Once the last RPC has returned from the last region that the call had identified, we call CoprocessorCallback::onComplete to indicate the call as done.

This PR inserts logic at step 3, starting a new call to the affected range covered by the (outdated) region returned by step 2.

Marking this as draft because I'll need some time to fix formatting/linting issues, but I'd like to get tests running.

krconv avatar Jun 28 '25 22:06 krconv

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 3m 6s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 15s master passed
+1 :green_heart: compile 1m 19s master passed
-0 :warning: checkstyle 0m 13s /buildtool-branch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
+1 :green_heart: spotbugs 1m 8s master passed
+1 :green_heart: spotless 0m 51s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
-1 :x: mvninstall 0m 48s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 18s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-1 :x: compile 0m 19s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 18s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-0 :warning: javac 0m 19s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 10s /buildtool-patch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
-0 :warning: checkstyle 0m 6s /results-checkstyle-hbase-endpoint.txt hbase-endpoint: The patch generated 30 new + 0 unchanged - 0 fixed = 30 total (was 0)
-1 :x: spotbugs 0m 12s /patch-spotbugs-hbase-client.txt hbase-client in the patch failed.
-1 :x: spotbugs 0m 13s /patch-spotbugs-hbase-endpoint.txt hbase-endpoint in the patch failed.
-1 :x: hadoopcheck 0m 56s The patch causes 18 errors with Hadoop v3.3.6.
-1 :x: hadoopcheck 1m 52s The patch causes 18 errors with Hadoop v3.4.0.
-1 :x: spotless 0m 16s patch has 11 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
16m 33s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 80afae0ce33d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 23089e3f12e5b2b9693fad7b03d7e60a909f1644
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 28 '25 22:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 3m 0s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 14s master passed
+1 :green_heart: compile 0m 43s master passed
+1 :green_heart: javadoc 0m 29s master passed
+1 :green_heart: shadedjars 6m 11s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
-1 :x: mvninstall 0m 49s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 14s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-1 :x: compile 0m 17s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 14s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-0 :warning: javac 0m 17s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javadoc 0m 10s /patch-javadoc-hbase-client.txt hbase-client in the patch failed.
-1 :x: shadedjars 2m 27s patch has 18 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 0m 14s /patch-unit-hbase-client.txt hbase-client in the patch failed.
-1 :x: unit 0m 17s /patch-unit-hbase-endpoint.txt hbase-endpoint in the patch failed.
19m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
Optional Tests javac javadoc unit compile shadedjars
uname Linux c1504bad61b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 23089e3f12e5b2b9693fad7b03d7e60a909f1644
Default Java Eclipse Adoptium-17.0.11+9
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/testReport/
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 28 '25 22:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 2s master passed
+1 :green_heart: compile 1m 31s master passed
-0 :warning: checkstyle 0m 17s /buildtool-branch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
+1 :green_heart: spotbugs 1m 24s master passed
+1 :green_heart: spotless 1m 0s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
-1 :x: mvninstall 1m 1s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 25s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-1 :x: compile 0m 26s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 25s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-0 :warning: javac 0m 26s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 12s /buildtool-patch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
-1 :x: spotbugs 0m 22s /patch-spotbugs-hbase-client.txt hbase-client in the patch failed.
-1 :x: spotbugs 0m 19s /patch-spotbugs-hbase-endpoint.txt hbase-endpoint in the patch failed.
-1 :x: hadoopcheck 1m 16s The patch causes 38 errors with Hadoop v3.3.6.
-1 :x: hadoopcheck 2m 30s The patch causes 113 errors with Hadoop v3.4.0.
-1 :x: spotless 0m 22s patch has 50 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 17s The patch does not generate ASF License warnings.
17m 17s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux f27aa1274cba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b81bbe1ff08553a9fd4ec3a46e3f3625cdd8938a
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 29 '25 23:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 38s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 3s master passed
+1 :green_heart: compile 0m 53s master passed
+1 :green_heart: javadoc 0m 33s master passed
+1 :green_heart: shadedjars 7m 20s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for patch
-1 :x: mvninstall 1m 7s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 23s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-1 :x: compile 0m 20s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 23s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-0 :warning: javac 0m 20s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javadoc 0m 22s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 26 new + 28 unchanged - 0 fixed = 54 total (was 28)
-1 :x: shadedjars 3m 0s patch has 113 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 0m 24s /patch-unit-hbase-client.txt hbase-client in the patch failed.
-1 :x: unit 0m 19s /patch-unit-hbase-endpoint.txt hbase-endpoint in the patch failed.
21m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
Optional Tests javac javadoc unit compile shadedjars
uname Linux 4706d39316b1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b81bbe1ff08553a9fd4ec3a46e3f3625cdd8938a
Default Java Eclipse Adoptium-17.0.11+9
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/testReport/
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 29 '25 23:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 53s master passed
+1 :green_heart: compile 1m 33s master passed
-0 :warning: checkstyle 0m 16s /buildtool-branch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
+1 :green_heart: spotbugs 1m 19s master passed
+1 :green_heart: spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
-1 :x: mvninstall 3m 46s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 26s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 26s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 14s /buildtool-patch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
-1 :x: spotbugs 0m 18s /patch-spotbugs-hbase-endpoint.txt hbase-endpoint in the patch failed.
-1 :x: hadoopcheck 3m 3s The patch causes 108 errors with Hadoop v3.3.6.
-1 :x: hadoopcheck 6m 7s The patch causes 108 errors with Hadoop v3.4.0.
+1 :green_heart: spotless 0m 54s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 19s The patch does not generate ASF License warnings.
25m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux bffd21874bae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b34c5eb94f686b75328779d3c0327eab8a7ab36b
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/3/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/3/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 30 '25 02:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 30s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 42s master passed
+1 :green_heart: compile 0m 45s master passed
+1 :green_heart: javadoc 0m 29s master passed
+1 :green_heart: shadedjars 6m 50s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
-1 :x: mvninstall 3m 43s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 20s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 20s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: javadoc 0m 32s the patch passed
+1 :green_heart: shadedjars 7m 21s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 8s hbase-client in the patch passed.
-1 :x: unit 0m 20s /patch-unit-hbase-endpoint.txt hbase-endpoint in the patch failed.
29m 4s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
Optional Tests javac javadoc unit compile shadedjars
uname Linux 7c6431cdf6ff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b34c5eb94f686b75328779d3c0327eab8a7ab36b
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/3/testReport/
Max. process+thread count 319 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 30 '25 02:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 51s master passed
+1 :green_heart: compile 1m 28s master passed
-0 :warning: checkstyle 0m 16s /buildtool-branch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
+1 :green_heart: spotbugs 1m 24s master passed
+1 :green_heart: spotless 0m 58s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
-1 :x: mvninstall 3m 34s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 22s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 22s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 14s /buildtool-patch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
-1 :x: spotbugs 0m 19s /patch-spotbugs-hbase-endpoint.txt hbase-endpoint in the patch failed.
-1 :x: hadoopcheck 2m 54s The patch causes 46 errors with Hadoop v3.3.6.
-1 :x: hadoopcheck 5m 50s The patch causes 46 errors with Hadoop v3.4.0.
+1 :green_heart: spotless 0m 49s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 17s The patch does not generate ASF License warnings.
24m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 6ca323583322 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2f1836d1855cfc4bf93940694394c34e8125cc70
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/4/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/4/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 30 '25 02:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 34s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 57s master passed
+1 :green_heart: compile 0m 46s master passed
+1 :green_heart: javadoc 0m 34s master passed
+1 :green_heart: shadedjars 7m 13s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for patch
-1 :x: mvninstall 3m 44s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 20s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 20s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: javadoc 0m 32s the patch passed
+1 :green_heart: shadedjars 7m 4s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 7s hbase-client in the patch passed.
-1 :x: unit 0m 22s /patch-unit-hbase-endpoint.txt hbase-endpoint in the patch failed.
29m 41s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests javac javadoc unit compile shadedjars
uname Linux 8ed7f1a8a107 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2f1836d1855cfc4bf93940694394c34e8125cc70
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/4/testReport/
Max. process+thread count 325 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 30 '25 02:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 50s master passed
+1 :green_heart: compile 1m 29s master passed
-0 :warning: checkstyle 0m 16s /buildtool-branch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
+1 :green_heart: spotbugs 1m 25s master passed
+1 :green_heart: spotless 0m 58s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
-1 :x: mvninstall 4m 22s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 26s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 26s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 16s /buildtool-patch-checkstyle-hbase-client.txt The patch fails to run checkstyle in hbase-client
-1 :x: spotbugs 0m 20s /patch-spotbugs-hbase-endpoint.txt hbase-endpoint in the patch failed.
-1 :x: hadoopcheck 3m 27s The patch causes 46 errors with Hadoop v3.3.6.
-1 :x: hadoopcheck 6m 46s The patch causes 46 errors with Hadoop v3.4.0.
+1 :green_heart: spotless 0m 55s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
26m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux f86ee47fd75f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2f1836d1855cfc4bf93940694394c34e8125cc70
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/5/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/5/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 30 '25 03:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 37s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 40s master passed
+1 :green_heart: compile 0m 42s master passed
+1 :green_heart: javadoc 0m 30s master passed
+1 :green_heart: shadedjars 6m 52s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
-1 :x: mvninstall 3m 20s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 19s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 19s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: javadoc 0m 30s the patch passed
+1 :green_heart: shadedjars 6m 49s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 3s hbase-client in the patch passed.
-1 :x: unit 0m 19s /patch-unit-hbase-endpoint.txt hbase-endpoint in the patch failed.
27m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests javac javadoc unit compile shadedjars
uname Linux 2811f2cd6505 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2f1836d1855cfc4bf93940694394c34e8125cc70
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/5/testReport/
Max. process+thread count 328 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 30 '25 03:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 21s master passed
+1 :green_heart: compile 0m 39s master passed
+1 :green_heart: javadoc 0m 29s master passed
+1 :green_heart: shadedjars 6m 10s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 8s the patch passed
+1 :green_heart: compile 0m 38s the patch passed
+1 :green_heart: javac 0m 38s the patch passed
+1 :green_heart: javadoc 0m 26s the patch passed
+1 :green_heart: shadedjars 6m 3s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 37s hbase-client in the patch passed.
+1 :green_heart: unit 3m 45s hbase-endpoint in the patch passed.
28m 29s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests javac javadoc unit compile shadedjars
uname Linux 60c1e7c79ae9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8c10514f51d840fb70fff498cad62bf295182ee6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/6/testReport/
Max. process+thread count 1382 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 10 '25 21:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 47s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 47s master passed
+1 :green_heart: compile 2m 3s master passed
+1 :green_heart: checkstyle 0m 41s master passed
+1 :green_heart: spotbugs 1m 46s master passed
+1 :green_heart: spotless 1m 14s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 48s the patch passed
+1 :green_heart: compile 1m 59s the patch passed
-0 :warning: javac 0m 40s /results-compile-javac-hbase-endpoint.txt hbase-endpoint generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 25s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: spotbugs 2m 6s the patch passed
+1 :green_heart: hadoopcheck 17m 16s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x: spotless 0m 34s patch has 34 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 32s The patch does not generate ASF License warnings.
50m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 0d5d50206832 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8c10514f51d840fb70fff498cad62bf295182ee6
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/6/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/6/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 10 '25 21:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 12s master passed
+1 :green_heart: compile 0m 38s master passed
+1 :green_heart: javadoc 0m 26s master passed
+1 :green_heart: shadedjars 5m 59s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 2s the patch passed
+1 :green_heart: compile 0m 38s the patch passed
+1 :green_heart: javac 0m 38s the patch passed
+1 :green_heart: javadoc 0m 26s the patch passed
+1 :green_heart: shadedjars 6m 1s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 36s hbase-client in the patch passed.
+1 :green_heart: unit 3m 44s hbase-endpoint in the patch passed.
27m 56s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests javac javadoc unit compile shadedjars
uname Linux c62067165a9a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 875f49f9a2007cb65c6fc48f2aa5bb5bd4fe3ebc
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/7/testReport/
Max. process+thread count 1399 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/7/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 11 '25 16:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 31s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 28s master passed
+1 :green_heart: compile 1m 15s master passed
+1 :green_heart: checkstyle 0m 25s master passed
+1 :green_heart: spotbugs 1m 8s master passed
+1 :green_heart: spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 3s the patch passed
+1 :green_heart: compile 1m 12s the patch passed
-0 :warning: javac 0m 24s /results-compile-javac-hbase-endpoint.txt hbase-endpoint generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 15s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: spotbugs 1m 17s the patch passed
+1 :green_heart: hadoopcheck 12m 12s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 17s The patch does not generate ASF License warnings.
35m 12s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux fa16c3190ffb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 875f49f9a2007cb65c6fc48f2aa5bb5bd4fe3ebc
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/7/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 11 '25 16:07 Apache-HBase

Unfortunately this mechanism is intricate, hard to get right and easy to break. I think it might be worth considering a smaller change that would avoid the original problem but potentially return incorrect results (like the HTable client would)

krconv avatar Jul 11 '25 17:07 krconv

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 31s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 37s master passed
+1 :green_heart: compile 0m 39s master passed
+1 :green_heart: javadoc 0m 27s master passed
+1 :green_heart: shadedjars 6m 5s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 10s the patch passed
+1 :green_heart: compile 0m 38s the patch passed
+1 :green_heart: javac 0m 38s the patch passed
+1 :green_heart: javadoc 0m 27s the patch passed
+1 :green_heart: shadedjars 6m 6s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 38s hbase-client in the patch passed.
+1 :green_heart: unit 3m 53s hbase-endpoint in the patch passed.
29m 2s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests javac javadoc unit compile shadedjars
uname Linux 7119f47e3927 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / fe34658681cf6998792ffaba10c59706de9bad5a
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/8/testReport/
Max. process+thread count 1400 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/8/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 11 '25 19:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 6s master passed
+1 :green_heart: compile 1m 12s master passed
+1 :green_heart: checkstyle 0m 24s master passed
+1 :green_heart: spotbugs 1m 3s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 6s the patch passed
+1 :green_heart: compile 1m 11s the patch passed
-0 :warning: javac 0m 24s /results-compile-javac-hbase-endpoint.txt hbase-endpoint generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 15s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: spotbugs 1m 17s the patch passed
+1 :green_heart: hadoopcheck 11m 59s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
34m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7131
JIRA Issue HBASE-29433
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux fc6d3b1bc066 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / fe34658681cf6998792ffaba10c59706de9bad5a
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7131/8/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 11 '25 19:07 Apache-HBase

I think there are scenarios where we do not know how to retry? For example, we have finished a request to region, and when sending request to the next region, these two regions are merged. Then what is the correct way to do retrying here? Sending request again to the merged region? Or just jump to the next region?

Apache9 avatar Jul 22 '25 11:07 Apache9

Any updates here?

Apache9 avatar Jul 27 '25 14:07 Apache9

I think there are scenarios where we do not know how to retry? For example, we have finished a request to region, and when sending request to the next region, these two regions are merged. Then what is the correct way to do retrying here? Sending request again to the merged region? Or just jump to the next region?

Sorry for the delay. In that case, this new logic would fail the request because ya, there is no way to return a response that doesn't double-count rows; in the code I am calling this an "overlappingAssignments"

  1. Run on Parent Region A, succeeds
  2. Region A and B merge to C
  3. Run on Region B (which is what was in our client's meta cache), fails due to RegionNoLongerExistsException (because when we requested the row that we thought represented Region B, we actually started an RPC with Region C which we previously didn't know about)
  4. Relocate the rows that Region B covered, find out that Region C now covers that range
  5. Attempt to "claim assignment" of the new range for Region C, find out that it overlaps with a region already processed, fail

This is a less-likely race condition in this already unlikely scenario. The more common case I'd expect is for A and B to be merged sometime before the coprocessor service is called. In that scenario:

  1. Start with a warmed meta cache
  2. Region A and B merge to C
  3. Run on Region A, fails due to RegionNoLongerExistsException
  4. Relocate the regions that Region A covered, find out that Region C now exists
  5. Attempt to "claim assignment", succeeds because it is a range not already processed

In this situation we can recover the request and maintain correctness; without this PR, AsyncTable fails in this scenario and HTable returns incorrect results (it would run the coprocessor service twice on Region C, and in cases that we are counting rows and returning the results, would dual-count those rows)

krconv avatar Aug 01 '25 11:08 krconv