hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-28951 use unique name of temp recovered edits for each worker

Open Umeshkumar9414 opened this issue 7 months ago • 8 comments

Solution Document - https://docs.google.com/document/d/1CX9ysa5thq0vajXR2zapcMkfwTwV9VsW6xGXuxdN97M/edit?tab=t.0#heading=h.74kik1edg70t

Umeshkumar9414 avatar Jun 06 '25 05:06 Umeshkumar9414

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 45s master passed
+1 :green_heart: compile 3m 35s master passed
+1 :green_heart: checkstyle 0m 38s master passed
+1 :green_heart: spotbugs 1m 52s master passed
+1 :green_heart: spotless 0m 55s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 28s the patch passed
+1 :green_heart: compile 3m 30s the patch passed
+1 :green_heart: javac 3m 30s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 40s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 :green_heart: spotbugs 1m 57s the patch passed
+1 :green_heart: hadoopcheck 12m 10s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 50s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 12s The patch does not generate ASF License warnings.
41m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 55e8c8e4382b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bff1c5370e27a94d61aca63090174ae30e66300d
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 06 '25 05:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 22s master passed
+1 :green_heart: compile 0m 56s master passed
+1 :green_heart: javadoc 0m 27s master passed
+1 :green_heart: shadedjars 6m 4s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 0m 55s the patch passed
+1 :green_heart: javac 0m 55s the patch passed
+1 :green_heart: javadoc 0m 26s the patch passed
+1 :green_heart: shadedjars 5m 54s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 210m 30s hbase-server in the patch passed.
236m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux 8905ac4bf7e7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bff1c5370e27a94d61aca63090174ae30e66300d
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/1/testReport/
Max. process+thread count 5529 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 06 '25 09:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 51s master passed
+1 :green_heart: compile 3m 17s master passed
+1 :green_heart: checkstyle 0m 38s master passed
+1 :green_heart: spotbugs 1m 38s master passed
+1 :green_heart: spotless 0m 51s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 4s the patch passed
+1 :green_heart: compile 3m 58s the patch passed
+1 :green_heart: javac 3m 58s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 50s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 3 new + 3 unchanged - 0 fixed = 6 total (was 3)
+1 :green_heart: spotbugs 2m 8s the patch passed
+1 :green_heart: hadoopcheck 13m 41s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x: spotless 0m 42s patch has 34 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 12s The patch does not generate ASF License warnings.
43m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 0ebb8d1964b8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3a658b67304df5b3bb844cddc9483613c745bd2a
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 17 '25 01:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 37s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 28s master passed
+1 :green_heart: compile 1m 3s master passed
+1 :green_heart: javadoc 0m 30s master passed
+1 :green_heart: shadedjars 6m 30s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 24s the patch passed
+1 :green_heart: compile 1m 0s the patch passed
+1 :green_heart: javac 1m 0s the patch passed
+1 :green_heart: javadoc 0m 28s the patch passed
+1 :green_heart: shadedjars 6m 16s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 471m 22s /patch-unit-hbase-server.txt hbase-server in the patch failed.
499m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux aab059db8aa4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3a658b67304df5b3bb844cddc9483613c745bd2a
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/2/testReport/
Max. process+thread count 5642 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 17 '25 08:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 33s master passed
+1 :green_heart: compile 3m 10s master passed
+1 :green_heart: checkstyle 0m 36s master passed
+1 :green_heart: spotbugs 1m 32s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 51s the patch passed
+1 :green_heart: compile 3m 12s the patch passed
+1 :green_heart: javac 3m 12s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 35s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 :green_heart: spotbugs 1m 35s the patch passed
+1 :green_heart: hadoopcheck 11m 12s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
37m 21s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 2b18f581f729 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 281a44bd2218dd0d401b5647fccfda65f772981c
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 17 '25 12:06 Apache-HBase

I'm not sure if this could work. What if 'split to hfile' is enabled? OutputSink for 'split to hfile', BoundedRecoveredHFilesOutputSink is using unique (random) name. So in this case we will get hfiles with duplicate content. Somehow if we use same name in both the workers we can escape the problem of duplicate hfiles but still we can't escape from some split failures that leads to retry and delay in splitting.

I created this ticket mainly for RecoveredEditsOutputSink. Can we create another ticket for BoundedRecoveredHFilesOutputSink ?

Umeshkumar9414 avatar Jun 17 '25 13:06 Umeshkumar9414

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 30s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 21s master passed
+1 :green_heart: compile 0m 58s master passed
+1 :green_heart: javadoc 0m 28s master passed
+1 :green_heart: shadedjars 6m 8s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 16s the patch passed
+1 :green_heart: compile 0m 58s the patch passed
+1 :green_heart: javac 0m 58s the patch passed
+1 :green_heart: javadoc 0m 27s the patch passed
+1 :green_heart: shadedjars 6m 3s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 473m 38s /patch-unit-hbase-server.txt hbase-server in the patch failed.
501m 22s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux ffed5b0ba7ff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 281a44bd2218dd0d401b5647fccfda65f772981c
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/3/testReport/
Max. process+thread count 5680 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 17 '25 20:06 Apache-HBase

@Apache9 , @NihalJain , @apurtell can you please review this PR ? I looked into failed test and found that those are getting timed out on master branch as well, will take some time to figure out what is the issue

Umeshkumar9414 avatar Jun 18 '25 13:06 Umeshkumar9414

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 38s master passed
+1 :green_heart: compile 3m 13s master passed
+1 :green_heart: checkstyle 0m 36s master passed
+1 :green_heart: spotbugs 1m 33s master passed
+1 :green_heart: spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 56s the patch passed
+1 :green_heart: compile 3m 9s the patch passed
+1 :green_heart: javac 3m 9s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 36s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 :green_heart: spotbugs 1m 37s the patch passed
+1 :green_heart: hadoopcheck 11m 14s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
37m 54s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux f4b2ecfa7f4b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0565be4850e7e3b948a31d9e0800820f267ce7b6
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 25 '25 14:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 30s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 51s master passed
+1 :green_heart: compile 0m 59s master passed
+1 :green_heart: javadoc 0m 28s master passed
+1 :green_heart: shadedjars 6m 6s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 7s the patch passed
+1 :green_heart: compile 0m 58s the patch passed
+1 :green_heart: javac 0m 58s the patch passed
+1 :green_heart: javadoc 0m 27s the patch passed
+1 :green_heart: shadedjars 6m 2s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 288m 50s /patch-unit-hbase-server.txt hbase-server in the patch failed.
316m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux c7a6fdf1fe94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0565be4850e7e3b948a31d9e0800820f267ce7b6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/4/testReport/
Max. process+thread count 4536 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 25 '25 19:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 21s master passed
+1 :green_heart: compile 4m 23s master passed
+1 :green_heart: checkstyle 0m 50s master passed
+1 :green_heart: spotbugs 1m 52s master passed
+1 :green_heart: spotless 0m 55s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 29s the patch passed
+1 :green_heart: compile 3m 31s the patch passed
+1 :green_heart: javac 3m 31s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 42s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 :green_heart: spotbugs 1m 56s the patch passed
+1 :green_heart: hadoopcheck 13m 12s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 55s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 12s The patch does not generate ASF License warnings.
45m 17s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 536db5bdcca3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0565be4850e7e3b948a31d9e0800820f267ce7b6
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 04 '25 05:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 30s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 20s master passed
+1 :green_heart: compile 0m 57s master passed
+1 :green_heart: javadoc 0m 29s master passed
+1 :green_heart: shadedjars 6m 10s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 7s the patch passed
+1 :green_heart: compile 0m 57s the patch passed
+1 :green_heart: javac 0m 57s the patch passed
+1 :green_heart: javadoc 0m 27s the patch passed
+1 :green_heart: shadedjars 6m 1s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 215m 7s hbase-server in the patch passed.
241m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux ccdf4f5162f5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0565be4850e7e3b948a31d9e0800820f267ce7b6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/5/testReport/
Max. process+thread count 5464 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 04 '25 09:07 Apache-HBase

I'm not sure if this could work. What if 'split to hfile' is enabled?

OutputSink for 'split to hfile', BoundedRecoveredHFilesOutputSink is using unique (random) name. So in this case we will get hfiles with duplicate content. Somehow if we use same name in both the workers we can escape the problem of duplicate hfiles but still we can't escape from some split failures that leads to retry and delay in splitting.

I created this ticket mainly for RecoveredEditsOutputSink. Can we create another ticket for BoundedRecoveredHFilesOutputSink ?

@Apache9 WDYT? We can make final call here. Having unique tmp recovered edits for default OutputSink might be good option to allow multiple workers (in rare cases) to continue the WAL splitting.

virajjasani avatar Jul 06 '25 16:07 virajjasani

Please give me some time to review the code.

And I suggest we change the title of this issue/PR, since it is not just 'using unique name', it is a new mechanism for WAL splitting and recovery fencing.

Thanks.

Apache9 avatar Jul 07 '25 01:07 Apache9

And on the design doc, I think we missed several critial things.

For example, how do we deal with rolling upgrading? If we change the directory name of recover edits, could old region servers without the patch read the new directory?

And also, if we allow a new RS to split while the old RS may still be splitting, then while opening the region, how can we know which one we should read? And there could also be race that, even if we delete all the recovered edits directories before opening, since no one can make sure that the 'dead' RS is dead, what if the 'dead' RS write out the recovered edits file after opening? Then after the region is reassigned, it will load the recovered edits again, which causes data inconsistency...

Apache9 avatar Jul 07 '25 01:07 Apache9

And on the design doc, I think we missed several critial things.

I tried to answer all your questions here. Replying below as well.

For example, how do we deal with rolling upgrading? If we change the directory name of recover edits, could old region servers without the patch read the new directory?

we are changing the name for temporary edit file, it is not shared. Only one worker should be using this name. So no issue in rolling upgrade.

And also, if we allow a new RS to split while the old RS may still be splitting, then while opening the region, how can we know which one we should read?

Both worker are using the same name for output recovered.edit files so result of both splitting will be same. Only change in this PR is related to intermediant temporary files.

And there could also be race that, even if we delete all the recovered edits directories before opening, since no one can make sure that the 'dead' RS is dead, what if the 'dead' RS write out the recovered edits file after opening? Then after the region is reassigned, it will load the recovered edits again, which causes data inconsistency...

We always check the sequence id before applying the edits. If dead RS write recovered edits file after opening, in the next reassign/open we will just ignore the recovred.edit file.

Umeshkumar9414 avatar Jul 07 '25 10:07 Umeshkumar9414

@Apache9, @virajjasani do you see something to improve in the PR or we can go ahead with this ?

Umeshkumar9414 avatar Jul 11 '25 05:07 Umeshkumar9414

As I asked above, if we do not change the mechanism that we will only schedule a new split worker while the previous one is complete or the region server is dead, what is the advantage of using different file names for split workers?

Apache9 avatar Jul 11 '25 07:07 Apache9

As I asked above, if we do not change the mechanism that we will only schedule a new split worker while the previous one is complete or the region server is dead, what is the advantage of using different file names for split workers?

@Apache9 In the wal splitting using recovered edits output sink, worker first writes the temporary edit files for each regions and then rename it to actual recovered edits. If a worker find a existing temporary edit file it deletes the temporary edit file and creates a new one. In our case where a zombie worker and a new worker are splitting the wal at the same time, we don't have any issue if new worker deletes the temporary files but zombie worker can also delete the temporary files being used by new worker causing new worker to fail with FileNotFoundException.

If zombie worker is slow then a new worker can fail multiple times, blocking the ServerCrashProcedure for extended period of time, thus reducing avaialability. Logs of such behaviour can be found in description of - HBASE-28951

Using differenet name ensures that both are not interferring with each other.

Umeshkumar9414 avatar Jul 11 '25 07:07 Umeshkumar9414

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 13s master passed
+1 :green_heart: compile 3m 14s master passed
+1 :green_heart: checkstyle 0m 36s master passed
+1 :green_heart: spotbugs 1m 30s master passed
+1 :green_heart: spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 53s the patch passed
+1 :green_heart: compile 3m 8s the patch passed
+1 :green_heart: javac 3m 8s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 36s the patch passed
+1 :green_heart: spotbugs 1m 37s the patch passed
+1 :green_heart: hadoopcheck 11m 34s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
37m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux ed399af13e3f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a4ac4d7f7d2e443a565bb09bf1fbff80cfea8545
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/6/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 15 '25 05:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 30s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 47s master passed
+1 :green_heart: compile 0m 58s master passed
+1 :green_heart: javadoc 0m 29s master passed
+1 :green_heart: shadedjars 6m 4s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 0m 58s the patch passed
+1 :green_heart: javac 0m 58s the patch passed
+1 :green_heart: javadoc 0m 27s the patch passed
+1 :green_heart: shadedjars 6m 6s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 226m 8s hbase-server in the patch passed.
253m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux c343a4414612 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a4ac4d7f7d2e443a565bb09bf1fbff80cfea8545
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/6/testReport/
Max. process+thread count 5452 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 15 '25 08:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 11s master passed
+1 :green_heart: compile 3m 35s master passed
+1 :green_heart: checkstyle 0m 41s master passed
+1 :green_heart: spotbugs 1m 54s master passed
+1 :green_heart: spotless 1m 8s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 41s the patch passed
+1 :green_heart: compile 3m 32s the patch passed
+1 :green_heart: javac 3m 32s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 39s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)
+1 :green_heart: spotbugs 2m 13s the patch passed
+1 :green_heart: hadoopcheck 16m 33s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 55s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 11s The patch does not generate ASF License warnings.
49m 57s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux f490f75c476f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e2c5bec6658ea0534d902ede4ee477f6a08aae3c
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/7/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 29 '25 07:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 51s master passed
+1 :green_heart: compile 0m 57s master passed
+1 :green_heart: javadoc 0m 28s master passed
+1 :green_heart: shadedjars 6m 5s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 9s the patch passed
+1 :green_heart: compile 0m 57s the patch passed
+1 :green_heart: javac 0m 57s the patch passed
+1 :green_heart: javadoc 0m 27s the patch passed
+1 :green_heart: shadedjars 6m 3s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 215m 16s /patch-unit-hbase-server.txt hbase-server in the patch failed.
242m 24s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux 045dab274f8c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e2c5bec6658ea0534d902ede4ee477f6a08aae3c
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/7/testReport/
Max. process+thread count 5486 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/7/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 29 '25 10:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 25s master passed
+1 :green_heart: compile 3m 10s master passed
+1 :green_heart: checkstyle 0m 36s master passed
+1 :green_heart: spotbugs 1m 32s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 50s the patch passed
+1 :green_heart: compile 3m 8s the patch passed
+1 :green_heart: javac 3m 8s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 35s the patch passed
+1 :green_heart: spotbugs 1m 35s the patch passed
+1 :green_heart: hadoopcheck 11m 8s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
37m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 8277d1d54ec6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 723c44623d0f0bc7ebb91886f108c558b34f03e6
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/8/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 29 '25 11:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 7s master passed
+1 :green_heart: compile 0m 58s master passed
+1 :green_heart: javadoc 0m 27s master passed
+1 :green_heart: shadedjars 6m 5s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 7s the patch passed
+1 :green_heart: compile 0m 57s the patch passed
+1 :green_heart: javac 0m 57s the patch passed
+1 :green_heart: javadoc 0m 27s the patch passed
+1 :green_heart: shadedjars 6m 4s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 304m 52s /patch-unit-hbase-server.txt hbase-server in the patch failed.
332m 7s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux 68e602fa2d75 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 723c44623d0f0bc7ebb91886f108c558b34f03e6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/8/testReport/
Max. process+thread count 4461 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/8/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 29 '25 16:07 Apache-HBase

Checked on the local both the failing test is working, So looks like both are flaky.

Umeshkumar9414 avatar Jul 29 '25 17:07 Umeshkumar9414

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 52s master passed
+1 :green_heart: compile 3m 8s master passed
+1 :green_heart: checkstyle 0m 35s master passed
+1 :green_heart: spotbugs 1m 27s master passed
+1 :green_heart: spotless 0m 42s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 49s the patch passed
+1 :green_heart: compile 3m 9s the patch passed
+1 :green_heart: javac 3m 9s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 35s the patch passed
+1 :green_heart: spotbugs 1m 37s the patch passed
+1 :green_heart: hadoopcheck 11m 7s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 8s The patch does not generate ASF License warnings.
36m 26s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 898d66923704 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 723c44623d0f0bc7ebb91886f108c558b34f03e6
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/9/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 31 '25 05:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 38s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 50s master passed
+1 :green_heart: compile 0m 57s master passed
+1 :green_heart: javadoc 0m 29s master passed
+1 :green_heart: shadedjars 6m 6s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 0m 57s the patch passed
+1 :green_heart: javac 0m 57s the patch passed
+1 :green_heart: javadoc 0m 26s the patch passed
+1 :green_heart: shadedjars 6m 2s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 213m 43s hbase-server in the patch passed.
241m 4s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7075
Optional Tests javac javadoc unit compile shadedjars
uname Linux 37872d826870 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 723c44623d0f0bc7ebb91886f108c558b34f03e6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/9/testReport/
Max. process+thread count 5602 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7075/9/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 31 '25 08:07 Apache-HBase

@Apache9 let me know if this looks good ?

Umeshkumar9414 avatar Aug 01 '25 05:08 Umeshkumar9414

I am planning to take a look next week. FYI @Apache9 if you have bandwidth to give another shot sometime this week.

virajjasani avatar Aug 06 '25 15:08 virajjasani