hbase icon indicating copy to clipboard operation
hbase copied to clipboard
verified publisher icon apache

HBASE-29359 VerifyReplication needs to join on its verification tasks

Open ndimiduk opened this issue 7 months ago • 12 comments

ndimiduk avatar May 27 '25 12:05 ndimiduk

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 3m 17s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 10s master passed
+1 :green_heart: compile 0m 45s master passed
+1 :green_heart: checkstyle 0m 20s master passed
+1 :green_heart: spotbugs 1m 17s master passed
+1 :green_heart: spotless 1m 12s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 21s the patch passed
+1 :green_heart: compile 0m 38s the patch passed
+1 :green_heart: javac 0m 38s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 15s the patch passed
-1 :x: spotbugs 0m 54s /new-spotbugs-hbase-mapreduce.html hbase-mapreduce generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: hadoopcheck 18m 39s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 56s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 12s The patch does not generate ASF License warnings.
49m 27s
Reason Tests
SpotBugs module:hbase-mapreduce
Load of known null value in org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication.run(String[]) At VerifyReplication.java:in org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication.run(String[]) At VerifyReplication.java:[line 942]
Redundant nullcheck of job which is known to be null in org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication.run(String[]) Redundant null check at VerifyReplication.java:is known to be null in org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication.run(String[]) Redundant null check at VerifyReplication.java:[line 942]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7041
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 00b9374837f9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9cf7fd98aff370feb882f1c395c5453feaef84d4
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 90 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 27 '25 22:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 2m 52s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 51s master passed
+1 :green_heart: compile 0m 21s master passed
+1 :green_heart: javadoc 0m 23s master passed
+1 :green_heart: shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 43s the patch passed
+1 :green_heart: compile 0m 20s the patch passed
+1 :green_heart: javac 0m 20s the patch passed
+1 :green_heart: javadoc 0m 14s the patch passed
+1 :green_heart: shadedjars 6m 5s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 22m 35s hbase-mapreduce in the patch passed.
48m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7041
Optional Tests javac javadoc unit compile shadedjars
uname Linux f505c268a6f1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9cf7fd98aff370feb882f1c395c5453feaef84d4
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/1/testReport/
Max. process+thread count 2362 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 27 '25 23:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 24s master passed
+1 :green_heart: compile 0m 36s master passed
+1 :green_heart: checkstyle 0m 11s master passed
+1 :green_heart: spotbugs 0m 33s master passed
+1 :green_heart: spotless 0m 50s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 8s the patch passed
+1 :green_heart: compile 0m 48s the patch passed
+1 :green_heart: javac 0m 48s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 19s the patch passed
+1 :green_heart: spotbugs 0m 53s the patch passed
+1 :green_heart: hadoopcheck 12m 33s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
33m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7041
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 1836ceaba712 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / de8fa666b27822a03da0b0116bcacf25b7c60f99
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 28 '25 22:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 18s master passed
+1 :green_heart: compile 0m 19s master passed
+1 :green_heart: javadoc 0m 15s master passed
+1 :green_heart: shadedjars 6m 6s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 0m 20s the patch passed
+1 :green_heart: javac 0m 20s the patch passed
+1 :green_heart: javadoc 0m 13s the patch passed
+1 :green_heart: shadedjars 5m 59s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 22m 10s hbase-mapreduce in the patch passed.
43m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7041
Optional Tests javac javadoc unit compile shadedjars
uname Linux da612d9b233f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / de8fa666b27822a03da0b0116bcacf25b7c60f99
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/2/testReport/
Max. process+thread count 2417 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 28 '25 22:05 Apache-HBase

Hopefully this is more aligned with the original author's intention. Let me see try it out...

FYI @hgromer .

ndimiduk avatar Jun 02 '25 12:06 ndimiduk

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 14s master passed
+1 :green_heart: compile 1m 0s master passed
+1 :green_heart: checkstyle 0m 17s master passed
+1 :green_heart: spotbugs 0m 45s master passed
+1 :green_heart: spotless 1m 3s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 3s the patch passed
+1 :green_heart: compile 0m 45s the patch passed
+1 :green_heart: javac 0m 45s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 13s /results-checkstyle-hbase-mapreduce.txt hbase-mapreduce: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 :green_heart: spotbugs 0m 44s the patch passed
+1 :green_heart: hadoopcheck 17m 26s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 55s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 13s The patch does not generate ASF License warnings.
43m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7041
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 356c84e45020 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d4948fea79b10414197ab18bdff80dd48c275482
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 03 '25 01:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 33s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 21s master passed
+1 :green_heart: compile 0m 20s master passed
+1 :green_heart: javadoc 0m 16s master passed
+1 :green_heart: shadedjars 6m 11s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 7s the patch passed
+1 :green_heart: compile 0m 20s the patch passed
+1 :green_heart: javac 0m 20s the patch passed
+1 :green_heart: javadoc 0m 14s the patch passed
+1 :green_heart: shadedjars 6m 6s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 29m 21s /patch-unit-hbase-mapreduce.txt hbase-mapreduce in the patch failed.
50m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/7041
Optional Tests javac javadoc unit compile shadedjars
uname Linux acc5c24a6706 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d4948fea79b10414197ab18bdff80dd48c275482
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/4/testReport/
Max. process+thread count 4357 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7041/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 03 '25 01:06 Apache-HBase

Test failures look related.

ndimiduk avatar Jun 03 '25 09:06 ndimiduk

Okay these are broken on master :(

ndimiduk avatar Jun 03 '25 12:06 ndimiduk

I've bisected master locally several times and it always comes back to #7048 / ae5400e77a951a69e4d80a8c7a4b54a5ad63a1e3 as the aggravating commit.

ndimiduk avatar Jun 04 '25 07:06 ndimiduk

FYI @charlesconnell . I didn't make time to investigate this further today, so pinging you now. I do intend to take a look myself, but maybe not until tomorrow at this point.

ndimiduk avatar Jun 04 '25 13:06 ndimiduk

The test command I'm using locally is

mvn clean package -T4 -am -pl hbase-mapreduce -Dtest=TestVerifyReplicationAdjunct

ndimiduk avatar Jun 04 '25 13:06 ndimiduk