apache
HBASE-29349 Upgrade to opentelemetry-semconv 1.32.0
We moved to opentelemetry latest packages with HBASE-29349 but deliberately chose to not jump to latest for semconv as it introduces few deprecations, which if removed can cause incompatibilities. With this task we want to see best approach to move to latest semconv and how to deal with these deprecations.
SemanticAttributes.java has been removed and broken down into following with semantic-conventions-java#v1.30.0-rc.1
- DbIncubatingAttributes.java
- RpcIncubatingAttributes.java
- NetIncubatingAttributes.java
- ExceptionAttributes.java
- and so on
Also there has been a few deprecations, for example refer db-migration.md
db.systemhas been deprecated and renamed todb.system.namedb.operationhas been deprecated and renamed todb.operation.name- and so on
But with first draft of this change we continue to use the deprecated names.
If we decide on following the migration guide we can remove and handle the change as suggested in the guide or simply change them and break the compatibility.
Docs:
- https://github.com/open-telemetry/semantic-conventions/tree/main/docs
- https://github.com/open-telemetry/semantic-conventions/tree/main/docs/non-normative
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | |
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 3s | master passed | |
| +1 :green_heart: | compile | 7m 51s | master passed | |
| +1 :green_heart: | checkstyle | 1m 10s | master passed | |
| +1 :green_heart: | spotbugs | 8m 14s | master passed | |
| +1 :green_heart: | spotless | 0m 46s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 2m 55s | the patch passed | |
| +1 :green_heart: | compile | 7m 54s | the patch passed | |
| +1 :green_heart: | javac | 7m 54s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 1m 15s | /results-checkstyle-root.txt | root: The patch generated 4 new + 7 unchanged - 0 fixed = 11 total (was 7) |
| +1 :green_heart: | xmllint | 0m 0s | No new issues. | |
| +1 :green_heart: | spotbugs | 8m 48s | the patch passed | |
| +1 :green_heart: | hadoopcheck | 11m 38s | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. | |
| -1 :x: | spotless | 0m 13s | patch has 43 errors when running spotless:check, run spotless:apply to fix. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. | |
| 62m 51s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7016/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7016 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti |
| uname | Linux 0296e70d7dd4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3b162935e0eac5a2379b7ef0d0e6efa28225b365 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7016/2/artifact/yetus-general-check/output/patch-spotless.txt |
| Max. process+thread count | 192 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-mapreduce . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7016/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
We've never made any statement about compatibility of any type of structured logging across releases. We should adopt a policy going forward.
I think that we can progress this change over minor release lines. We can emit old and new keys for the 2.6.x releases and drop the old in 2.7. Include a release note. Should be fine.
