hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-29285 Use DataNode port as favored-node port to make bulk load …

Open chandrasekhar-188k opened this issue 7 months ago • 3 comments

…follow locality

chandrasekhar-188k avatar May 06 '25 03:05 chandrasekhar-188k

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 15s master passed
+1 :green_heart: compile 0m 36s master passed
+1 :green_heart: checkstyle 0m 11s master passed
+1 :green_heart: spotbugs 0m 30s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 4s the patch passed
+1 :green_heart: compile 0m 34s the patch passed
+1 :green_heart: javac 0m 34s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 11s the patch passed
+1 :green_heart: spotbugs 0m 36s the patch passed
+1 :green_heart: hadoopcheck 11m 44s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
30m 7s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6962/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6962
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 3faaf6a87355 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8c7d1e472ee73d6e596e3aa5958dc4e1e1c6c4e5
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6962/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 06 '25 04:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 34s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 11s master passed
+1 :green_heart: compile 0m 19s master passed
+1 :green_heart: javadoc 0m 15s master passed
+1 :green_heart: shadedjars 5m 54s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 7s the patch passed
+1 :green_heart: compile 0m 19s the patch passed
+1 :green_heart: javac 0m 19s the patch passed
+1 :green_heart: javadoc 0m 14s the patch passed
+1 :green_heart: shadedjars 5m 53s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 16m 37s hbase-mapreduce in the patch passed.
37m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6962/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6962
Optional Tests javac javadoc unit compile shadedjars
uname Linux de74fe2e8bac 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8c7d1e472ee73d6e596e3aa5958dc4e1e1c6c4e5
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6962/1/testReport/
Max. process+thread count 2503 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6962/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 06 '25 04:05 Apache-HBase

Nice catch, thanks for the fix, looks good to me. 👍 Is it possible to add a unit test for this? 🤔

thanks for the review, let me check if its possible to add a UT for this.

chandrasekhar-188k avatar May 06 '25 07:05 chandrasekhar-188k

closing the PR as this change not required

chandrasekhar-188k avatar Nov 10 '25 14:11 chandrasekhar-188k