hbase icon indicating copy to clipboard operation
hbase copied to clipboard
verified publisher icon apache

HBASE-29233: Capture scan metrics at region level

Open sanjeet006py opened this issue 9 months ago • 46 comments

JIRA: HBASE-29233

sanjeet006py avatar Mar 30 '25 15:03 sanjeet006py

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 12s master passed
+1 :green_heart: compile 4m 0s master passed
+1 :green_heart: checkstyle 0m 53s master passed
+1 :green_heart: spotbugs 2m 20s master passed
+1 :green_heart: spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 1s the patch passed
+1 :green_heart: compile 3m 57s the patch passed
+1 :green_heart: javac 3m 57s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 14s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 4 new + 6 unchanged - 0 fixed = 10 total (was 6)
-0 :warning: checkstyle 0m 37s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 9 new + 2 unchanged - 0 fixed = 11 total (was 2)
-1 :x: spotbugs 0m 50s /new-spotbugs-hbase-client.html hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: hadoopcheck 11m 44s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x: spotless 0m 18s patch has 67 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
42m 4s
Reason Tests
SpotBugs module:hbase-client
org.apache.hadoop.hbase.client.metrics.ServerSideScanMetrics.enableVerboseToString isn't final but should be At ServerSideScanMetrics.java:be At ServerSideScanMetrics.java:[line 36]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux ce69b2d0dcae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 32a7e8ec2ea1b9f5200c25db2835fc764dc40f7c
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 30 '25 16:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 2m 59s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 14s master passed
+1 :green_heart: compile 1m 16s master passed
+1 :green_heart: javadoc 0m 44s master passed
+1 :green_heart: shadedjars 6m 0s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 3s the patch passed
+1 :green_heart: compile 1m 19s the patch passed
+1 :green_heart: javac 1m 19s the patch passed
+1 :green_heart: javadoc 0m 45s the patch passed
+1 :green_heart: shadedjars 5m 57s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 36s hbase-client in the patch passed.
+1 :green_heart: unit 211m 44s hbase-server in the patch passed.
244m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux 03ae08b9b59b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 32a7e8ec2ea1b9f5200c25db2835fc764dc40f7c
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/1/testReport/
Max. process+thread count 5133 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 30 '25 19:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 24s master passed
+1 :green_heart: compile 4m 27s master passed
+1 :green_heart: checkstyle 1m 11s master passed
+1 :green_heart: spotbugs 2m 56s master passed
+1 :green_heart: spotless 0m 59s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 42s the patch passed
+1 :green_heart: compile 4m 34s the patch passed
+1 :green_heart: javac 4m 34s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 46s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 :green_heart: spotbugs 3m 12s the patch passed
+1 :green_heart: hadoopcheck 15m 26s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 1m 0s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 25s The patch does not generate ASF License warnings.
55m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux c273efc1e1df 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bab2be13809dd05f43ec2055c247f4751c5d89fe
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 31 '25 23:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 33s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 49s master passed
+1 :green_heart: compile 1m 44s master passed
+1 :green_heart: javadoc 0m 58s master passed
+1 :green_heart: shadedjars 7m 11s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 43s the patch passed
+1 :green_heart: compile 1m 38s the patch passed
+1 :green_heart: javac 1m 38s the patch passed
+1 :green_heart: javadoc 0m 58s the patch passed
+1 :green_heart: shadedjars 6m 37s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 1s hbase-client in the patch passed.
+1 :green_heart: unit 219m 13s hbase-server in the patch passed.
253m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux be6cfa520c30 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bab2be13809dd05f43ec2055c247f4751c5d89fe
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/2/testReport/
Max. process+thread count 4787 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 01 '25 03:04 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 42s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 27s master passed
+1 :green_heart: compile 3m 58s master passed
+1 :green_heart: checkstyle 0m 52s master passed
+1 :green_heart: spotbugs 2m 14s master passed
+1 :green_heart: spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 0s the patch passed
+1 :green_heart: compile 3m 51s the patch passed
+1 :green_heart: javac 3m 51s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 36s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 :green_heart: spotbugs 2m 24s the patch passed
+1 :green_heart: hadoopcheck 11m 52s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
43m 8s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux d73573748501 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bab2be13809dd05f43ec2055c247f4751c5d89fe
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 01 '25 04:04 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 30s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 59s master passed
+1 :green_heart: compile 1m 22s master passed
+1 :green_heart: javadoc 0m 45s master passed
+1 :green_heart: shadedjars 5m 55s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 0s the patch passed
+1 :green_heart: compile 1m 16s the patch passed
+1 :green_heart: javac 1m 16s the patch passed
+1 :green_heart: javadoc 0m 44s the patch passed
+1 :green_heart: shadedjars 5m 51s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 35s hbase-client in the patch passed.
+1 :green_heart: unit 214m 19s hbase-server in the patch passed.
243m 33s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux d3cc8805f21b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bab2be13809dd05f43ec2055c247f4751c5d89fe
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/3/testReport/
Max. process+thread count 4752 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 01 '25 07:04 Apache-HBase

Ping @virajjasani

Apache9 avatar Apr 22 '25 14:04 Apache9

Planning to take a look in a couple of days. @Apache9 if you are interested, please feel free to review, we are planning to use this internally soon.

virajjasani avatar Apr 23 '25 03:04 virajjasani

@rmdmattingly @ndimiduk since you have very recently reviewed HBASE-29090 already, could you please also take a look at this PR also? This too should be quite helpful.

virajjasani avatar Apr 23 '25 18:04 virajjasani

Oh, and please run spotless:apply before your next push.

ndimiduk avatar Apr 24 '25 10:04 ndimiduk

One high-level question though: why are you adding this as a bolt-on" instead of extending the existing ScanMetrics object with the per-region collection?

Actually I didn't consider extending existing ScanMetrics. And, I agree by extending existing ScanMetrics many of above comments will also get resolved along with making implementation more cleaner. Will rework on this. Thanks a lot.

sanjeet006py avatar Apr 24 '25 10:04 sanjeet006py

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 35s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 29s master passed
+1 :green_heart: compile 1m 18s master passed
+1 :green_heart: javadoc 0m 44s master passed
+1 :green_heart: shadedjars 5m 58s branch has no errors when building our shaded downstream artifacts.
-0 :warning: patch 6m 14s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
-1 :x: mvninstall 0m 51s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 10s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-1 :x: compile 0m 42s /patch-compile-hbase-server.txt hbase-server in the patch failed.
-0 :warning: javac 0m 10s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-0 :warning: javac 0m 42s /patch-compile-hbase-server.txt hbase-server in the patch failed.
-0 :warning: javadoc 0m 16s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 8 new + 28 unchanged - 0 fixed = 36 total (was 28)
-1 :x: shadedjars 2m 23s patch has 10 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 :x: unit 0m 10s /patch-unit-hbase-client.txt hbase-client in the patch failed.
-1 :x: unit 0m 40s /patch-unit-hbase-server.txt hbase-server in the patch failed.
19m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux eeddab839bc0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4fa7f7955205d251c3f2c8693745efd27d5d9cab
Default Java Eclipse Adoptium-17.0.11+9
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/testReport/
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 29 '25 15:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 37s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 2s master passed
+1 :green_heart: compile 4m 40s master passed
+1 :green_heart: checkstyle 0m 59s master passed
+1 :green_heart: spotbugs 3m 5s master passed
+1 :green_heart: spotless 0m 59s branch has no errors when running spotless:check.
-0 :warning: patch 1m 13s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
-1 :x: mvninstall 0m 59s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 11s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-1 :x: compile 0m 48s /patch-compile-hbase-server.txt hbase-server in the patch failed.
-0 :warning: javac 0m 11s /patch-compile-hbase-client.txt hbase-client in the patch failed.
-0 :warning: javac 0m 48s /patch-compile-hbase-server.txt hbase-server in the patch failed.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 16s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 10 new + 4 unchanged - 9 fixed = 14 total (was 13)
-1 :x: spotbugs 0m 12s /patch-spotbugs-hbase-client.txt hbase-client in the patch failed.
-1 :x: spotbugs 0m 50s /patch-spotbugs-hbase-server.txt hbase-server in the patch failed.
-1 :x: hadoopcheck 1m 11s The patch causes 10 errors with Hadoop v3.3.6.
-1 :x: hadoopcheck 2m 28s The patch causes 10 errors with Hadoop v3.4.0.
+1 :green_heart: spotless 0m 57s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 21s The patch does not generate ASF License warnings.
25m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux f1e46482c6d3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4fa7f7955205d251c3f2c8693745efd27d5d9cab
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 29 '25 16:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 43s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 20s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 43s master passed
+1 :green_heart: compile 5m 34s master passed
+1 :green_heart: checkstyle 1m 14s master passed
+1 :green_heart: spotbugs 3m 8s master passed
+1 :green_heart: spotless 1m 1s branch has no errors when running spotless:check.
-0 :warning: patch 1m 18s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 4s the patch passed
+1 :green_heart: compile 5m 12s the patch passed
-0 :warning: javac 0m 57s /results-compile-javac-hbase-client.txt hbase-client generated 2 new + 103 unchanged - 2 fixed = 105 total (was 105)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 28s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 9 new + 4 unchanged - 9 fixed = 13 total (was 13)
-1 :x: spotbugs 1m 20s /new-spotbugs-hbase-client.html hbase-client generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 :green_heart: hadoopcheck 15m 12s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 1m 1s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 20s The patch does not generate ASF License warnings.
58m 16s
Reason Tests
SpotBugs module:hbase-client
Unread public/protected field:At AbstractClientScanner.java:[line 29]
Unread public/protected field:At ScanMetrics.java:[line 116]
Unread public/protected field:At ScanMetrics.java:[line 115]
Unread public/protected field:At ServerSideScanMetrics.java:[line 64]
Unread public/protected field:At ServerSideScanMetrics.java:[line 63]
Unread public/protected field:At ServerSideScanMetrics.java:[line 62]
Unread public/protected field:At ServerSideScanMetrics.java:[line 65]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 311fc5d6739e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 87c6cf9848e0f1973f90bf7a574e6bf99291ebeb
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 29 '25 17:04 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 5s master passed
+1 :green_heart: compile 1m 19s master passed
+1 :green_heart: javadoc 0m 44s master passed
+1 :green_heart: shadedjars 5m 55s branch has no errors when building our shaded downstream artifacts.
-0 :warning: patch 6m 11s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 12s the patch passed
+1 :green_heart: compile 1m 18s the patch passed
+1 :green_heart: javac 1m 18s the patch passed
-0 :warning: javadoc 0m 17s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 8 new + 28 unchanged - 0 fixed = 36 total (was 28)
+1 :green_heart: shadedjars 5m 53s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 36s hbase-client in the patch passed.
+1 :green_heart: unit 216m 48s hbase-server in the patch passed.
245m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux 8360b5e85146 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 87c6cf9848e0f1973f90bf7a574e6bf99291ebeb
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/5/testReport/
Max. process+thread count 4933 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 29 '25 20:04 Apache-HBase

@virajjasani @ndimiduk I have addressed all the PR comments and now region level scan metrics are wrapped inside ScanMetrics object. Please take a look. Thanks

(The spotbugs doesn't seems to be introduced by my patch. My patch introduced 1 spotbug and I have fixed it.)

sanjeet006py avatar Apr 30 '25 03:04 sanjeet006py

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 0s Docker mode activated.
-1 :x: docker 0m 4s Docker failed to build run-specific yetus/hbase:tp-7609}.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/6/console
versions git=2.17.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 30 '25 07:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 6s master passed
+1 :green_heart: compile 3m 55s master passed
+1 :green_heart: checkstyle 0m 54s master passed
+1 :green_heart: spotbugs 2m 17s master passed
+1 :green_heart: spotless 0m 47s branch has no errors when running spotless:check.
-0 :warning: patch 0m 59s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 4m 1s the patch passed
-0 :warning: javac 0m 48s /results-compile-javac-hbase-client.txt hbase-client generated 2 new + 103 unchanged - 2 fixed = 105 total (was 105)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 16s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 9 new + 4 unchanged - 9 fixed = 13 total (was 13)
-1 :x: spotbugs 0m 52s /new-spotbugs-hbase-client.html hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 :green_heart: hadoopcheck 11m 57s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 17s The patch does not generate ASF License warnings.
43m 6s
Reason Tests
SpotBugs module:hbase-client
Unread public/protected field:At ScanMetrics.java:[line 116]
Unread public/protected field:At ScanMetrics.java:[line 115]
Unread public/protected field:At ServerSideScanMetrics.java:[line 64]
Unread public/protected field:At ServerSideScanMetrics.java:[line 63]
Unread public/protected field:At ServerSideScanMetrics.java:[line 62]
Unread public/protected field:At ServerSideScanMetrics.java:[line 65]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 6fbacbee1527 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0c65103e78aa698ebbf8f997337e20b77786159f
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/6/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 30 '25 08:04 Apache-HBase

Hi @ndimiduk, the PR is ready for review. I have addressed all the comments. Please re-review. Thanks

sanjeet006py avatar May 02 '25 19:05 sanjeet006py

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 19s master passed
+1 :green_heart: compile 4m 59s master passed
+1 :green_heart: checkstyle 1m 8s master passed
+1 :green_heart: spotbugs 2m 48s master passed
+1 :green_heart: spotless 0m 52s branch has no errors when running spotless:check.
-0 :warning: patch 1m 5s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 40s the patch passed
+1 :green_heart: compile 4m 32s the patch passed
-0 :warning: javac 0m 59s /results-compile-javac-hbase-client.txt hbase-client generated 2 new + 103 unchanged - 2 fixed = 105 total (was 105)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 21s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 9 new + 4 unchanged - 9 fixed = 13 total (was 13)
-1 :x: spotbugs 1m 6s /new-spotbugs-hbase-client.html hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 :green_heart: hadoopcheck 15m 18s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 1m 9s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 23s The patch does not generate ASF License warnings.
53m 40s
Reason Tests
SpotBugs module:hbase-client
Unread public/protected field:At ScanMetrics.java:[line 116]
Unread public/protected field:At ScanMetrics.java:[line 115]
Unread public/protected field:At ServerSideScanMetrics.java:[line 64]
Unread public/protected field:At ServerSideScanMetrics.java:[line 63]
Unread public/protected field:At ServerSideScanMetrics.java:[line 62]
Unread public/protected field:At ServerSideScanMetrics.java:[line 65]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux be769d9f912c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 011bae7e2b3531995c82cbdee7f00490f63501ea
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/7/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 03 '25 23:05 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 35s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 36s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 54s master passed
+1 :green_heart: compile 1m 49s master passed
+1 :green_heart: javadoc 1m 1s master passed
+1 :green_heart: shadedjars 7m 41s branch has no errors when building our shaded downstream artifacts.
-0 :warning: patch 8m 3s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 5s the patch passed
+1 :green_heart: compile 1m 49s the patch passed
+1 :green_heart: javac 1m 49s the patch passed
-0 :warning: javadoc 0m 23s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 8 new + 28 unchanged - 0 fixed = 36 total (was 28)
+1 :green_heart: shadedjars 6m 53s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 52s hbase-client in the patch passed.
-1 :x: unit 254m 40s /patch-unit-hbase-server.txt hbase-server in the patch failed.
291m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux d253d6ad2605 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 011bae7e2b3531995c82cbdee7f00490f63501ea
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/7/testReport/
Max. process+thread count 4571 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/7/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 04 '25 03:05 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 3s master passed
+1 :green_heart: compile 4m 59s master passed
+1 :green_heart: checkstyle 1m 12s master passed
+1 :green_heart: spotbugs 2m 56s master passed
+1 :green_heart: spotless 0m 54s branch has no errors when running spotless:check.
-0 :warning: patch 1m 8s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 56s the patch passed
+1 :green_heart: compile 4m 54s the patch passed
-0 :warning: javac 1m 1s /results-compile-javac-hbase-client.txt hbase-client generated 2 new + 103 unchanged - 2 fixed = 105 total (was 105)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 19s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 9 new + 4 unchanged - 9 fixed = 13 total (was 13)
-1 :x: spotbugs 1m 2s /new-spotbugs-hbase-client.html hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 :green_heart: hadoopcheck 14m 22s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 1m 8s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 29s The patch does not generate ASF License warnings.
53m 30s
Reason Tests
SpotBugs module:hbase-client
Unread public/protected field:At ScanMetrics.java:[line 116]
Unread public/protected field:At ScanMetrics.java:[line 115]
Unread public/protected field:At ServerSideScanMetrics.java:[line 64]
Unread public/protected field:At ServerSideScanMetrics.java:[line 63]
Unread public/protected field:At ServerSideScanMetrics.java:[line 62]
Unread public/protected field:At ServerSideScanMetrics.java:[line 65]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 02a4a695e276 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0cdc421ecd0301a96da9d4b18f7a97a9b5193676
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/8/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 04 '25 13:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 33s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 14s master passed
+1 :green_heart: compile 1m 16s master passed
+1 :green_heart: javadoc 0m 44s master passed
+1 :green_heart: shadedjars 5m 51s branch has no errors when building our shaded downstream artifacts.
-0 :warning: patch 6m 7s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 0s the patch passed
+1 :green_heart: compile 1m 16s the patch passed
+1 :green_heart: javac 1m 16s the patch passed
-0 :warning: javadoc 0m 16s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 8 new + 28 unchanged - 0 fixed = 36 total (was 28)
+1 :green_heart: shadedjars 5m 49s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 33s hbase-client in the patch passed.
+1 :green_heart: unit 211m 47s hbase-server in the patch passed.
241m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux 26e9c3eb2692 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0cdc421ecd0301a96da9d4b18f7a97a9b5193676
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/8/testReport/
Max. process+thread count 5468 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/8/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 04 '25 16:05 Apache-HBase

Planning to take another look soon. @sanjeet006py could you try resolving checkstyle, javadoc, spotbugs warnings in the meantime?

virajjasani avatar May 06 '25 06:05 virajjasani

@virajjasani I think the spotbugs haven't been introduced by this PR but were already there. The public/protected fields that have been flagged were already there as public/protected fields.

sanjeet006py avatar May 06 '25 17:05 sanjeet006py

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 39s Maven dependency ordering for branch
+1 :green_heart: mvninstall 5m 1s master passed
+1 :green_heart: compile 6m 22s master passed
+1 :green_heart: checkstyle 1m 40s master passed
+1 :green_heart: spotbugs 3m 30s master passed
-1 :x: spotless 1m 15s branch has 1 errors when running spotless:check, run spotless:apply to fix.
-0 :warning: patch 1m 36s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 21s the patch passed
+1 :green_heart: compile 5m 36s the patch passed
-0 :warning: javac 1m 7s /results-compile-javac-hbase-client.txt hbase-client generated 2 new + 103 unchanged - 2 fixed = 105 total (was 105)
+1 :green_heart: blanks 0m 1s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 25s hbase-client: The patch generated 0 new + 4 unchanged - 9 fixed = 4 total (was 13)
+1 :green_heart: checkstyle 0m 59s The patch passed checkstyle in hbase-server
-1 :x: spotbugs 1m 26s /new-spotbugs-hbase-client.html hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 :green_heart: hadoopcheck 16m 21s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 1m 20s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 31s The patch does not generate ASF License warnings.
64m 11s
Reason Tests
SpotBugs module:hbase-client
Unread public/protected field:At ScanMetrics.java:[line 125]
Unread public/protected field:At ScanMetrics.java:[line 124]
Unread public/protected field:At ServerSideScanMetrics.java:[line 64]
Unread public/protected field:At ServerSideScanMetrics.java:[line 63]
Unread public/protected field:At ServerSideScanMetrics.java:[line 62]
Unread public/protected field:At ServerSideScanMetrics.java:[line 65]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 063a64f5d88b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9a9bd254e836bbfab4dc0ff9e1895a07bdf95ae1
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/9/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/9/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 09 '25 13:05 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 50s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 57s master passed
+1 :green_heart: compile 2m 22s master passed
+1 :green_heart: javadoc 1m 24s master passed
+1 :green_heart: shadedjars 8m 50s branch has no errors when building our shaded downstream artifacts.
-0 :warning: patch 9m 13s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 16s the patch passed
+1 :green_heart: compile 2m 6s the patch passed
+1 :green_heart: javac 2m 6s the patch passed
+1 :green_heart: javadoc 1m 5s the patch passed
+1 :green_heart: shadedjars 8m 21s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 3s hbase-client in the patch passed.
-1 :x: unit 294m 42s /patch-unit-hbase-server.txt hbase-server in the patch failed.
337m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux 558b5d7077d8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9a9bd254e836bbfab4dc0ff9e1895a07bdf95ae1
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/9/testReport/
Max. process+thread count 4465 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/9/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 09 '25 17:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 31s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 23s master passed
+1 :green_heart: compile 3m 57s master passed
+1 :green_heart: checkstyle 0m 52s master passed
+1 :green_heart: spotbugs 2m 15s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
-0 :warning: patch 0m 57s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 7s the patch passed
+1 :green_heart: compile 3m 58s the patch passed
-0 :warning: javac 0m 47s /results-compile-javac-hbase-client.txt hbase-client generated 2 new + 103 unchanged - 2 fixed = 105 total (was 105)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 15s hbase-client: The patch generated 0 new + 4 unchanged - 9 fixed = 4 total (was 13)
+1 :green_heart: checkstyle 0m 36s The patch passed checkstyle in hbase-server
+1 :green_heart: spotbugs 2m 27s the patch passed
+1 :green_heart: hadoopcheck 12m 7s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 19s The patch does not generate ASF License warnings.
43m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 8fd31be5a36f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 54189d8ea62365467313cd9b3e178b2765d04196
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/10/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 11 '25 13:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 24s master passed
+1 :green_heart: compile 1m 17s master passed
+1 :green_heart: javadoc 0m 45s master passed
+1 :green_heart: shadedjars 5m 57s branch has no errors when building our shaded downstream artifacts.
-0 :warning: patch 6m 12s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 8s the patch passed
+1 :green_heart: compile 1m 17s the patch passed
+1 :green_heart: javac 1m 17s the patch passed
+1 :green_heart: javadoc 0m 43s the patch passed
+1 :green_heart: shadedjars 6m 0s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 1m 35s hbase-client in the patch passed.
+1 :green_heart: unit 212m 19s hbase-server in the patch passed.
242m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/10/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6868
JIRA Issue HBASE-29233
Optional Tests javac javadoc unit compile shadedjars
uname Linux 3f6e7384313d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 54189d8ea62365467313cd9b3e178b2765d04196
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/10/testReport/
Max. process+thread count 5099 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6868/10/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 11 '25 16:05 Apache-HBase

@ndimiduk could you please take another look?

virajjasani avatar May 12 '25 16:05 virajjasani