hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-28928 Handle NPE in Split/Merge table when getMasterQuotaManager returns null

Open mnpoonia opened this issue 1 year ago • 4 comments

mnpoonia avatar Oct 21 '24 10:10 mnpoonia

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 49s master passed
+1 :green_heart: compile 3m 13s master passed
+1 :green_heart: checkstyle 0m 45s master passed
-1 :x: spotbugs 1m 57s /branch-spotbugs-hbase-server-warnings.html hbase-server in master has 1 extant spotbugs warnings.
+1 :green_heart: spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 28s the patch passed
+1 :green_heart: compile 3m 32s the patch passed
+1 :green_heart: javac 3m 32s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 40s the patch passed
+1 :green_heart: spotbugs 1m 58s the patch passed
+1 :green_heart: hadoopcheck 10m 46s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
39m 9s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6375
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 88fb3747b398 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 726b2d8e2f2ba70bedd277bb9f2cc9e2b1749eb9
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Oct 21 '24 10:10 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 40s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 3s master passed
+1 :green_heart: compile 0m 58s master passed
+1 :green_heart: javadoc 0m 31s master passed
+1 :green_heart: shadedjars 5m 11s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 56s the patch passed
+1 :green_heart: compile 0m 59s the patch passed
+1 :green_heart: javac 0m 59s the patch passed
+1 :green_heart: javadoc 0m 30s the patch passed
+1 :green_heart: shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 225m 35s hbase-server in the patch passed.
250m 20s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6375
Optional Tests javac javadoc unit compile shadedjars
uname Linux a96bd06cf324 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 726b2d8e2f2ba70bedd277bb9f2cc9e2b1749eb9
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/testReport/
Max. process+thread count 4577 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Oct 21 '24 14:10 Apache-HBase

Spotbugs failure is unrelated.

mnpoonia avatar Oct 21 '24 15:10 mnpoonia

+1, LGTM

NihalJain avatar Oct 22 '24 09:10 NihalJain

@NihalJain if everything is good. can you please help me in getting this committed upto branch-2.5.

mnpoonia avatar Oct 24 '24 04:10 mnpoonia

@NihalJain if everything is good. can you please help me in getting this committed upto branch-2.5.

Sure let me merge to master and ping back.

NihalJain avatar Oct 24 '24 04:10 NihalJain

Merged. Thanks for the fix Aman. Could you please raise backports by cherry picking mfrom master.?

NihalJain avatar Oct 24 '24 04:10 NihalJain