hbase
hbase copied to clipboard
apache
WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende…
This is a demo PR and is bound to fail to compile as it needs snapshot version of hbase-thirdparty. To test this we need to first build hbase -thirdparty https://github.com/apache/hbase-thirdparty/pull/124 locally and this one next.
CC: @ndimiduk
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 40s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 8s | master passed | |
| +1 :green_heart: | compile | 8m 22s | master passed | |
| +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| -1 :x: | mvninstall | 0m 7s | /branch-mvninstall-root.txt | root in master failed. |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | |
| -1 :x: | mvninstall | 0m 6s | /patch-mvninstall-root.txt | root in the patch failed. |
| -1 :x: | compile | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| -0 :warning: | javac | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| +1 :green_heart: | xmllint | 0m 0s | No new issues. | |
| -1 :x: | hadoopcheck | 0m 4s | The patch causes 13 errors with Hadoop v3.3.6. | |
| -1 :x: | hadoopcheck | 0m 8s | The patch causes 13 errors with Hadoop v3.4.0. | |
| -1 :x: | spotless | 0m 5s | patch has 13 errors when running spotless:check, run spotless:apply to fix. | |
| _ Other Tests _ | ||||
| +0 :ok: | asflicense | 0m 18s | ASF License check generated no output? | |
| 15m 37s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6366 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile |
| uname | Linux 9c85271a3c38 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f795fc0689dc110157f8ca8574b87e5a0111a195 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-spotless.txt |
| Max. process+thread count | 190 (vs. ulimit of 30000) |
| modules | C: . hbase-examples hbase-protocol-shaded U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/console |
| versions | git=2.34.1 maven=3.9.8 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 19s | master passed | |
| +1 :green_heart: | compile | 2m 16s | master passed | |
| +1 :green_heart: | javadoc | 2m 24s | master passed | |
| +1 :green_heart: | shadedjars | 5m 52s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| -1 :x: | mvninstall | 0m 6s | /branch-mvninstall-root.txt | root in master failed. |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | |
| -1 :x: | mvninstall | 0m 6s | /patch-mvninstall-root.txt | root in the patch failed. |
| -1 :x: | compile | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| -0 :warning: | javac | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| -0 :warning: | javadoc | 0m 5s | /patch-javadoc-root.txt | root in the patch failed. |
| -0 :warning: | javadoc | 0m 6s | /patch-javadoc-hbase-examples.txt | hbase-examples in the patch failed. |
| -0 :warning: | javadoc | 0m 5s | /patch-javadoc-hbase-protocol-shaded.txt | hbase-protocol-shaded in the patch failed. |
| -1 :x: | shadedjars | 0m 4s | patch has 13 errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| -1 :x: | unit | 0m 5s | /patch-unit-root.txt | root in the patch failed. |
| 16m 34s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6366 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 13b02440f383 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f795fc0689dc110157f8ca8574b87e5a0111a195 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/testReport/ |
| Max. process+thread count | 173 (vs. ulimit of 30000) |
| modules | C: . hbase-examples hbase-protocol-shaded U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
Nice. How do we provie to ourselves that this change is correct? A diff of before and after dependency:list of each module?
Sure, let me share the dependency tree with and without this change.
Nice. How do we provie to ourselves that this change is correct? A diff of before and after dependency:list of each module?
Sure, let me share the dependency tree with and without this change.
mvn dependency:list
- On Master: list_master.txt
- With BOM: list_bom.txt
mvn dependency:tree
- On Master: tree_master.txt
- With BOM: tree_bom.txt
Skimmed the files, looks fine except the fact that maybe we should not manage com.google.protobuf:protobuf-java in PR: https://github.com/apache/hbase-thirdparty/pull/124 as it overrides the one coming from hadoop.
Expected: [INFO] com.google.protobuf:protobuf-java:jar:2.5.0:compile -- module protobuf.java (auto) Actual: [INFO] com.google.protobuf:protobuf-java:jar:4.28.2:compile -- module com.google.protobuf [auto]
Does importing boms work this way? we can get transitivity over a series of imports?
We have netty version changes as both are not in sync in master and hbase-thirdparty and this also clears the transitivity question asked earlier.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 40s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 5s | master passed | |
| +1 :green_heart: | compile | 8m 23s | master passed | |
| +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| -1 :x: | mvninstall | 0m 6s | /branch-mvninstall-root.txt | root in master failed. |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | |
| -1 :x: | mvninstall | 0m 6s | /patch-mvninstall-root.txt | root in the patch failed. |
| -1 :x: | compile | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| -0 :warning: | javac | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| +1 :green_heart: | xmllint | 0m 0s | No new issues. | |
| -1 :x: | hadoopcheck | 0m 4s | The patch causes 13 errors with Hadoop v3.3.6. | |
| -1 :x: | hadoopcheck | 0m 8s | The patch causes 13 errors with Hadoop v3.4.0. | |
| -1 :x: | spotless | 0m 4s | patch has 13 errors when running spotless:check, run spotless:apply to fix. | |
| _ Other Tests _ | ||||
| +0 :ok: | asflicense | 0m 18s | ASF License check generated no output? | |
| 15m 34s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6366 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile |
| uname | Linux 49c62118c4ec 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e0d907780edf95aed7cc851deb758d79b11bcff5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-spotless.txt |
| Max. process+thread count | 192 (vs. ulimit of 30000) |
| modules | C: . hbase-examples hbase-protocol-shaded U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/console |
| versions | git=2.34.1 maven=3.9.8 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 20s | master passed | |
| +1 :green_heart: | compile | 2m 16s | master passed | |
| +1 :green_heart: | javadoc | 2m 23s | master passed | |
| +1 :green_heart: | shadedjars | 5m 52s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| -1 :x: | mvninstall | 0m 6s | /branch-mvninstall-root.txt | root in master failed. |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | |
| -1 :x: | mvninstall | 0m 6s | /patch-mvninstall-root.txt | root in the patch failed. |
| -1 :x: | compile | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| -0 :warning: | javac | 0m 6s | /patch-compile-root.txt | root in the patch failed. |
| -0 :warning: | javadoc | 0m 6s | /patch-javadoc-root.txt | root in the patch failed. |
| -0 :warning: | javadoc | 0m 5s | /patch-javadoc-hbase-examples.txt | hbase-examples in the patch failed. |
| -0 :warning: | javadoc | 0m 5s | /patch-javadoc-hbase-protocol-shaded.txt | hbase-protocol-shaded in the patch failed. |
| -1 :x: | shadedjars | 0m 4s | patch has 13 errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| -1 :x: | unit | 0m 6s | /patch-unit-root.txt | root in the patch failed. |
| 16m 40s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6366 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 3f74d56edd8e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e0d907780edf95aed7cc851deb758d79b11bcff5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/testReport/ |
| Max. process+thread count | 173 (vs. ulimit of 30000) |
| modules | C: . hbase-examples hbase-protocol-shaded U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.