hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-28860 Add a metric of the amount of data written to WAL to determine the pressure of replication

Open terrytlu opened this issue 1 year ago • 7 comments

Add a metric of the amount of data written to WAL to determine the pressure of replication.

Combined with the replication shipped size metric, the user can determine how many RegionServers are needed to meet the data(WAL) writing requirements, that is to achieve the goal of no replication lag.

In the postAppend method of ReplicationSourceWALActionListener, the amount of WAL data that needs to be replicated is counted, and the filter logic in replication is reused.

Alos add a hbase.replication.walAppendsize.metric.enabled=false config to disable this metric, if it has some side effect.

terrytlu avatar Sep 18 '24 10:09 terrytlu

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 16s master passed
+1 :green_heart: compile 4m 9s master passed
+1 :green_heart: checkstyle 0m 59s master passed
+1 :green_heart: spotbugs 2m 29s master passed
+1 :green_heart: spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 14s the patch passed
+1 :green_heart: compile 4m 6s the patch passed
+1 :green_heart: javac 4m 6s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 58s the patch passed
+1 :green_heart: spotbugs 2m 50s the patch passed
+1 :green_heart: hadoopcheck 11m 46s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 26s The patch does not generate ASF License warnings.
44m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6260
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 30d8b6c28edb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1efb868d740c874d071b97c1b14470f391f7d6e8
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-common hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 18 '24 11:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 40s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 5s master passed
+1 :green_heart: compile 1m 56s master passed
+1 :green_heart: javadoc 1m 5s master passed
+1 :green_heart: shadedjars 5m 26s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 6s the patch passed
+1 :green_heart: compile 1m 37s the patch passed
+1 :green_heart: javac 1m 37s the patch passed
+1 :green_heart: javadoc 1m 4s the patch passed
+1 :green_heart: shadedjars 5m 23s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 20s hbase-common in the patch passed.
+1 :green_heart: unit 0m 46s hbase-hadoop-compat in the patch passed.
-1 :x: unit 256m 13s /patch-unit-hbase-server.txt hbase-server in the patch failed.
289m 22s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6260
Optional Tests javac javadoc unit compile shadedjars
uname Linux 4c1f093d9dbb 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1efb868d740c874d071b97c1b14470f391f7d6e8
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/1/testReport/
Max. process+thread count 4904 (vs. ulimit of 30000)
modules C: hbase-common hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 18 '24 15:09 Apache-HBase

@Apache9 Could you please help review it again? Thanks very much 🙏

terrytlu avatar Apr 25 '25 12:04 terrytlu

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 19s master passed
+1 :green_heart: compile 4m 21s master passed
+1 :green_heart: checkstyle 0m 54s master passed
+1 :green_heart: spotbugs 2m 15s master passed
+1 :green_heart: spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 3s the patch passed
+1 :green_heart: compile 5m 46s the patch passed
+1 :green_heart: javac 5m 46s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 7s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: spotbugs 3m 52s the patch passed
+1 :green_heart: hadoopcheck 16m 15s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x: spotless 1m 10s patch has 33 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 23s The patch does not generate ASF License warnings.
56m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6260
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux f7c299c84f88 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f7c5fcaed012cbbbb9837f1100199b218085c3b5
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 26 '25 02:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 31s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 13s master passed
+1 :green_heart: compile 1m 8s master passed
+1 :green_heart: javadoc 0m 39s master passed
+1 :green_heart: shadedjars 5m 44s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 56s the patch passed
+1 :green_heart: compile 1m 8s the patch passed
+1 :green_heart: javac 1m 8s the patch passed
+1 :green_heart: javadoc 0m 38s the patch passed
+1 :green_heart: shadedjars 5m 41s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 38s hbase-hadoop-compat in the patch passed.
-1 :x: unit 218m 24s /patch-unit-hbase-server.txt hbase-server in the patch failed.
245m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6260
Optional Tests javac javadoc unit compile shadedjars
uname Linux f832f8c22c9f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f7c5fcaed012cbbbb9837f1100199b218085c3b5
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/3/testReport/
Max. process+thread count 5682 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 26 '25 06:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 21s Maven dependency ordering for branch
+1 :green_heart: mvninstall 6m 5s master passed
+1 :green_heart: compile 5m 24s master passed
+1 :green_heart: checkstyle 1m 18s master passed
+1 :green_heart: spotbugs 3m 15s master passed
+1 :green_heart: spotless 1m 16s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 5m 15s the patch passed
+1 :green_heart: compile 5m 12s the patch passed
+1 :green_heart: javac 5m 12s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 53s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: spotbugs 3m 31s the patch passed
+1 :green_heart: hadoopcheck 16m 37s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x: spotless 1m 18s patch has 33 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 42s The patch does not generate ASF License warnings.
62m 21s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6260
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 6a8bcac28881 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 90aed32bea04240831f0853f0aa701d4aea5c8ab
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 29 '25 00:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 41s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 17s master passed
+1 :green_heart: compile 1m 29s master passed
+1 :green_heart: javadoc 0m 54s master passed
+1 :green_heart: shadedjars 7m 30s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 36s the patch passed
+1 :green_heart: compile 1m 36s the patch passed
+1 :green_heart: javac 1m 36s the patch passed
+1 :green_heart: javadoc 0m 48s the patch passed
+1 :green_heart: shadedjars 7m 53s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 47s hbase-hadoop-compat in the patch passed.
-1 :x: unit 246m 44s /patch-unit-hbase-server.txt hbase-server in the patch failed.
282m 8s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6260
Optional Tests javac javadoc unit compile shadedjars
uname Linux 69ca85797242 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 90aed32bea04240831f0853f0aa701d4aea5c8ab
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/4/testReport/
Max. process+thread count 4837 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6260/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 29 '25 04:04 Apache-HBase