apache
HBASE-28691 Not allowed to disable hbase:replication
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | |
| _ master Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 3m 14s | master passed | |
| +1 :green_heart: | compile | 3m 3s | master passed | |
| +1 :green_heart: | checkstyle | 0m 36s | master passed | |
| +1 :green_heart: | spotbugs | 1m 34s | master passed | |
| +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 2m 57s | the patch passed | |
| +1 :green_heart: | compile | 3m 2s | the patch passed | |
| +1 :green_heart: | javac | 3m 2s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| +1 :green_heart: | checkstyle | 0m 35s | the patch passed | |
| +1 :green_heart: | spotbugs | 1m 40s | the patch passed | |
| +1 :green_heart: | hadoopcheck | 5m 40s | Patch does not cause any errors with Hadoop 3.3.6. | |
| +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | |
| 31m 40s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6038/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6038 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 515f0a3f789e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3fd9913b07175e12a427ed67ecd37b75a887abcd |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6038/1/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
For me, I can not imagine a scenario where we want to disable hbase:replication table but in general, there could be some corner cases where we want to disable hbase:replication table to do something, like fix table data, force cleanup all replication data, etc.
So maybe we could introduce a flag about whether we allow disable system tables? By default we do not allow disabling, but users could change this flag if they really want to do this.
Thanks.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 25s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ master Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 3m 9s | master passed | |
| +1 :green_heart: | compile | 0m 56s | master passed | |
| +1 :green_heart: | javadoc | 0m 27s | master passed | |
| +1 :green_heart: | shadedjars | 5m 44s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 2m 57s | the patch passed | |
| +1 :green_heart: | compile | 0m 55s | the patch passed | |
| +1 :green_heart: | javac | 0m 55s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed | |
| +1 :green_heart: | shadedjars | 6m 32s | patch has no errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| -1 :x: | unit | 215m 47s | /patch-unit-hbase-server.txt | hbase-server in the patch failed. |
| 242m 9s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6038/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6038 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux a04dd8110c76 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3fd9913b07175e12a427ed67ecd37b75a887abcd |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6038/1/testReport/ |
| Max. process+thread count | 4526 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6038/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
For me, I can not imagine a scenario where we want to disable hbase:replication table but in general, there could be some corner cases where we want to disable hbase:replication table to do something, like fix table data, force cleanup all replication data, etc.
So maybe we could introduce a flag about whether we allow disable system tables? By default we do not allow disabling, but users could change this flag if they really want to do this.
Thanks.
Thanks for reviewing. I will rewrite the code based on your good suggestions, this may take some time.