hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-28417 TestBlockingIPC.testBadPreambleHeader sometimes fails with…

Open Apache9 opened this issue 1 year ago • 9 comments

… broken pipe instead of bad auth

Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer

Apache9 avatar Mar 04 '24 15:03 Apache9

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 0s master passed
+1 :green_heart: compile 3m 4s master passed
+1 :green_heart: checkstyle 0m 48s master passed
+1 :green_heart: spotless 0m 43s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 7s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 46s the patch passed
+1 :green_heart: compile 2m 59s the patch passed
+1 :green_heart: javac 2m 59s the patch passed
-0 :warning: checkstyle 0m 34s hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 5m 6s Patch does not cause any errors with Hadoop 3.3.6.
+1 :green_heart: spotless 0m 40s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 23s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 19s The patch does not generate ASF License warnings.
32m 22s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 6391d35f47a2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 04 '24 16:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 2m 32s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 0s master passed
+1 :green_heart: compile 1m 10s master passed
+1 :green_heart: shadedjars 5m 28s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 44s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 46s the patch passed
+1 :green_heart: compile 1m 10s the patch passed
+1 :green_heart: javac 1m 10s the patch passed
+1 :green_heart: shadedjars 5m 30s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 40s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 30s hbase-client in the patch passed.
+1 :green_heart: unit 206m 2s hbase-server in the patch passed.
235m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests javac javadoc unit shadedjars compile
uname Linux 30c471eb9fc9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/testReport/
Max. process+thread count 4934 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 04 '24 19:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 29s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 12s master passed
+1 :green_heart: compile 1m 6s master passed
+1 :green_heart: shadedjars 5m 50s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 41s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 3s the patch passed
+1 :green_heart: compile 1m 6s the patch passed
+1 :green_heart: javac 1m 6s the patch passed
+1 :green_heart: shadedjars 5m 52s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 39s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 35s hbase-client in the patch passed.
+1 :green_heart: unit 218m 34s hbase-server in the patch passed.
246m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests javac javadoc unit shadedjars compile
uname Linux 01b54793f170 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/testReport/
Max. process+thread count 4498 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 04 '24 19:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 0s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 36s master passed
+1 :green_heart: compile 1m 1s master passed
+1 :green_heart: shadedjars 5m 10s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 42s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 29s the patch passed
+1 :green_heart: compile 1m 1s the patch passed
+1 :green_heart: javac 1m 1s the patch passed
+1 :green_heart: shadedjars 5m 2s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 41s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 16s hbase-client in the patch passed.
+1 :green_heart: unit 234m 25s hbase-server in the patch passed.
260m 34s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests javac javadoc unit shadedjars compile
uname Linux 77f1f4c5141f 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/testReport/
Max. process+thread count 4753 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 04 '24 19:03 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 23s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 20s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 45s master passed
+1 :green_heart: compile 2m 59s master passed
+1 :green_heart: checkstyle 0m 45s master passed
+1 :green_heart: spotless 0m 39s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 3s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 46s the patch passed
+1 :green_heart: compile 3m 2s the patch passed
+1 :green_heart: javac 3m 1s the patch passed
+1 :green_heart: checkstyle 0m 46s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 5m 3s Patch does not cause any errors with Hadoop 3.3.6.
-1 :x: spotless 0m 39s patch has 1 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 2m 20s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
31m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 8bd43830345c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 05 '24 04:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 45s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 56s master passed
+1 :green_heart: compile 1m 17s master passed
+1 :green_heart: shadedjars 5m 15s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 48s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 48s the patch passed
+1 :green_heart: compile 1m 16s the patch passed
+1 :green_heart: javac 1m 16s the patch passed
+1 :green_heart: shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 46s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 25s hbase-client in the patch passed.
+1 :green_heart: unit 216m 53s hbase-server in the patch passed.
244m 16s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests javac javadoc unit shadedjars compile
uname Linux da5164b2c547 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/testReport/
Max. process+thread count 5929 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 05 '24 07:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 10s master passed
+1 :green_heart: compile 1m 6s master passed
+1 :green_heart: shadedjars 5m 52s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 40s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 2s the patch passed
+1 :green_heart: compile 1m 6s the patch passed
+1 :green_heart: javac 1m 6s the patch passed
+1 :green_heart: shadedjars 5m 53s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 40s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 35s hbase-client in the patch passed.
+1 :green_heart: unit 218m 13s hbase-server in the patch passed.
246m 7s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests javac javadoc unit shadedjars compile
uname Linux fc3e472f289c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/testReport/
Max. process+thread count 5175 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 05 '24 07:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 40s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 25s master passed
+1 :green_heart: compile 1m 1s master passed
+1 :green_heart: shadedjars 5m 10s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 41s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 29s the patch passed
+1 :green_heart: compile 1m 0s the patch passed
+1 :green_heart: javac 1m 0s the patch passed
+1 :green_heart: shadedjars 5m 6s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 41s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 17s hbase-client in the patch passed.
+1 :green_heart: unit 233m 47s hbase-server in the patch passed.
259m 24s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5740
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9a2abddf97e4 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd2dc
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/testReport/
Max. process+thread count 4765 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5740/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 05 '24 07:03 Apache-HBase

I think you can improve the test further by getting rid of shared state in the base class. But more/better coverage looks good. Do the additional permutations result in a longer test time? Does the MediumTest annotation need tweaked as well?

The tests runs pretty fast, as it does not need to setup a mini cluster, just start some socket servers.

On my local machine, the TestNettyIPC can be finished within 15 seconds.

Apache9 avatar Mar 05 '24 09:03 Apache9