Backport "HBASE-20693 Refactor thrift jsp's and extract header and fo…

[NihalJain]

…oter (#5732)" and "HBASE-18382 add transport type info into Thrift UI (#880)" to branch-2

[NihalJain]

#5732 did not apply cleanly to branch-2 as HBASE-18382 is missing there.

For now raised a backport for the same with this PR. Just copied the 3 files from branch-3 and overwrote on branch-2.

Verified the UI loads as expected:

Let me know if i should:

• avoid backporting HBASE-18382 altogether?
• raise HBASE-18382 as another PR, and not mix with this?
• Or are we good this way?

What are your thoughts @ndimiduk ?

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 :green_heart:	dupname	0m 0s	No case conflicting files found.
+1 :green_heart:	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 :green_heart:	mvninstall	2m 59s	branch-2 passed
+1 :green_heart:	spotless	0m 46s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 52s	the patch passed
+1 :green_heart:	whitespace	0m 0s	The patch has no whitespace issues.
+1 :green_heart:	spotless	0m 43s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 :green_heart:	asflicense	0m 12s	The patch does not generate ASF License warnings.
		9m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/5737
Optional Tests	dupname asflicense javac spotless
uname	Linux f17265566f60 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / b07326b6c3
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	0m 45s	Docker mode activated.
-0 :warning:	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 :green_heart:	mvninstall	3m 9s	branch-2 passed
+1 :green_heart:	javadoc	0m 27s	branch-2 passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 50s	the patch passed
+1 :green_heart:	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	6m 49s	hbase-thrift in the patch passed.
		15m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/5737
Optional Tests	javac javadoc unit
uname	Linux 71807293ed43 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / b07326b6c3
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/testReport/
Max. process+thread count	1363 (vs. ulimit of 30000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	0m 48s	Docker mode activated.
-0 :warning:	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 :green_heart:	mvninstall	3m 22s	branch-2 passed
+1 :green_heart:	javadoc	0m 30s	branch-2 passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 55s	the patch passed
+1 :green_heart:	javadoc	0m 28s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	6m 42s	hbase-thrift in the patch passed.
		15m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/5737
Optional Tests	javac javadoc unit
uname	Linux 72e94001cffa 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / b07326b6c3
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/testReport/
Max. process+thread count	1451 (vs. ulimit of 30000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5737/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[ndimiduk]

My preference is to re-open for backport any missing dependencies -- if possible. Sometimes that doesn't go smoothly. In this case, I think it's fine to backport HBASE-18382 before proceeding with 20693.