hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic…

Open NihalJain opened this issue 1 year ago • 7 comments

…ation mechanism (Web UI only)" to branch-2 Co-authored-by: Yash Dodeja [email protected]

NihalJain avatar Feb 14 '24 12:02 NihalJain

Backports #5144 / #5213

NihalJain avatar Feb 14 '24 12:02 NihalJain

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 39s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 28s branch-2 passed
+1 :green_heart: compile 1m 43s branch-2 passed
+1 :green_heart: shadedjars 4m 42s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 45s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 17s the patch passed
+1 :green_heart: compile 1m 40s the patch passed
+1 :green_heart: javac 1m 40s the patch passed
+1 :green_heart: shadedjars 4m 37s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 43s the patch passed
_ Other Tests _
-1 :x: unit 12m 34s root in the patch failed.
36m 30s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5680
Optional Tests javac javadoc unit shadedjars compile
uname Linux 68f01a2cbbc9 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c51f0f6325
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/testReport/
Max. process+thread count 952 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Feb 14 '24 13:02 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 59s branch-2 passed
+1 :green_heart: compile 4m 50s branch-2 passed
+1 :green_heart: checkstyle 1m 7s branch-2 passed
+1 :green_heart: spotless 0m 41s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 7m 17s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 23s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 44s the patch passed
+1 :green_heart: compile 4m 48s the patch passed
-0 :warning: javac 4m 48s root generated 2 new + 1075 unchanged - 0 fixed = 1077 total (was 1075)
-0 :warning: checkstyle 1m 8s root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 2s The patch has no ill-formed XML file.
+1 :green_heart: hadoopcheck 9m 13s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 :green_heart: spotless 0m 38s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 7m 37s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
46m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5680
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname Linux c71ca3aa6e73 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c51f0f6325
Default Java Eclipse Adoptium-11.0.17+8
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
Max. process+thread count 178 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Feb 14 '24 13:02 Apache-HBase

The test TestLogLevel fails for hadoop-2, but passes for hadoop-3. Will analyse and fix with next commit.

NihalJain avatar Feb 14 '24 15:02 NihalJain

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 43s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 21s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 19s branch-2 passed
+1 :green_heart: compile 2m 6s branch-2 passed
+1 :green_heart: shadedjars 5m 53s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 0s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 17s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 53s the patch passed
+1 :green_heart: compile 2m 0s the patch passed
+1 :green_heart: javac 2m 0s the patch passed
+1 :green_heart: shadedjars 5m 52s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 58s the patch passed
_ Other Tests _
-1 :x: unit 228m 30s root in the patch failed.
260m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5680
Optional Tests javac javadoc unit shadedjars compile
uname Linux 84144b4d1ff6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c51f0f6325
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/testReport/
Max. process+thread count 5006 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Feb 14 '24 17:02 Apache-HBase

The failure for jdk8 hadoop2 is related?

Apache9 avatar Feb 18 '24 10:02 Apache9

Yes I have checked the test failures are related. There's more changes needed for hadoop2. In hadoop 2 the version of directory services used is different from what we are importing for hadoop 3 and both versions have somewhat incompatible changes. I will submit a fix to make test run for both.

NihalJain avatar Feb 18 '24 11:02 NihalJain