hbase icon indicating copy to clipboard operation
hbase copied to clipboard
verified publisher icon apache

HBASE-28220 Split the queueCallTime, processCallTime and totalCallTime according to queue type when using RWQueueRpcExecutor

Open rankocloud opened this issue 2 years ago • 3 comments

When using RWQueueRpcExecutor, in order to monitor the running status of the read and write queues separately, it is necessary to monitor the queueTime and processingTime of the request according to the queue type. In this way, the queue's queueCallTime, processCallTime and totalCallTime metrics are split according to the read and write queue types. So Add the following metrics：

  1. queueReadCallTime
  2. processReadCallTime
  3. totalReadCallTime
  4. queueWriteCallTime
  5. processWriteCallTime
  6. totalWriteCallTime
  7. queueScanCallTime
  8. processScanCallTime
  9. totalScanCallTime

These metrics are important references for subsequent modification of parameters hbase.ipc.server.callqueue.read.ratio and hbase.ipc.server.callqueue.scan.ratio.

rankocloud avatar Nov 29 '23 10:11 rankocloud

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 10s master passed
+1 :green_heart: compile 2m 53s master passed
+1 :green_heart: checkstyle 0m 43s master passed
+1 :green_heart: spotless 0m 46s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 57s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 58s the patch passed
+1 :green_heart: compile 2m 52s the patch passed
+1 :green_heart: javac 2m 52s the patch passed
+1 :green_heart: checkstyle 0m 41s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 10m 50s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 :green_heart: spotless 0m 43s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 10s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
37m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5550
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 248a6b49f88b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4d90b918a3
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Nov 29 '23 10:11 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 24s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 31s master passed
+1 :green_heart: compile 0m 46s master passed
+1 :green_heart: shadedjars 5m 10s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 31s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 20s the patch passed
+1 :green_heart: compile 0m 47s the patch passed
+1 :green_heart: javac 0m 47s the patch passed
+1 :green_heart: shadedjars 5m 8s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 31s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 32s hbase-hadoop-compat in the patch passed.
+1 :green_heart: unit 223m 47s hbase-server in the patch passed.
247m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5da11a7f20a6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4d90b918a3
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/testReport/
Max. process+thread count 4622 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Nov 29 '23 14:11 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 34s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 52s master passed
+1 :green_heart: compile 1m 2s master passed
+1 :green_heart: shadedjars 4m 54s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 37s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 42s the patch passed
+1 :green_heart: compile 1m 1s the patch passed
+1 :green_heart: javac 1m 1s the patch passed
+1 :green_heart: shadedjars 4m 49s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 39s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 44s hbase-hadoop-compat in the patch passed.
-1 :x: unit 308m 15s hbase-server in the patch failed.
334m 17s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5550
Optional Tests javac javadoc unit shadedjars compile
uname Linux c79068be9b00 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4d90b918a3
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/testReport/
Max. process+thread count 4728 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5550/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Nov 29 '23 15:11 Apache-HBase