hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27016 when “zookeeper.session.timeout” is set to a negative number, HMaster cannot stop normally

Open MEILIDEKCL opened this issue 2 years ago • 4 comments

[https://issues.apache.org/jira/browse/HBASE-27016]

fix bug for local mode.

MEILIDEKCL avatar Sep 20 '23 08:09 MEILIDEKCL

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 49s master passed
+1 :green_heart: compile 2m 27s master passed
+1 :green_heart: checkstyle 0m 36s master passed
+1 :green_heart: spotless 0m 44s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 32s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 33s the patch passed
+1 :green_heart: compile 2m 24s the patch passed
+1 :green_heart: javac 2m 24s the patch passed
+1 :green_heart: checkstyle 0m 35s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 10m 2s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
-1 :x: spotless 0m 40s patch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 1m 52s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
34m 2s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5414
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 1a2756e60f8d 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8b2ca86d50
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 20 '23 09:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 5s master passed
+1 :green_heart: compile 0m 46s master passed
+1 :green_heart: shadedjars 5m 27s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 25s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 43s the patch passed
+1 :green_heart: compile 0m 47s the patch passed
+1 :green_heart: javac 0m 47s the patch passed
+1 :green_heart: shadedjars 5m 24s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 23s the patch passed
_ Other Tests _
+1 :green_heart: unit 217m 2s hbase-server in the patch passed.
240m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5414
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0b9ec57ab6ac 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8b2ca86d50
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/testReport/
Max. process+thread count 4668 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 20 '23 12:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 31s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 37s master passed
+1 :green_heart: compile 0m 38s master passed
+1 :green_heart: shadedjars 5m 15s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 24s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 17s the patch passed
+1 :green_heart: compile 0m 36s the patch passed
+1 :green_heart: javac 0m 36s the patch passed
+1 :green_heart: shadedjars 5m 14s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 25s the patch passed
_ Other Tests _
-1 :x: unit 267m 7s hbase-server in the patch failed.
289m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5414
Optional Tests javac javadoc unit shadedjars compile
uname Linux dd1ac8e2480f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8b2ca86d50
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/testReport/
Max. process+thread count 4591 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5414/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 20 '23 13:09 Apache-HBase

Checking the log message in the jira descrption, seems the exception is thrown from ZNodeClearer? But here we add a check in startMaster?

So, would you suggest to add check in ZNodeClearer?

MEILIDEKCL avatar Oct 10 '23 07:10 MEILIDEKCL