hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-28091 Too long namespace/table/column name cause CreateTableProcedure stuck

Open guluo2016 opened this issue 2 years ago • 4 comments

Details see: HBASE-28091

guluo2016 avatar Sep 18 '23 16:09 guluo2016

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 43s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 45s master passed
+1 :green_heart: compile 3m 11s master passed
+1 :green_heart: checkstyle 0m 58s master passed
+1 :green_heart: spotless 1m 2s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 55s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 18s the patch passed
+1 :green_heart: compile 2m 58s the patch passed
+1 :green_heart: javac 2m 58s the patch passed
+1 :green_heart: checkstyle 0m 46s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 13m 44s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 :green_heart: spotless 1m 4s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 31s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 22s The patch does not generate ASF License warnings.
44m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5410
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 57441501f520 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef7b85409a
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 82 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 18 '23 17:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 33s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 53s master passed
+1 :green_heart: compile 0m 48s master passed
+1 :green_heart: shadedjars 4m 44s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 28s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 38s the patch passed
+1 :green_heart: compile 0m 47s the patch passed
+1 :green_heart: javac 0m 47s the patch passed
+1 :green_heart: shadedjars 4m 40s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 26s the patch passed
_ Other Tests _
+1 :green_heart: unit 226m 29s hbase-server in the patch passed.
248m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5410
Optional Tests javac javadoc unit shadedjars compile
uname Linux ea2894a61e5f 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef7b85409a
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/testReport/
Max. process+thread count 4599 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 18 '23 20:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 41s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 42s master passed
+1 :green_heart: compile 0m 55s master passed
+1 :green_heart: shadedjars 5m 52s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 32s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 8s the patch passed
+1 :green_heart: compile 1m 2s the patch passed
+1 :green_heart: javac 1m 2s the patch passed
+1 :green_heart: shadedjars 6m 27s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 31s the patch passed
_ Other Tests _
+1 :green_heart: unit 238m 18s hbase-server in the patch passed.
265m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5410
Optional Tests javac javadoc unit shadedjars compile
uname Linux fb931ec2faad 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef7b85409a
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/testReport/
Max. process+thread count 4177 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5410/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 18 '23 20:09 Apache-HBase

I prefer we catch the exception and check whether this is a file name length limit and then fail the procedure with DoNotRetryIOException. Of course there may be a problem that when we try to create the file on namenode, we have already passed the SPOF so the procedure can not fail, if this is the case, I think we need to do some refactoring...

Apache9 avatar Sep 18 '23 23:09 Apache9