hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-26974 Introduce a LogRollProcedure

Open frostruan opened this issue 2 years ago • 18 comments

This PR tries to reimplement the log-roll procedure with proc-v2.

Modifies the following things

client side:

when request all rs to roll WAL writers, instead of calling admin.execProcedure(), now we call admin.execProcedureWithReturn and the returned value depends on the configuration in the server side. If master is configured to used proc-v2, the value would be the procedure id, otherwise nothing. Then we will keep asking master if the procedure has finished by calling admin.isProcedureFinished until it finished or failed or timeout. This was implemented in BackupUtils#rollWALWriters.

server side

  1. enhanced LogRollMasterProcedureManager to support both proc-v1 and proc-v2

  2. introduce 3 new procedures.

LogRollProcedure The LogRollProcedure is used to roll WAL for all rs in the cluster. It does not acquire any lock and It has 3 states: LOG_ROLL_PRE_CHECK_NAMESPACE : create backup namespace if not exists LOG_ROLL_PRE_CHECK_TABLES : create backup system table and backup system bulkload table if not exists LOG_ROLL_ROLL_LOG_ON_EACH_RS : roll all rs WAL writers

RSLogRollProcedure The RSLogRollProcedure is used to schedule a RSLogRollRemoteProcedure for each regionserver. When the subprocedure returns, the RSLogRollProcedure will check the logrolling result in the backup system table. If failed, The RSLogRollProcedure will schedule a new RSLogRollRemoteProcedure to retry.

RSLogRollRemoteProcedure The RSLogRollRemoteProcedure is used to send the log roll request to the remote server.

any suggestions and feedbacks are appreciated.

frostruan avatar Sep 17 '23 03:09 frostruan

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 46s master passed
+1 :green_heart: compile 3m 25s master passed
+1 :green_heart: checkstyle 0m 52s master passed
+1 :green_heart: spotless 0m 43s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 4m 13s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 32s the patch passed
+1 :green_heart: compile 3m 25s the patch passed
+1 :green_heart: cc 3m 25s the patch passed
+1 :green_heart: javac 3m 25s the patch passed
+1 :green_heart: checkstyle 0m 50s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 8s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 :green_heart: hbaseprotoc 1m 20s the patch passed
+1 :green_heart: spotless 0m 41s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 4m 34s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 30s The patch does not generate ASF License warnings.
42m 2s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 049a9610b848 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a80b341b6e
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 17 '23 04:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 1s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 55s master passed
+1 :green_heart: compile 1m 46s master passed
+1 :green_heart: shadedjars 4m 51s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 50s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 15s the patch passed
+1 :green_heart: compile 1m 26s the patch passed
+1 :green_heart: javac 1m 26s the patch passed
+1 :green_heart: shadedjars 4m 33s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 47s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 31s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 229m 54s hbase-server in the patch passed.
-1 :x: unit 31m 42s hbase-backup in the patch failed.
288m 21s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests javac javadoc unit shadedjars compile
uname Linux f8b8a66455ae 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a80b341b6e
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-backup.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/testReport/
Max. process+thread count 4382 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 17 '23 08:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 43s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 57s master passed
+1 :green_heart: compile 2m 13s master passed
+1 :green_heart: shadedjars 6m 54s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 11s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 5s the patch passed
+1 :green_heart: compile 2m 40s the patch passed
+1 :green_heart: javac 2m 40s the patch passed
+1 :green_heart: shadedjars 7m 10s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 7s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 56s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 308m 20s hbase-server in the patch passed.
-1 :x: unit 28m 46s hbase-backup in the patch failed.
373m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests javac javadoc unit shadedjars compile
uname Linux e3d37c0aca3f 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a80b341b6e
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/testReport/
Max. process+thread count 4616 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 17 '23 10:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 29s master passed
+1 :green_heart: compile 4m 11s master passed
+1 :green_heart: checkstyle 0m 55s master passed
+1 :green_heart: spotless 0m 44s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 4m 21s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 35s the patch passed
+1 :green_heart: compile 3m 26s the patch passed
+1 :green_heart: cc 3m 26s the patch passed
+1 :green_heart: javac 3m 26s the patch passed
+1 :green_heart: checkstyle 0m 51s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 7s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 :green_heart: hbaseprotoc 1m 22s the patch passed
+1 :green_heart: spotless 0m 41s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 4m 35s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 29s The patch does not generate ASF License warnings.
44m 8s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 4cabe1800b50 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef7b85409a
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 17 '23 17:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 29s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 50s master passed
+1 :green_heart: compile 1m 42s master passed
+1 :green_heart: shadedjars 4m 35s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 50s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 37s the patch passed
+1 :green_heart: compile 1m 43s the patch passed
+1 :green_heart: javac 1m 43s the patch passed
+1 :green_heart: shadedjars 4m 35s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 49s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 40s hbase-protocol-shaded in the patch passed.
-1 :x: unit 239m 53s hbase-server in the patch failed.
+1 :green_heart: unit 10m 34s hbase-backup in the patch passed.
276m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests javac javadoc unit shadedjars compile
uname Linux a929d6c05a06 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef7b85409a
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/testReport/
Max. process+thread count 4458 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 17 '23 21:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 42s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 28s master passed
+1 :green_heart: compile 1m 26s master passed
+1 :green_heart: shadedjars 4m 32s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 47s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 19s the patch passed
+1 :green_heart: compile 1m 25s the patch passed
+1 :green_heart: javac 1m 25s the patch passed
+1 :green_heart: shadedjars 4m 31s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 47s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 31s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 250m 1s hbase-server in the patch passed.
+1 :green_heart: unit 10m 56s hbase-backup in the patch passed.
286m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests javac javadoc unit shadedjars compile
uname Linux 26ff57ab4d1f 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef7b85409a
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/testReport/
Max. process+thread count 4464 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 17 '23 21:09 Apache-HBase

The failed UT looks not related.

frostruan avatar Sep 18 '23 02:09 frostruan

Hi Duo, would you mind taking a look in your free time ? This is the last zk-based procedure, also the last sub-task of HBASE-21488 , I'd like to help promote this a bit @Apache9

frostruan avatar Sep 24 '23 14:09 frostruan

Hi Duo, would you mind taking a look in your free time ? This is the last zk-based procedure, also the last sub-task of HBASE-21488 , I'd like to help promote this a bit @Apache9

The PR is big, I have already started to review it few days ago but haven't finished yet...

Apache9 avatar Sep 24 '23 14:09 Apache9

Hi Duo, would you mind taking a look in your free time ? This is the last zk-based procedure, also the last sub-task of HBASE-21488 , I'd like to help promote this a bit @Apache9

The PR is big, I have already started to review it few days ago but haven't finished yet...

Thanks for the review !

I briefly wrote down the main changes in the begin of the PR, I hope that could help review :)

frostruan avatar Sep 24 '23 14:09 frostruan

Any updates here?

Thanks.

Apache9 avatar Apr 17 '24 07:04 Apache9

Will push the newest code as soon as possible.

Thanks Duo !

frostruan avatar Apr 17 '24 07:04 frostruan

A new commit has been added. Let's wait for the UT result.

frostruan avatar Apr 18 '24 13:04 frostruan

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: prototool 0m 1s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for branch
+1 :green_heart: mvninstall 5m 16s master passed
+1 :green_heart: compile 6m 11s master passed
+1 :green_heart: checkstyle 1m 21s master passed
+1 :green_heart: spotless 1m 11s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 6m 55s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 36s the patch passed
+1 :green_heart: compile 5m 46s the patch passed
+1 :green_heart: cc 5m 46s the patch passed
+1 :green_heart: javac 5m 46s the patch passed
+1 :green_heart: checkstyle 1m 21s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 7m 44s Patch does not cause any errors with Hadoop 3.3.6.
+1 :green_heart: hbaseprotoc 2m 29s the patch passed
+1 :green_heart: spotless 1m 14s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 7m 58s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 38s The patch does not generate ASF License warnings.
63m 58s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux bbfe54809345 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a34b4bc517
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 18 '24 14:04 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 13s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 54s master passed
+1 :green_heart: compile 1m 51s master passed
+1 :green_heart: shadedjars 5m 12s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 53s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 49s the patch passed
+1 :green_heart: compile 1m 51s the patch passed
+1 :green_heart: javac 1m 51s the patch passed
+1 :green_heart: shadedjars 5m 14s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 52s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 36s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 212m 1s hbase-server in the patch passed.
+1 :green_heart: unit 10m 57s hbase-backup in the patch passed.
250m 40s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests javac javadoc unit shadedjars compile
uname Linux b74dfd0c6628 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a34b4bc517
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/testReport/
Max. process+thread count 5448 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 18 '24 18:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 44s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 59s master passed
+1 :green_heart: compile 1m 49s master passed
+1 :green_heart: shadedjars 5m 55s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 47s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 39s the patch passed
+1 :green_heart: compile 1m 36s the patch passed
+1 :green_heart: javac 1m 36s the patch passed
+1 :green_heart: shadedjars 5m 48s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 49s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 33s hbase-protocol-shaded in the patch passed.
-1 :x: unit 278m 41s hbase-server in the patch failed.
+1 :green_heart: unit 13m 9s hbase-backup in the patch passed.
320m 33s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests javac javadoc unit shadedjars compile
uname Linux 23afa7d56869 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a34b4bc517
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/testReport/
Max. process+thread count 5803 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 18 '24 19:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 20s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 10s master passed
+1 :green_heart: compile 2m 49s master passed
+1 :green_heart: shadedjars 8m 29s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 18s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 47s the patch passed
+1 :green_heart: compile 2m 47s the patch passed
+1 :green_heart: javac 2m 47s the patch passed
+1 :green_heart: shadedjars 8m 32s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 31s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 12s hbase-protocol-shaded in the patch passed.
-1 :x: unit 319m 50s hbase-server in the patch failed.
+1 :green_heart: unit 11m 30s hbase-backup in the patch passed.
372m 53s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5408
Optional Tests javac javadoc unit shadedjars compile
uname Linux d70cafd57dd3 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a34b4bc517
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/testReport/
Max. process+thread count 4858 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 18 '24 20:04 Apache-HBase

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.0:test (secondPartTestsExecution) on project hbase-server: There was a timeout in the fork -> [Help 1]

The failed UT looks not related.

frostruan avatar Apr 19 '24 04:04 frostruan