hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27861 Increases the concurrency of off-peak compactions

Open ZhangIssac opened this issue 2 years ago • 6 comments

ZhangIssac avatar Aug 23 '23 14:08 ZhangIssac

@Apache9 Can you help me review this

ZhangIssac avatar Aug 23 '23 14:08 ZhangIssac

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+1 :green_heart: mvninstall 3m 32s branch-2.5 passed
+1 :green_heart: compile 2m 35s branch-2.5 passed
+1 :green_heart: checkstyle 0m 34s branch-2.5 passed
+1 :green_heart: spotless 0m 41s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 26s branch-2.5 passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 29s the patch passed
+1 :green_heart: compile 2m 20s the patch passed
+1 :green_heart: javac 2m 20s the patch passed
-0 :warning: checkstyle 0m 33s hbase-server: The patch generated 7 new + 4 unchanged - 0 fixed = 11 total (was 4)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 13m 18s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
-1 :x: spotless 0m 18s patch has 27 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 1m 30s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 11s The patch does not generate ASF License warnings.
32m 8s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5368
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 40b603358e98 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 110aa4b753
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '23 15:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 44s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 :green_heart: mvninstall 3m 6s branch-2.5 passed
+1 :green_heart: compile 0m 45s branch-2.5 passed
+1 :green_heart: shadedjars 5m 19s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 25s branch-2.5 passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 43s the patch passed
+1 :green_heart: compile 0m 45s the patch passed
+1 :green_heart: javac 0m 45s the patch passed
+1 :green_heart: shadedjars 5m 13s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 23s the patch passed
_ Other Tests _
+1 :green_heart: unit 196m 37s hbase-server in the patch passed.
219m 58s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5368
Optional Tests javac javadoc unit shadedjars compile
uname Linux 664c27bb1b03 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 110aa4b753
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/testReport/
Max. process+thread count 4764 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '23 18:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 37s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 :green_heart: mvninstall 2m 18s branch-2.5 passed
+1 :green_heart: compile 0m 38s branch-2.5 passed
+1 :green_heart: shadedjars 4m 15s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 25s branch-2.5 passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 8s the patch passed
+1 :green_heart: compile 0m 39s the patch passed
+1 :green_heart: javac 0m 39s the patch passed
+1 :green_heart: shadedjars 4m 13s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 23s the patch passed
_ Other Tests _
+1 :green_heart: unit 201m 35s hbase-server in the patch passed.
221m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5368
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9fb7b6bfec66 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 110aa4b753
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/testReport/
Max. process+thread count 4333 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5368/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '23 18:08 Apache-HBase

@Apache9 hi, could you review code and provide some suggestions if you are available? Thanks!

ZhangIssac avatar Sep 25 '23 03:09 ZhangIssac

Will take a look soon when I have time.

Sorry~

Apache9 avatar Sep 25 '23 05:09 Apache9