hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27968 add JvmPauseMonitor in hbase-client

Open frostruan opened this issue 2 years ago • 14 comments

frostruan avatar Jul 09 '23 11:07 frostruan

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 2m 11s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 44s master passed
+1 :green_heart: compile 2m 57s master passed
+1 :green_heart: checkstyle 0m 45s master passed
+1 :green_heart: spotless 0m 40s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 59s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 30s the patch passed
+1 :green_heart: compile 2m 55s the patch passed
+1 :green_heart: javac 2m 55s the patch passed
-0 :warning: checkstyle 0m 12s hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: checkstyle 0m 32s hbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 14s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 :green_heart: spotless 0m 39s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 15s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 15s The patch does not generate ASF License warnings.
36m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 445363fe780f 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe64b
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 09 '23 12:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 2s master passed
+1 :green_heart: compile 1m 2s master passed
+1 :green_heart: shadedjars 5m 12s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 38s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 42s the patch passed
+1 :green_heart: compile 1m 3s the patch passed
+1 :green_heart: javac 1m 3s the patch passed
+1 :green_heart: shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 37s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 32s hbase-client in the patch passed.
+1 :green_heart: unit 212m 18s hbase-server in the patch passed.
238m 33s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux de1dde7c5233 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe64b
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/testReport/
Max. process+thread count 4709 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 09 '23 15:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 35s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 22s master passed
+1 :green_heart: compile 0m 59s master passed
+1 :green_heart: shadedjars 4m 31s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 40s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 15s the patch passed
+1 :green_heart: compile 0m 58s the patch passed
+1 :green_heart: javac 0m 58s the patch passed
+1 :green_heart: shadedjars 4m 31s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 39s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 15s hbase-client in the patch passed.
+1 :green_heart: unit 225m 21s hbase-server in the patch passed.
249m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux ac88396757ae 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe64b
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/testReport/
Max. process+thread count 4200 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 09 '23 15:07 Apache-HBase

Thanks for the review @wchevreuil

Sorry, I didn't find the ConnectionImplementation class in the master branch. If you mean the synchronous connection, then I think the synchronous connection is implemented based on asynchronous connection, so maybe only for asynchronous connection is enough ?

frostruan avatar Jul 10 '23 12:07 frostruan

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 24s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 48s master passed
+1 :green_heart: compile 4m 17s master passed
+1 :green_heart: checkstyle 1m 46s master passed
+1 :green_heart: spotless 0m 53s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 4m 12s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 41s the patch passed
+1 :green_heart: compile 3m 54s the patch passed
+1 :green_heart: javac 3m 54s the patch passed
-0 :warning: checkstyle 0m 13s hbase-client: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: checkstyle 0m 32s hbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
+1 :green_heart: checkstyle 0m 29s The patch passed checkstyle in hbase-thrift
+1 :green_heart: checkstyle 0m 8s The patch passed checkstyle in hbase-rest
+1 :green_heart: whitespace 0m 1s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 26s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 :green_heart: spotless 0m 39s patch has no errors when running spotless:check.
-1 :x: spotbugs 0m 47s hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 :green_heart: asflicense 0m 29s The patch does not generate ASF License warnings.
43m 31s
Reason Tests
FindBugs module:hbase-client
Public static org.apache.hadoop.hbase.util.JvmPauseMonitor.getInstance(Configuration, JvmPauseMonitorSource) may expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:[line 86]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 17c11f8c1de1 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe64b
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 10 '23 17:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 29s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 3s master passed
+1 :green_heart: compile 1m 38s master passed
+1 :green_heart: shadedjars 5m 10s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 18s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 44s the patch passed
+1 :green_heart: compile 1m 38s the patch passed
+1 :green_heart: javac 1m 38s the patch passed
+1 :green_heart: shadedjars 5m 8s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 16s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 31s hbase-client in the patch passed.
+1 :green_heart: unit 214m 43s hbase-server in the patch passed.
+1 :green_heart: unit 5m 4s hbase-thrift in the patch passed.
+1 :green_heart: unit 3m 48s hbase-rest in the patch passed.
252m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4320aa914a04 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe64b
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/testReport/
Max. process+thread count 4676 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 10 '23 21:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 37s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 7s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 20s master passed
+1 :green_heart: compile 1m 35s master passed
+1 :green_heart: shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 14s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 15s the patch passed
+1 :green_heart: compile 1m 35s the patch passed
+1 :green_heart: javac 1m 35s the patch passed
+1 :green_heart: shadedjars 4m 33s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 13s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 15s hbase-client in the patch passed.
+1 :green_heart: unit 224m 17s hbase-server in the patch passed.
+1 :green_heart: unit 5m 15s hbase-thrift in the patch passed.
+1 :green_heart: unit 3m 32s hbase-rest in the patch passed.
259m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux 10841dec31ff 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe64b
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/testReport/
Max. process+thread count 4121 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 10 '23 21:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 24s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 29s master passed
+1 :green_heart: compile 3m 55s master passed
+1 :green_heart: checkstyle 1m 23s master passed
+1 :green_heart: spotless 0m 39s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 3m 18s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 31s the patch passed
+1 :green_heart: compile 3m 56s the patch passed
+1 :green_heart: javac 3m 56s the patch passed
+1 :green_heart: checkstyle 0m 13s The patch passed checkstyle in hbase-client
+1 :green_heart: checkstyle 0m 33s hbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
+1 :green_heart: checkstyle 0m 29s The patch passed checkstyle in hbase-thrift
+1 :green_heart: checkstyle 0m 7s The patch passed checkstyle in hbase-rest
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 20s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 :green_heart: spotless 0m 38s patch has no errors when running spotless:check.
-1 :x: spotbugs 0m 48s hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 :green_heart: asflicense 0m 28s The patch does not generate ASF License warnings.
41m 19s
Reason Tests
FindBugs module:hbase-client
Public static org.apache.hadoop.hbase.util.JvmPauseMonitor.getInstance(Configuration, JvmPauseMonitorSource) may expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:[line 86]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 4cc3dac8c225 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d704a79ab
Default Java Eclipse Adoptium-11.0.17+8
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 11 '23 17:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 42s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 41s master passed
+1 :green_heart: compile 1m 44s master passed
+1 :green_heart: shadedjars 5m 19s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 23s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 35s the patch passed
+1 :green_heart: compile 1m 55s the patch passed
+1 :green_heart: javac 1m 55s the patch passed
+1 :green_heart: shadedjars 5m 8s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 15s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 22s hbase-client in the patch passed.
-1 :x: unit 245m 5s hbase-server in the patch failed.
+1 :green_heart: unit 5m 13s hbase-thrift in the patch passed.
+1 :green_heart: unit 3m 29s hbase-rest in the patch passed.
283m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4307b81b297e 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d704a79ab
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/testReport/
Max. process+thread count 4130 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 11 '23 21:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 35s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 16s master passed
+1 :green_heart: compile 2m 3s master passed
+1 :green_heart: shadedjars 6m 0s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 28s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 29s the patch passed
+1 :green_heart: compile 2m 5s the patch passed
+1 :green_heart: javac 2m 5s the patch passed
+1 :green_heart: shadedjars 6m 5s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 37s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 49s hbase-client in the patch passed.
-1 :x: unit 253m 2s hbase-server in the patch failed.
+1 :green_heart: unit 5m 33s hbase-thrift in the patch passed.
+1 :green_heart: unit 3m 48s hbase-rest in the patch passed.
296m 24s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux b67891896a02 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d704a79ab
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/testReport/
Max. process+thread count 4681 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 11 '23 21:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 24s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 35s master passed
+1 :green_heart: compile 3m 55s master passed
+1 :green_heart: checkstyle 1m 24s master passed
+1 :green_heart: spotless 0m 39s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 3m 15s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 29s the patch passed
+1 :green_heart: compile 3m 56s the patch passed
+1 :green_heart: javac 3m 56s the patch passed
+1 :green_heart: checkstyle 0m 13s The patch passed checkstyle in hbase-client
+1 :green_heart: checkstyle 0m 33s hbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
+1 :green_heart: checkstyle 0m 29s The patch passed checkstyle in hbase-thrift
+1 :green_heart: checkstyle 0m 8s The patch passed checkstyle in hbase-rest
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 13s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 :green_heart: spotless 0m 44s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 4m 41s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 28s The patch does not generate ASF License warnings.
42m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 6a016f6b7d33 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d704a79ab
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 12 '23 12:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 32s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 27s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 58s master passed
+1 :green_heart: compile 1m 37s master passed
+1 :green_heart: shadedjars 5m 8s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 16s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 45s the patch passed
+1 :green_heart: compile 1m 38s the patch passed
+1 :green_heart: javac 1m 38s the patch passed
+1 :green_heart: shadedjars 5m 7s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 17s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 32s hbase-client in the patch passed.
+1 :green_heart: unit 239m 49s hbase-server in the patch passed.
+1 :green_heart: unit 6m 6s hbase-thrift in the patch passed.
+1 :green_heart: unit 4m 28s hbase-rest in the patch passed.
279m 33s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3bc1273dae6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d704a79ab
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/testReport/
Max. process+thread count 4698 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 12 '23 16:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 38s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 49s master passed
+1 :green_heart: compile 1m 58s master passed
+1 :green_heart: shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 27s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 0s the patch passed
+1 :green_heart: compile 1m 58s the patch passed
+1 :green_heart: javac 1m 58s the patch passed
+1 :green_heart: shadedjars 5m 33s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 26s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 32s hbase-client in the patch passed.
-1 :x: unit 262m 54s hbase-server in the patch failed.
+1 :green_heart: unit 5m 30s hbase-thrift in the patch passed.
+1 :green_heart: unit 5m 13s hbase-rest in the patch passed.
304m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5319
Optional Tests javac javadoc unit shadedjars compile
uname Linux fe8b8247fe0c 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d704a79ab
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/testReport/
Max. process+thread count 4115 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 12 '23 16:07 Apache-HBase

Thanks for the review @wchevreuil

Sorry, I didn't find the ConnectionImplementation class in the master branch. If you mean the synchronous connection, then I think the synchronous connection is implemented based on asynchronous connection, so maybe only for asynchronous connection is enough ?

Yeah, you are right. My bad, I was looking at older branches. LGTM, assuming the UT failures are unrelated.

wchevreuil avatar Jul 13 '23 19:07 wchevreuil