hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27885 expose metaCacheHits in MetricsConnection

Open frostruan opened this issue 2 years ago • 14 comments

frostruan avatar May 24 '23 14:05 frostruan

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 37s master passed
+1 :green_heart: compile 0m 16s master passed
+1 :green_heart: shadedjars 4m 55s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 15s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 11s the patch passed
+1 :green_heart: compile 0m 16s the patch passed
+1 :green_heart: javac 0m 16s the patch passed
+1 :green_heart: shadedjars 4m 52s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 13s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 18s hbase-client in the patch passed.
20m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0be11d2734b9 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22526a6339
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/testReport/
Max. process+thread count 289 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 24 '23 15:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 14s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 59s master passed
+1 :green_heart: compile 0m 22s master passed
+1 :green_heart: shadedjars 4m 37s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 19s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 45s the patch passed
+1 :green_heart: compile 0m 19s the patch passed
+1 :green_heart: javac 0m 19s the patch passed
+1 :green_heart: shadedjars 4m 35s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 17s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 28s hbase-client in the patch passed.
21m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests javac javadoc unit shadedjars compile
uname Linux d99b0526cdf2 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22526a6339
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/testReport/
Max. process+thread count 299 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 24 '23 15:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 11s master passed
+1 :green_heart: compile 0m 37s master passed
+1 :green_heart: checkstyle 0m 14s master passed
+1 :green_heart: spotless 0m 42s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 0m 41s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 47s the patch passed
+1 :green_heart: compile 0m 33s the patch passed
+1 :green_heart: javac 0m 33s the patch passed
+1 :green_heart: checkstyle 0m 13s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 15m 29s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 :green_heart: spotless 0m 39s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 0m 45s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 9s The patch does not generate ASF License warnings.
37m 12s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux a6930ea80c58 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22526a6339
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 24 '23 15:05 Apache-HBase

Hi @frostruan thanks for the PR. Is it possible for you to add a call to validate the exposed metric getMetaCacheHits in any of the test cases under hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaCache.java? This would also help improve assertions in those tests.

NihalJain avatar May 25 '23 14:05 NihalJain

Ok. Will Address it ASAP. Thanks for the reviewing.

frostruan avatar May 25 '23 14:05 frostruan

Hi @NihalJain A test case has been added. Would you mind seeing if this is what you were expecting in your free time ?

frostruan avatar May 25 '23 17:05 frostruan

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 32s master passed
+1 :green_heart: compile 2m 55s master passed
+1 :green_heart: checkstyle 0m 45s master passed
-1 :x: spotless 0m 33s branch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 1m 59s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 32s the patch passed
+1 :green_heart: compile 2m 55s the patch passed
+1 :green_heart: javac 2m 55s the patch passed
+1 :green_heart: checkstyle 0m 46s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 23s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
-1 :x: spotless 0m 32s patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 2m 14s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
34m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux fb53f8c6302a 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ea3a44ea2d
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/artifact/yetus-general-check/output/branch-spotless.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 25 '23 18:05 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for branch
-1 :x: mvninstall 2m 27s root in master failed.
+1 :green_heart: compile 0m 52s master passed
+1 :green_heart: shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 36s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 12s the patch passed
+1 :green_heart: compile 0m 51s the patch passed
+1 :green_heart: javac 0m 51s the patch passed
+1 :green_heart: shadedjars 4m 54s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 34s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 21s hbase-client in the patch passed.
+1 :green_heart: unit 213m 22s hbase-server in the patch passed.
237m 24s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests javac javadoc unit shadedjars compile
uname Linux b93fe19a5144 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ea3a44ea2d
Default Java Temurin-1.8.0_352-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/testReport/
Max. process+thread count 4541 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 25 '23 21:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 49s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 49s master passed
+1 :green_heart: compile 1m 8s master passed
+1 :green_heart: shadedjars 4m 42s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 44s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 38s the patch passed
+1 :green_heart: compile 1m 8s the patch passed
+1 :green_heart: javac 1m 8s the patch passed
+1 :green_heart: shadedjars 4m 46s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 42s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 27s hbase-client in the patch passed.
+1 :green_heart: unit 222m 48s hbase-server in the patch passed.
249m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests javac javadoc unit shadedjars compile
uname Linux b4e25c62c342 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ea3a44ea2d
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/testReport/
Max. process+thread count 4858 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 25 '23 21:05 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 33s master passed
+1 :green_heart: compile 2m 53s master passed
+1 :green_heart: checkstyle 0m 45s master passed
-1 :x: spotless 0m 33s branch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 2m 0s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 30s the patch passed
+1 :green_heart: compile 2m 54s the patch passed
+1 :green_heart: javac 2m 54s the patch passed
+1 :green_heart: checkstyle 0m 46s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 27s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
-1 :x: spotless 0m 33s patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 2m 16s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 15s The patch does not generate ASF License warnings.
34m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 8043e5498887 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f347867440
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/artifact/yetus-general-check/output/branch-spotless.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 27 '23 06:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 28s master passed
+1 :green_heart: compile 0m 52s master passed
+1 :green_heart: shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 35s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 11s the patch passed
+1 :green_heart: compile 0m 52s the patch passed
+1 :green_heart: javac 0m 52s the patch passed
+1 :green_heart: shadedjars 4m 55s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 35s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 19s hbase-client in the patch passed.
+1 :green_heart: unit 211m 21s hbase-server in the patch passed.
234m 42s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests javac javadoc unit shadedjars compile
uname Linux e9ab165aebdc 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f347867440
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/testReport/
Max. process+thread count 4611 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 27 '23 09:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 56s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 35s master passed
+1 :green_heart: compile 1m 9s master passed
+1 :green_heart: shadedjars 4m 42s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 42s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 39s the patch passed
+1 :green_heart: compile 1m 9s the patch passed
+1 :green_heart: javac 1m 9s the patch passed
+1 :green_heart: shadedjars 4m 44s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 43s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 29s hbase-client in the patch passed.
+1 :green_heart: unit 222m 10s hbase-server in the patch passed.
247m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5253
Optional Tests javac javadoc unit shadedjars compile
uname Linux 83a0546281c2 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f347867440
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/testReport/
Max. process+thread count 4823 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5253/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 27 '23 09:05 Apache-HBase

Hi @frostruan thanks for addressing the comments. Just a query do you think this patch would be still useful since you have already raised a better solution at HBASE-27890/https://github.com/apache/hbase/pull/5257/?

Also could you please see if the patch does not introduce a spotless issue? I see pre checks failing.

NihalJain avatar Jun 01 '23 10:06 NihalJain

Thank you for your attention to this PR. I will address this issue together in https://issues.apache.org/jira/browse/HBASE-27890.

Thanks again for your help :)

frostruan avatar Jun 01 '23 11:06 frostruan