hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-22041 master should resolve regionserver's ip again when ConnectionException

Open YouChanchan opened this issue 2 years ago • 5 comments

According to the problem reflected by HBASE-22041, the root cause should be that the master will parse the ip of rs only when it gets RsAdmin for the first time, and then get rs admin from the ‘adminStubs’ map according to the key. At this time, if the wrong ip address is obtained, the master will always hold the wrong ip to retry. If the rs admin corresponding to the map is deleted, there will be a chance to resolve the ip again.

YouChanchan avatar Mar 23 '23 12:03 YouChanchan

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 59s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 27s master passed
+1 :green_heart: compile 3m 0s master passed
+1 :green_heart: checkstyle 0m 51s master passed
+1 :green_heart: spotless 0m 42s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 11s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 16s the patch passed
+1 :green_heart: compile 2m 57s the patch passed
+1 :green_heart: javac 2m 57s the patch passed
+1 :green_heart: checkstyle 0m 49s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 12m 20s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 :x: spotless 0m 35s patch has 29 errors when running spotless:check, run spotless:apply to fix.
+1 :green_heart: spotbugs 2m 25s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 20s The patch does not generate ASF License warnings.
41m 50s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5138
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 0c89c6693765 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7d6a79b768
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 23 '23 13:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 2m 18s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 34s master passed
+1 :green_heart: compile 1m 6s master passed
+1 :green_heart: shadedjars 4m 22s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 42s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 20s the patch passed
+1 :green_heart: compile 1m 6s the patch passed
+1 :green_heart: javac 1m 6s the patch passed
+1 :green_heart: shadedjars 4m 26s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 41s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 21s hbase-client in the patch passed.
+1 :green_heart: unit 208m 33s hbase-server in the patch passed.
236m 28s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5138
Optional Tests javac javadoc unit shadedjars compile
uname Linux c543c984710f 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7d6a79b768
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/testReport/
Max. process+thread count 2659 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 23 '23 16:03 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 31s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 37s master passed
+1 :green_heart: compile 1m 7s master passed
+1 :green_heart: shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 37s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 23s the patch passed
+1 :green_heart: compile 0m 55s the patch passed
+1 :green_heart: javac 0m 55s the patch passed
+1 :green_heart: shadedjars 4m 56s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 43s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 24s hbase-client in the patch passed.
-1 :x: unit 233m 34s hbase-server in the patch failed.
260m 41s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5138
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5afc99ce01f5 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7d6a79b768
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/testReport/
Max. process+thread count 2404 (vs. ulimit of 30000)
modules C: hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5138/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 23 '23 16:03 Apache-HBase

Ah, this is only for 2.5+...

https://issues.apache.org/jira/browse/HBASE-25336

We change to use Address instead of InetSocketAddress in the above issue...

Apache9 avatar Mar 26 '23 15:03 Apache9

So maybe we could apply this for branch-2.4 only? For fixing the problem on branch-2.4.

HBASE-25536 is kinda big so not suitable to be applied to branch-2.4.

Thanks.

Apache9 avatar Apr 08 '23 02:04 Apache9