hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27694 Exclude the older versions of netty pulling from Hadoop d…

Open chrajeshbabu opened this issue 1 year ago • 3 comments

…ependencies

chrajeshbabu avatar Mar 08 '23 11:03 chrajeshbabu

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 54s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 32s master passed
+1 :green_heart: compile 4m 22s master passed
+1 :green_heart: spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 22s the patch passed
+1 :green_heart: compile 4m 20s the patch passed
+1 :green_heart: javac 4m 20s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 7s The patch has no ill-formed XML file.
+1 :green_heart: hadoopcheck 12m 23s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 :green_heart: spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 1m 5s The patch does not generate ASF License warnings.
39m 52s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5094/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5094
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 7c87b8b0fd1b 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 16864c705c
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-asyncfs hbase-server hbase-mapreduce hbase-testing-util hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5094/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 08 '23 12:03 Apache-HBase

Can we make sure that removing this dependency is safe? Does hadoop still use netty 3? If not, why they still declare it as a dependency? And maybe zookeeper still depend on it? There is a discussion thread about upgrading zookeeper dependency, so maybe this is a reason to drop zookeeper 3.4?

Apache9 avatar Mar 08 '23 13:03 Apache9

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 23s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 57s master passed
+1 :green_heart: compile 1m 44s master passed
+1 :green_heart: shadedjars 4m 31s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 14s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 49s the patch passed
+1 :green_heart: compile 1m 44s the patch passed
+1 :green_heart: javac 1m 44s the patch passed
+1 :green_heart: shadedjars 4m 28s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 13s the patch passed
_ Other Tests _
+1 :green_heart: unit 8m 46s hbase-balancer in the patch passed.
+1 :green_heart: unit 0m 55s hbase-asyncfs in the patch passed.
+1 :green_heart: unit 207m 43s hbase-server in the patch passed.
-1 :x: unit 11m 19s hbase-mapreduce in the patch failed.
+1 :green_heart: unit 2m 7s hbase-testing-util in the patch passed.
+1 :green_heart: unit 0m 17s hbase-shaded-mapreduce in the patch passed.
+1 :green_heart: unit 0m 17s hbase-shaded-testing-util in the patch passed.
257m 58s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5094/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5094
Optional Tests javac javadoc unit shadedjars compile
uname Linux 53104145981c 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 16864c705c
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5094/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5094/1/testReport/
Max. process+thread count 2435 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-asyncfs hbase-server hbase-mapreduce hbase-testing-util hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5094/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 08 '23 15:03 Apache-HBase