hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27238 Backport backup restore to 2.x

Open rda3mon opened this issue 3 years ago • 28 comments

rda3mon avatar Sep 08 '22 05:09 rda3mon

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 52s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 27s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 16s branch-2 passed
+1 :green_heart: compile 1m 21s branch-2 passed
+1 :green_heart: shadedjars 3m 51s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 12s branch-2 passed
_ Patch Compile Tests _
-1 :x: mvninstall 0m 4s root in branch-2 failed.
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 0m 4s root in the patch failed.
-1 :x: compile 0m 4s root in the patch failed.
-0 :warning: javac 0m 4s root in the patch failed.
-1 :x: shadedjars 0m 3s patch has 12 errors when building our shaded downstream artifacts.
-0 :warning: javadoc 0m 4s root in the patch failed.
-0 :warning: javadoc 0m 8s hbase-assembly in the patch failed.
-0 :warning: javadoc 0m 4s hbase-backup in the patch failed.
-0 :warning: javadoc 0m 5s hbase-it in the patch failed.
_ Other Tests _
-1 :x: unit 0m 4s root in the patch failed.
13m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 42e84ba7bc8e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfd8501e23
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-root.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-assembly.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-backup.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-it.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/testReport/
Max. process+thread count 127 (vs. ulimit of 30000)
modules C: . hbase-assembly hbase-backup hbase-it hbase-mapreduce hbase-protocol-shaded hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 08 '22 05:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 46s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 53s branch-2 passed
+1 :green_heart: compile 1m 40s branch-2 passed
+1 :green_heart: shadedjars 4m 6s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 46s branch-2 passed
_ Patch Compile Tests _
-1 :x: mvninstall 0m 5s root in branch-2 failed.
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
-1 :x: mvninstall 0m 5s root in the patch failed.
-1 :x: compile 0m 5s root in the patch failed.
-0 :warning: javac 0m 5s root in the patch failed.
-1 :x: shadedjars 0m 3s patch has 12 errors when building our shaded downstream artifacts.
-0 :warning: javadoc 0m 5s root in the patch failed.
-0 :warning: javadoc 0m 8s hbase-assembly in the patch failed.
-0 :warning: javadoc 0m 4s hbase-backup in the patch failed.
-0 :warning: javadoc 0m 5s hbase-it in the patch failed.
_ Other Tests _
-1 :x: unit 0m 5s root in the patch failed.
15m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux d2266af483b9 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfd8501e23
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-assembly.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-it.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/testReport/
Max. process+thread count 146 (vs. ulimit of 30000)
modules C: . hbase-assembly hbase-backup hbase-it hbase-mapreduce hbase-protocol-shaded hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 08 '22 05:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: shelldocs 0m 1s Shelldocs was not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 51s branch-2 passed
+1 :green_heart: compile 6m 4s branch-2 passed
+1 :green_heart: checkstyle 0m 58s branch-2 passed
+1 :green_heart: spotless 0m 38s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 9m 50s branch-2 passed
_ Patch Compile Tests _
-1 :x: mvninstall 0m 5s root in branch-2 failed.
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 0m 5s root in the patch failed.
-1 :x: compile 0m 5s root in the patch failed.
-0 :warning: cc 0m 5s root in the patch failed.
-0 :warning: javac 0m 5s root in the patch failed.
-0 :warning: checkstyle 0m 2s The patch fails to run checkstyle in root
+1 :green_heart: shellcheck 0m 0s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 5s The patch has no ill-formed XML file.
-1 :x: hadoopcheck 0m 3s The patch causes 12 errors with Hadoop v3.2.4.
-1 :x: hadoopcheck 0m 5s The patch causes 12 errors with Hadoop v3.3.4.
-1 :x: hbaseprotoc 0m 4s root in the patch failed.
-1 :x: hbaseprotoc 0m 9s hbase-assembly in the patch failed.
-1 :x: hbaseprotoc 0m 3s hbase-backup in the patch failed.
-1 :x: hbaseprotoc 0m 6s hbase-it in the patch failed.
-1 :x: spotless 0m 2s patch has 12 errors when running spotless:check, run spotless:apply to fix.
-1 :x: spotbugs 0m 5s root in the patch failed.
-1 :x: spotbugs 0m 4s hbase-backup in the patch failed.
-1 :x: spotbugs 0m 5s hbase-it in the patch failed.
_ Other Tests _
+1 :green_heart: asflicense 0m 38s The patch does not generate ASF License warnings.
31m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool
uname Linux d165646be28c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfd8501e23
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-compile-root.txt
cc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-compile-root.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-hbaseprotoc-root.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-assembly.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-backup.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-it.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-spotbugs-root.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-backup.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-it.txt
Max. process+thread count 139 (vs. ulimit of 30000)
modules C: . hbase-assembly hbase-backup hbase-it hbase-mapreduce hbase-protocol-shaded hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/1/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 08 '22 06:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: shelldocs 0m 1s Shelldocs was not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 20s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 25s branch-2 passed
+1 :green_heart: compile 6m 2s branch-2 passed
+1 :green_heart: checkstyle 0m 59s branch-2 passed
+1 :green_heart: spotless 0m 38s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 9m 41s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 7s the patch passed
+1 :green_heart: compile 6m 17s the patch passed
+1 :green_heart: cc 6m 17s the patch passed
-0 :warning: javac 6m 17s root generated 50 new + 1159 unchanged - 0 fixed = 1209 total (was 1159)
+1 :green_heart: checkstyle 0m 58s the patch passed
+1 :green_heart: shellcheck 0m 2s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 4s The patch has no ill-formed XML file.
+1 :green_heart: hadoopcheck 8m 28s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 :green_heart: hbaseprotoc 4m 21s the patch passed
+1 :green_heart: spotless 0m 37s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 11m 3s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 51s The patch does not generate ASF License warnings.
62m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool
uname Linux da14de6039c8 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfd8501e23
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count 138 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/2/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 08 '22 07:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 47s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 20s branch-2 passed
+1 :green_heart: compile 1m 23s branch-2 passed
+1 :green_heart: shadedjars 3m 52s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 23s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 1s the patch passed
+1 :green_heart: compile 1m 23s the patch passed
+1 :green_heart: javac 1m 23s the patch passed
+1 :green_heart: shadedjars 3m 52s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 22s the patch passed
_ Other Tests _
-1 :x: unit 367m 14s root in the patch failed.
392m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux cbaac94e476f 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfd8501e23
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/2/testReport/
Max. process+thread count 5558 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 08 '22 12:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 18s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: shelldocs 0m 1s Shelldocs was not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 44s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 33s branch-2 passed
+1 :green_heart: compile 7m 43s branch-2 passed
+1 :green_heart: checkstyle 1m 8s branch-2 passed
+1 :green_heart: spotless 0m 42s branch has no errors when running spotless:check.
-1 :x: spotbugs 1m 33s hbase-server in branch-2 has 1 extant spotbugs warnings.
-1 :x: spotbugs 7m 47s root in branch-2 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 22s the patch passed
+1 :green_heart: compile 7m 11s the patch passed
+1 :green_heart: cc 7m 11s the patch passed
-0 :warning: javac 7m 11s root generated 50 new + 1159 unchanged - 0 fixed = 1209 total (was 1159)
+1 :green_heart: checkstyle 1m 6s the patch passed
+1 :green_heart: shellcheck 0m 2s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 6s The patch has no ill-formed XML file.
+1 :green_heart: hadoopcheck 9m 23s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 :green_heart: hbaseprotoc 5m 40s the patch passed
+1 :green_heart: spotless 0m 45s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 10s hbase-protocol-shaded in the patch passed.
+1 :green_heart: spotbugs 1m 33s hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart: spotbugs 0m 42s hbase-mapreduce in the patch passed.
+1 :green_heart: spotbugs 0m 42s hbase-backup in the patch passed.
+1 :green_heart: spotbugs 8m 20s root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart: spotbugs 0m 34s hbase-it in the patch passed.
_ Other Tests _
+1 :green_heart: asflicense 0m 55s The patch does not generate ASF License warnings.
75m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool
uname Linux 7770d033f8eb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count 139 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 12 '22 13:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 3m 57s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 53s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 47s branch-2 passed
+1 :green_heart: compile 1m 40s branch-2 passed
+1 :green_heart: shadedjars 4m 3s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 45s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 26s the patch passed
+1 :green_heart: compile 1m 43s the patch passed
+1 :green_heart: javac 1m 43s the patch passed
+1 :green_heart: shadedjars 4m 3s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 55s the patch passed
_ Other Tests _
+1 :green_heart: unit 237m 42s root in the patch passed.
267m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 33afc30f4216 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/testReport/
Max. process+thread count 5330 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 12 '22 16:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 49s Docker mode activated.
-0 :warning: yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 46s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 32s branch-2 passed
+1 :green_heart: compile 1m 46s branch-2 passed
+1 :green_heart: shadedjars 4m 24s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 3m 29s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 17s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 2m 4s the patch passed
+1 :green_heart: javac 2m 4s the patch passed
+1 :green_heart: shadedjars 4m 56s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 3m 46s the patch passed
_ Other Tests _
+1 :green_heart: unit 382m 35s root in the patch passed.
413m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 99be715ff43e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/testReport/
Max. process+thread count 4213 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 12 '22 19:09 Apache-HBase

@rda3mon I know this is still just a draft, but can you address the error-prone findings in the pre-commit? Shows up under javac: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Can you do it in a separate commit so that I can review it separately from the initial backport?

I re-ran the pre-commit hooks and all the tests are passing, the above is the only automated failure test remaining. The spotbugs error is a known issue which I think will be fixed in https://issues.apache.org/jira/browse/HBASE-27363

bbeaudreault avatar Sep 12 '22 20:09 bbeaudreault

@bbeaudreault These errors if I fix, would differ from master branch. right?

rda3mon avatar Sep 13 '22 00:09 rda3mon

@bbeaudreault Is there a way to run these checks locally? Pushing and checking might be tedious job to do for fixing non obvious ones.

rda3mon avatar Sep 13 '22 00:09 rda3mon

@rda3mon I find that the violations are usually pretty straightforward. If there are any that you have a question about, feel free to post here. I do think it's possible to run locally, maybe with -PerrorProne.

But actually, you could try including https://github.com/apache/hbase/commit/2c3abae18aa35e2693b64b143316817d4569d0c3 in your back port here. Seems like Andrew already handled these in master.

This has me wondering if there are other patches we need to include though.

bbeaudreault avatar Sep 13 '22 01:09 bbeaudreault

This has me wondering if there are other patches we need to include though

Highly unlikely. I did go into each of the commits from backup history to verify if anything is missed out. Looks like this pr was merged after that.

rda3mon avatar Sep 13 '22 01:09 rda3mon

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: shelldocs 0m 1s Shelldocs was not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 42s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 1s branch-2 passed
+1 :green_heart: compile 6m 0s branch-2 passed
+1 :green_heart: checkstyle 0m 57s branch-2 passed
+1 :green_heart: spotless 0m 36s branch has no errors when running spotless:check.
-1 :x: spotbugs 1m 12s hbase-server in branch-2 has 1 extant spotbugs warnings.
-1 :x: spotbugs 6m 19s root in branch-2 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
-1 :x: mvninstall 2m 3s root in the patch failed.
-1 :x: compile 5m 49s root in the patch failed.
-0 :warning: cc 5m 49s root in the patch failed.
-0 :warning: javac 5m 49s root in the patch failed.
+1 :green_heart: checkstyle 1m 0s the patch passed
+1 :green_heart: shellcheck 0m 0s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 5s The patch has no ill-formed XML file.
-1 :x: hadoopcheck 1m 50s The patch causes 15 errors with Hadoop v3.2.4.
-1 :x: hadoopcheck 3m 44s The patch causes 15 errors with Hadoop v3.3.4.
-1 :x: hbaseprotoc 0m 13s hbase-backup in the patch failed.
-1 :x: hbaseprotoc 2m 23s root in the patch failed.
+1 :green_heart: spotless 0m 37s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 43s hbase-protocol-shaded in the patch passed.
+1 :green_heart: spotbugs 1m 20s hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart: spotbugs 0m 30s hbase-mapreduce in the patch passed.
-1 :x: spotbugs 0m 12s hbase-backup in the patch failed.
+1 :green_heart: spotbugs 0m 24s hbase-it in the patch passed.
-1 :x: spotbugs 6m 1s root in the patch failed.
_ Other Tests _
+1 :green_heart: asflicense 0m 51s The patch does not generate ASF License warnings.
52m 0s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool
uname Linux 8c427c8e196a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-compile-root.txt
cc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-compile-root.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-backup.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-hbaseprotoc-root.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-spotbugs-hbase-backup.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-spotbugs-root.txt
Max. process+thread count 139 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 03:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 51s Docker mode activated.
-0 :warning: yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 45s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 34s branch-2 passed
+1 :green_heart: compile 1m 41s branch-2 passed
+1 :green_heart: shadedjars 4m 4s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 44s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
-1 :x: mvninstall 2m 30s root in the patch failed.
-1 :x: compile 1m 32s root in the patch failed.
-0 :warning: javac 1m 32s root in the patch failed.
+1 :green_heart: shadedjars 4m 2s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 56s the patch passed
_ Other Tests _
-1 :x: unit 232m 20s root in the patch failed.
258m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 837fcfc98346 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/testReport/
Max. process+thread count 5111 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 06:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 44s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 50s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 14s branch-2 passed
+1 :green_heart: compile 1m 21s branch-2 passed
+1 :green_heart: shadedjars 3m 51s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 18s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 14s Maven dependency ordering for patch
-1 :x: mvninstall 2m 2s root in the patch failed.
-1 :x: compile 1m 16s root in the patch failed.
-0 :warning: javac 1m 16s root in the patch failed.
+1 :green_heart: shadedjars 3m 51s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 27s the patch passed
_ Other Tests _
-1 :x: unit 353m 41s root in the patch failed.
377m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8267e9411de4 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/testReport/
Max. process+thread count 4352 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 08:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 44s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 6s branch-2 passed
+1 :green_heart: compile 6m 7s branch-2 passed
+1 :green_heart: checkstyle 1m 0s branch-2 passed
+1 :green_heart: spotless 0m 37s branch has no errors when running spotless:check.
-1 :x: spotbugs 1m 12s hbase-server in branch-2 has 1 extant spotbugs warnings.
-1 :x: spotbugs 6m 20s root in branch-2 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 3s the patch passed
+1 :green_heart: compile 6m 13s the patch passed
+1 :green_heart: cc 6m 13s the patch passed
-0 :warning: javac 6m 13s root generated 3 new + 1159 unchanged - 0 fixed = 1162 total (was 1159)
+1 :green_heart: checkstyle 0m 57s the patch passed
+1 :green_heart: shellcheck 0m 1s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 4s The patch has no ill-formed XML file.
+1 :green_heart: hadoopcheck 8m 23s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 :green_heart: hbaseprotoc 4m 22s the patch passed
+1 :green_heart: spotless 0m 38s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 40s hbase-protocol-shaded in the patch passed.
+1 :green_heart: spotbugs 1m 18s hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart: spotbugs 0m 31s hbase-mapreduce in the patch passed.
+1 :green_heart: spotbugs 0m 27s hbase-backup in the patch passed.
+1 :green_heart: spotbugs 0m 25s hbase-it in the patch passed.
+1 :green_heart: spotbugs 6m 42s root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 :green_heart: asflicense 0m 50s The patch does not generate ASF License warnings.
62m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool
uname Linux c07c4849cec4 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count 138 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 09:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 46s Docker mode activated.
-0 :warning: yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 15s branch-2 passed
+1 :green_heart: compile 1m 42s branch-2 passed
+1 :green_heart: shadedjars 4m 6s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 46s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 24s the patch passed
+1 :green_heart: compile 1m 42s the patch passed
+1 :green_heart: javac 1m 42s the patch passed
+1 :green_heart: shadedjars 4m 3s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 3m 5s the patch passed
_ Other Tests _
+1 :green_heart: unit 237m 47s root in the patch passed.
265m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9fc12827fa7b 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/testReport/
Max. process+thread count 5226 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 13:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 44s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 1m 59s branch-2 passed
+1 :green_heart: compile 1m 21s branch-2 passed
+1 :green_heart: shadedjars 3m 50s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 10s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 0s the patch passed
+1 :green_heart: compile 1m 25s the patch passed
+1 :green_heart: javac 1m 25s the patch passed
+1 :green_heart: shadedjars 3m 50s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 33s the patch passed
_ Other Tests _
-1 :x: unit 300m 24s root in the patch failed.
322m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0acb041a67ef 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7ae66a1d2e
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/testReport/
Max. process+thread count 2940 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 13:09 Apache-HBase

@rda3mon looks like that cherry-pick resolved most of the error prone issues. Looks like there are 3 left: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt

They look pretty simple/javadoc related. would you mind pushing 1 more commit to fix those. otherwise the build looks clean; the test failure looks unrelated. once you push that fix, i can re-run the tests if needed.

Gonna start reviewing the code this week hopefully.

Can you link me to specific areas of this PR that had merge conflicts or net-new code, if possible. I know in slack you mentioned WALPlayer; I'll take a look at that. Any others would be helpful

bbeaudreault avatar Sep 13 '22 14:09 bbeaudreault

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: shelldocs 0m 1s Shelldocs was not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 4s branch-2 passed
+1 :green_heart: compile 6m 3s branch-2 passed
+1 :green_heart: checkstyle 1m 2s branch-2 passed
+1 :green_heart: spotless 0m 36s branch has no errors when running spotless:check.
-1 :x: spotbugs 1m 13s hbase-server in branch-2 has 1 extant spotbugs warnings.
-1 :x: spotbugs 6m 23s root in branch-2 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 3s the patch passed
+1 :green_heart: compile 6m 9s the patch passed
+1 :green_heart: cc 6m 9s the patch passed
+1 :green_heart: javac 6m 9s the patch passed
+1 :green_heart: checkstyle 0m 59s the patch passed
+1 :green_heart: shellcheck 0m 1s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 4s The patch has no ill-formed XML file.
+1 :green_heart: hadoopcheck 8m 19s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 :green_heart: hbaseprotoc 4m 19s the patch passed
+1 :green_heart: spotless 0m 38s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 40s hbase-protocol-shaded in the patch passed.
+1 :green_heart: spotbugs 1m 20s hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart: spotbugs 0m 29s hbase-mapreduce in the patch passed.
+1 :green_heart: spotbugs 0m 27s hbase-backup in the patch passed.
+1 :green_heart: spotbugs 0m 23s hbase-it in the patch passed.
+1 :green_heart: spotbugs 6m 41s root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 :green_heart: asflicense 0m 50s The patch does not generate ASF License warnings.
61m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool
uname Linux dac57ef7b314 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 74126ea647
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
Max. process+thread count 138 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 15:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 44s Docker mode activated.
-0 :warning: yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 29s branch-2 passed
+1 :green_heart: compile 1m 41s branch-2 passed
+1 :green_heart: shadedjars 4m 6s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 43s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 28s the patch passed
+1 :green_heart: compile 1m 41s the patch passed
+1 :green_heart: javac 1m 41s the patch passed
+1 :green_heart: shadedjars 4m 5s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 3m 3s the patch passed
_ Other Tests _
+1 :green_heart: unit 238m 43s root in the patch passed.
265m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 95dfbd09762e 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 74126ea647
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/testReport/
Max. process+thread count 5141 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 19:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 52s Docker mode activated.
-0 :warning: yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 1m 59s branch-2 passed
+1 :green_heart: compile 1m 21s branch-2 passed
+1 :green_heart: shadedjars 3m 50s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 11s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 3s the patch passed
+1 :green_heart: compile 1m 24s the patch passed
+1 :green_heart: javac 1m 24s the patch passed
+1 :green_heart: shadedjars 3m 50s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 30s the patch passed
_ Other Tests _
+1 :green_heart: unit 369m 22s root in the patch passed.
393m 25s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0c3ea60c2b99 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 74126ea647
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/testReport/
Max. process+thread count 4257 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/6/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 21:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 1s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 8s branch-2 passed
+1 :green_heart: compile 6m 16s branch-2 passed
+1 :green_heart: checkstyle 0m 59s branch-2 passed
+1 :green_heart: spotless 0m 36s branch has no errors when running spotless:check.
-1 :x: spotbugs 1m 11s hbase-server in branch-2 has 1 extant spotbugs warnings.
-1 :x: spotbugs 6m 21s root in branch-2 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 2s the patch passed
+1 :green_heart: compile 6m 10s the patch passed
+1 :green_heart: cc 6m 10s the patch passed
+1 :green_heart: javac 6m 10s the patch passed
+1 :green_heart: checkstyle 0m 58s the patch passed
+1 :green_heart: shellcheck 0m 0s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 5s The patch has no ill-formed XML file.
+1 :green_heart: hadoopcheck 8m 20s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 :green_heart: hbaseprotoc 4m 22s the patch passed
+1 :green_heart: spotless 0m 37s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 42s hbase-protocol-shaded in the patch passed.
+1 :green_heart: spotbugs 1m 18s hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart: spotbugs 0m 31s hbase-mapreduce in the patch passed.
+1 :green_heart: spotbugs 0m 28s hbase-backup in the patch passed.
+1 :green_heart: spotbugs 0m 24s hbase-it in the patch passed.
+1 :green_heart: spotbugs 6m 46s root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 :green_heart: asflicense 0m 50s The patch does not generate ASF License warnings.
61m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool
uname Linux a8960117191e 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 74126ea647
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
Max. process+thread count 140 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '22 22:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 52s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 22s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 50s branch-2 passed
+1 :green_heart: compile 1m 40s branch-2 passed
+1 :green_heart: shadedjars 4m 3s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 44s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 28s the patch passed
+1 :green_heart: compile 1m 41s the patch passed
+1 :green_heart: javac 1m 41s the patch passed
+1 :green_heart: shadedjars 4m 8s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 58s the patch passed
_ Other Tests _
+1 :green_heart: unit 242m 48s root in the patch passed.
269m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux c9f948ac35a6 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 74126ea647
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/testReport/
Max. process+thread count 5364 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 14 '22 01:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 53s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 14s branch-2 passed
+1 :green_heart: compile 1m 24s branch-2 passed
+1 :green_heart: shadedjars 3m 55s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 15s branch-2 passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 2s the patch passed
+1 :green_heart: compile 1m 24s the patch passed
+1 :green_heart: javac 1m 24s the patch passed
+1 :green_heart: shadedjars 3m 52s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 28s the patch passed
_ Other Tests _
+1 :green_heart: unit 367m 53s root in the patch passed.
392m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux fb2020cc25dd 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 74126ea647
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/testReport/
Max. process+thread count 4205 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 14 '22 03:09 Apache-HBase

@bbeaudreault Moved to review from draft. Please check.

No new code added. Only 2 commits were cherry-picked from master https://github.com/apache/hbase/commit/6cfa208add6ea424e17cae00114ebd3e7d7967f1 https://github.com/apache/hbase/commit/acbc3a225338fd1ff82226ebbd937f7b15ef5b60

on merge conflicts: WALPlayer.java has changed from 2.x to 3.x And that was the reason for conflicts. I have resolved them to the best of my knowledge. You should spend some time here to see if it looks fine.

rda3mon avatar Sep 14 '22 06:09 rda3mon

Sorry for the delay here. We are currently evaluating internally in our fork. Will get to reviewing in the near future.

bbeaudreault avatar Sep 21 '22 02:09 bbeaudreault

May still be a bit, but I'm finally starting to look at this now. Looks like it's almost all net-new code.

I checked out this branch and the following:

git diff --color --name-only --diff-filter=A branch-2 HBASE-27238-backport-backup-restore-to-2.x | xargs -I{} git diff master -- {}

Auditing the output, it shows that all of the net-new files here are relatively identical to the files from master. There are a few discrepancies, but all related to HBaseTestingUtility vs HBaseTestingUtil (an unfortunate difference between master/branch-2).

The files with actual changes fall into four categories:

  1. pom.xmls -- all seem basic boilerplate
  2. hbase shell change -- just adds support for backup/restore, looks good
  3. java files in test directories
  4. java files in source directories

There are only 3 source directory java file changes, and 2 in test. I'll be focusing my efforts on those.

bbeaudreault avatar Nov 15 '22 22:11 bbeaudreault

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 52s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 :ok: mvndep 0m 17s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 26s branch-2 passed
+1 :green_heart: compile 1m 25s branch-2 passed
+1 :green_heart: shadedjars 3m 57s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 2m 16s branch-2 passed
_ Patch Compile Tests _
-1 :x: mvninstall 0m 5s root in branch-2 failed.
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 0m 5s root in the patch failed.
-1 :x: compile 0m 4s root in the patch failed.
-0 :warning: javac 0m 4s root in the patch failed.
-1 :x: shadedjars 0m 3s patch has 60 errors when building our shaded downstream artifacts.
-0 :warning: javadoc 0m 5s root in the patch failed.
-0 :warning: javadoc 0m 7s hbase-assembly in the patch failed.
-0 :warning: javadoc 0m 4s hbase-backup in the patch failed.
-0 :warning: javadoc 0m 5s hbase-it in the patch failed.
_ Other Tests _
-1 :x: unit 0m 5s root in the patch failed.
14m 13s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4770
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9062d6def511 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2fdefdc273
Default Java Temurin-1.8.0_352-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-root.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-assembly.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-backup.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-it.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/testReport/
Max. process+thread count 127 (vs. ulimit of 30000)
modules C: . hbase-assembly hbase-backup hbase-it hbase-mapreduce hbase-protocol-shaded hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/8/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 06 '23 16:01 Apache-HBase